[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #37 from Fedora Update System  ---
primesieve-7.4-2.fc30 has been pushed to the Fedora 30 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #36 from Fedora Update System  ---
primesieve-7.4-2.fc29 has been pushed to the Fedora 29 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2019-05-04 01:17:21



--- Comment #35 from Fedora Update System  ---
primesieve-7.4-2.fc28 has been pushed to the Fedora 28 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #34 from Petr Menšík  ---
(In reply to Peter Lemenkov from comment #26)
> Unblocking FE-NEEDSPONSOR - I've just sponsored Kim.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #33 from Fedora Update System  ---
primesieve-7.4-2.fc30 has been pushed to the Fedora 30 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-f28b079ec8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #32 from Fedora Update System  ---
primesieve-7.4-2.fc29 has been pushed to the Fedora 29 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-aa041346ac

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #31 from Fedora Update System  ---
primesieve-7.4-2.fc28 has been pushed to the Fedora 28 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-7ced30d8d6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #30 from Fedora Update System  ---
primesieve-7.4-2.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-7ced30d8d6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #29 from Fedora Update System  ---
primesieve-7.4-2.fc29 has been submitted as an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-aa041346ac

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #28 from Fedora Update System  ---
primesieve-7.4-2.fc30 has been submitted as an update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-f28b079ec8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #27 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/primesieve

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335

Peter Lemenkov  changed:

   What|Removed |Added

 CC||lemen...@gmail.com
 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #26 from Peter Lemenkov  ---
Unblocking FE-NEEDSPONSOR - I've just sponsored Kim.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #25 from Kim Walisch  ---
> Can you retry persuading someone to sponsor you? Having acked review might 
> help you.

OK, I'll give it another try.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #24 from Petr Menšík  ---
Until you have a sponsor, unfortunately you cannot package your own package.
Yes, having a sponsor is mandatory, that step cannot be skipped.

I am considering becoming a sponsor myself, but not yet able to become sponsor.
Can you retry persuading someone to sponsor you? Having acked review might help
you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #23 from Kim Walisch  ---
> Anyway, I am sure this can be corrected before first build. Next steps are 
> described on [1].

It is not clear to me what I have to do next. I have read the [1] documentation
but this describes mainly that I have to introduce myself on the Fedora devel
mailing list with the goal to find a sponsor for my package. As I have
mentioned to you before I have already tried to find a sponsor about a year ago
but all my attempts failed. Is it mandatory that I find a sponsor for
primesieve in order to proceed? Or can we skip this step?

So I tried to request a repo using the fedpkg tool yesterday (which was the
next item in the [1] documentation). But my request was "Closed: Invalid", see
https://pagure.io/releng/fedora-scm-requests/issue/11093.

So what exactly do I need to do next?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335

Petr Menšík  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #22 from Petr Menšík  ---
Correct, libs have to be required no matter what name it uses, it has to match.
%{name}-libs%{?_isa} = %{version}-%{release} would be correct replacement.

Anyway, I am sure this can be corrected before first build. Next steps are
described on [1].

1.
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Inform_Upstream

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #21 from Kim Walisch  ---
> Ok, still not follows usual convention of addon packages [1], but that is 
> just should.

I was confused by:

> Ok, made mistake with offered Provides in 2):
> Correct version would be:
> Provides: lib%{name}%{?_isa} = %{version}-%{release}

That's why I kept libprimesieve as a package name. I guess if I change
libprimesieve to primesieve-libs then I would also have to use
{name}-libs%{?_isa} = %{version}-%{release} ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335

Petr Menšík  changed:

   What|Removed |Added

  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #20 from Petr Menšík  ---
Ok, still not follows usual convention of addon packages [1], but that is just
should.

1.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_addon_packages

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Header files in -devel subpackage, if present.
  Note: primesieve-debugsource :
  /usr/src/debug/primesieve-7.4-1.fc29.x86_64/include/primesieve.h
  primesieve-debugsource :
  /usr/src/debug/primesieve-7.4-1.fc29.x86_64/include/primesieve/iterator.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in libprimesieve
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (unspecified)", "BSD 2-clause "Simplified" License", "GPL
 (v3 or later)", "Unknown or generated". 118 files have unknown
 license. Detailed output of licensecheck in
 /home/reviewer/reviews/1540335-primesieve/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/.build-id(libmad,
 cups-client, efivar-libs, qemu-block-gluster, rpm-plugin-selinux,
 abrt, libmediaart, libimagequant, giflib, libreoffice-graphicfilter,
 trousers, qemu-ui-gtk, libdb-utils, tracker-miners, xorg-x11-font-
 utils, PackageKit-command-not-found, OpenEXR-libs, python2-setools,
 libcom_err, libseccomp, p11-kit, libabw, gtkspell, libvirt-daemon-
 driver-storage-iscsi, libid3tag, libmodman, argyllcms, parted, gnome-
 disk-utility, libdvdread, zstd, bluez-libs, kf5-kjobwidgets, libwebp,
 libxslt, system-config-printer-udev, perl-Encode, libverto-libev,
 python2-cryptography, kf5-kdeclarative, libevdev, libgpg-error,
 libmaxminddb, lvm2-libs, kf5-sonnet-core, libpurple, perl-Digest-SHA,
 python3-unbound, kf5-solid, libzstd, libdazzle, xdg-desktop-portal-
 gtk, lua-lpeg, symlinks, python3-crypto, libcdr, b43-fwcutter,
 e2fsprogs-libs, pulseaudio-libs, tpm2-tools, lcms2, qemu-guest-agent,
 annobin, deltarpm, libxcb, libyubikey, python3-pycurl, python3-brlapi,
 openconnect, xcb-util-keysyms, m4, sushi, libgphoto2, cdparanoia, xcb-
 util, gvfs-fuse, boost-fiber, mc, udisks2-iscsi, python3-coverage,
 anaconda-widgets, http-parser, qt5-qtspeech, pulseaudio-utils,
 python3-wrapt, rubygem-hpricot, perl-PerlIO-utf8_strict,
 openjpeg2-tools, compat-wxGTK3-gtk2, systemd-bootchart, kf5-kpackage,
 perl-JSON-XS, kf5-kfilemetadata, texlive-pdftex, perl-Time-Piece,
 dbusmenu-qt, ncurses-libs, libidn2, ldns, libreport-plugin-logger,
 gnome-color-manager, fcoe-utils, xorg-x11-xkb-utils, ibus-hangul,
 NetworkManager-openvpn, libxkbfile, hplip-libs, libwvstreams, freerdp-
 libs, xmlrpc-c-client, sane-backends-drivers-cameras, python3-hawkey,
 libwpd, enchant2, libdc1394, libvirt-daemon-driver-qemu, perl-Time-
 HiRes, qemu-block-ssh, libwps, gssdp, kf5-knotifications, libacl,
 xorg-x11-drv-ati, libSM, policycoreutils, mcelog, abrt-plugin-bodhi,
 libmusicbrainz5, perl-Digest-SHA3, perl-Digest-SHA1, sane-backends-
 drivers-scanners, libXxf86misc, foomatic, texlive-dvips, mediawriter,
 colord-gtk, libpath_utils, libicu-devel, rpm-build, wodim, libvirt-
 daemon-driver-storage-sheepdog, libglvnd-gles, python3-audit, rpm-
 plugin-systemd-inhibit, libmicrodns, freeglut, gstreamer1, bsdtar,
 gom, unbound, ykpers, libtomcrypt, dbus-libs, libreoffice-gtk3,
 libreoffice-gtk2, boost-wave, cairo-gobject, vim-minimal, gnome-
 screenshot, fping, libkkc, gutenprint, openal-soft, usermode, qpdf-
 libs, linux-atm-libs, libedit, openssh, openssl, python3-cairo,
 python2-libdnf, accountsservice, isl, hfsplus-tools, ImageMagick,
 gssproxy, mesa-libGLU, libblockdev-btrfs, 

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #19 from Kim Walisch  ---
I have updated primesieve's spec file and built a new SRPM:

Spec URL:
https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/v7.4-1/primesieve.spec
SRPM URL:
https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/v7.4-1/primesieve-7.4-1.fc29.src.rpm

Hers's the link to the successful koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=34055406

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #18 from Petr Menšík  ---
(In reply to Kim Walisch from comment #16)
> > The primesieve GUI application does not work properly using Qt5.
> 
> Actually I have now retested this on Ubuntu 18.04 with GNOME and it works
> fine. So the Qt5 issue I mentioned before only affects Windows as I have
> implemented a workaround that works fine on Linux (but not on Windows). The
> primesieve GUI application also does also not work properly using the
> Ubuntu's Unity desktop (that has recently been deprecated).
> 
> Personally I would prefer not to include the primesieve GUI application
> because ensuring it works fine on all the different desktop spins is a bit
> of a nightmare...

Ok. It seems to me you use some unportable behaviour that makes you application
unstable. I think printProcessOutput() should emit signals with new values and
should not even try to call processEvents or manually redraw. Instead, it
should run in worker thread and timer should periodically redraw new results,
until job is finished. processEvents should be only the main one for your
applications, other should use signal-slot connections processed from main
loop. No main thread blocking should occur. Stackoverflow might help [1]

Anyway, no problem with not packaging it if you think it is not ready. Worked
to me yesteray without any crash.

1.
https://stackoverflow.com/questions/14545961/modify-qt-gui-from-background-worker-thread

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #17 from Petr Menšík  ---
(In reply to Kim Walisch from comment #15)
> > Other than these few issues, package is ready to be packaged in Fedora. 
> > Good job for first package!
> 
> Thanks! I will fix the issues you have pointed out.
> 
> > 3) Unless there is expected usage of static libraries, that offers 
> > significant speed advantage, I would omit static subpackage. It requires 
> > explicit exception and I doubt it is required. Use rm to remove *.la in 
> > %build or %install phase. [1]
> 
> If I build using 'cmake . -DBUILD_STATIC_LIBS=OFF' do I still need to do
> "Use rm to remove *.la in %build or %install phase"?

Anything that prevents installation (or build) of static libraries is okay.
Your solution is clearer, happy with that. rm is suggested only because it
always work, even without support in build system.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #16 from Kim Walisch  ---
> The primesieve GUI application does not work properly using Qt5.

Actually I have now retested this on Ubuntu 18.04 with GNOME and it works fine.
So the Qt5 issue I mentioned before only affects Windows as I have implemented
a workaround that works fine on Linux (but not on Windows). The primesieve GUI
application also does also not work properly using the Ubuntu's Unity desktop
(that has recently been deprecated).

Personally I would prefer not to include the primesieve GUI application because
ensuring it works fine on all the different desktop spins is a bit of a
nightmare...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #15 from Kim Walisch  ---
> Other than these few issues, package is ready to be packaged in Fedora. Good 
> job for first package!

Thanks! I will fix the issues you have pointed out.

> 3) Unless there is expected usage of static libraries, that offers 
> significant speed advantage, I would omit static subpackage. It requires 
> explicit exception and I doubt it is required. Use rm to remove *.la in 
> %build or %install phase. [1]

If I build using 'cmake . -DBUILD_STATIC_LIBS=OFF' do I still need to do "Use
rm to remove *.la in %build or %install phase"?

> Just a question, it has also working GUI with a different license (GPLv3). Is 
> there some reason why gui variant is not packaged?

The reason why the GUI version is e.g. not packaged in Debian and Homebrew is
because it depends on Qt4 and does not work properly using Qt5. Qt4 allows
signal recursion (see
https://github.com/kimwalisch/primesieve/blob/master/src/gui/src/PrimeSieveGUI.cpp#L301)
which primesieve depends upon while Qt5 does not. Using Qt5 the primesieve GUI
application often crashes after running it for just a few seconds. I have
already tried to find a workaround for this issue in the past but I have not
succeeded. That's why primesieve is stuck with Qt4. If we would include the
primesieve GUI application into the Fedora package this would cause issues once
Qt4 will be deprecated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #14 from Petr Menšík  ---
Ok, made mistake with offered Provides in 2):

Correct version would be:
Provides: lib%{name}%{?_isa} = %{version}-%{release}

Just a question, it has also working GUI with a different license (GPLv3). Is
there some reason why gui variant is not packaged? Subpackage with gui variant
would not hurt I think, would you need help with that? License tag is correct
for command line version, gui subpackage would require License: BSD and GPLv3+

I checked it is not packaged also on Debian [2]. Compiled just fine to me, some
Qt dependencies would be required, should not be difficult. Not mandatory for
review, would be nice to have it.

2. https://packages.debian.org/source/sid/primesieve

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #13 from Petr Menšík  ---
(In reply to Jani Juhani Sinervo from comment #11)
> (In reply to Kim Walisch from comment #10)
> > Thanks for your review.
> 
> > The Rpmlint spelling-error warnings are false positives.
> 
> Oh, good to know for future reference! I was actually thinking if that would
> actually affect the review outcome significantly in an actual review. I
> included it as a "problem" in that preliminary review just in case.
> 
> --
> 
> But yeah, with the fix to the ldconfig problem sorted, and updating to the
> new version, I'd see no problems with this being included. But I'll leave
> the decision for someone less amateurish than I. But while we wait for an
> official review, here's an updated preliminary review for this new version.
> 

I think your review was a good one, there is no need for package to be perfect.
It met basic requirements, you did review it well. Please, do not be afraid
giving it approval next time. It would not provide sponsor, but mark is as
acceptable. We can always submit bugs to fix not important issues.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335

Petr Menšík  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||pemen...@redhat.com
   Assignee|nob...@fedoraproject.org|pemen...@redhat.com



--- Comment #12 from Petr Menšík  ---
1) Primary package primesieve does not depend on library. Requires is currently
part of %description, where it does not have effect. Move it before description
please.

2) In Fedora, lib is not common for libraries. Instead, -libs is
usually used. If there is no strong objection, I would suggest using just
%package libs, %files libs.
If you want to keep compatibility with Debian naming, use Provides:
libprimesieve%{?_isa} = libprimesieve-%{version}. It would still be accepted in
yum install libprimesieve or other package dependencies. Some tool write
warnings because it lacks common prefix, fedora-review tool is one of them.
Note -n parameter is not required in this case
Similar issue is with %package devel, %files devel.

3) Unless there is expected usage of static libraries, that offers significant
speed advantage, I would omit static subpackage. It requires explicit exception
and I doubt it is required. Use rm to remove *.la in %build or %install phase.
[1]

4) %ldconfig_scriptlets libs should be used, only for library package it should
be used. In current setup, %ldconfig_scriptlets -n libprimesieve would have to
be used instead.

5) New version should be used now, since more recent release is available. I
know, it was up to date when started. Sorry :)

Other than these few issues, package is ready to be packaged in Fedora. Good
job for first package!

1.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #11 from Jani Juhani Sinervo  ---
(In reply to Kim Walisch from comment #10)
> Thanks for your review.

> The Rpmlint spelling-error warnings are false positives.

Oh, good to know for future reference! I was actually thinking if that would
actually affect the review outcome significantly in an actual review. I
included it as a "problem" in that preliminary review just in case.

--

But yeah, with the fix to the ldconfig problem sorted, and updating to the new
version, I'd see no problems with this being included. But I'll leave the
decision for someone less amateurish than I. But while we wait for an official
review, here's an updated preliminary review for this new version.


This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (unspecified)", "BSD (2 clause)", "GPL (v3 or later)",
 "Unknown or generated". 114 files have unknown license. Detailed
 output of licensecheck in
 /home/jani/review_stuff/1540335-primesieve/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 962560 bytes in 179 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #10 from Kim Walisch  ---
Thanks for your review.

> Issues:
> - ldconfig called in %post and %postun if required.
> Note: /sbin/ldconfig not called in libprimesieve

I actually had that in an earlier version of primesieve.spec (see
https://github.com/kimwalisch/primesieve-rpm/commit/4604d88f2367181280ac6cc9acaff9b63eabfede#diff-d4de19401a23eecc5feccba05f2a05d9L48).
But following the suggestion of Jerry James (%post -p /sbin/ldconfig & %postun
-p /sbin/ldconfig should be replaced with this: %ldconfig_scriptlets) I
replaced that code by %ldconfig_scriptlets. So can we drop your ldconfig issue?

I have fixed the following Rpmlint error:

> primesieve.src: E: specfile-error warning: bogus date in %changelog: Thu Feb 
> 16 2018 Kim Walisch  - 6.4-4

The Rpmlint spelling-error warnings are false positives.


I have updated the primesieve package to the latest primesieve-7.0 version:

Spec URL:
https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/v7.0-1/primesieve.spec
SRPM URL:
https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/v7.0-1/primesieve-7.0-1.fc27.src.rpm

Hers's the link to the successful koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=28083380

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/E4XVWEYKSMTE7AI3RMGWU3FMOIIYABJN/

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335

Jani Juhani Sinervo  changed:

   What|Removed |Added

 CC||j...@sinervo.fi



--- Comment #9 from Jani Juhani Sinervo  ---
(In reply to Kim Walisch from comment #8)

> I am still looking for a sponsor for the primesieve package. The development
> of primesieve was started 8 years ago and it is now very mature i.e.
> primesieve builds and runs successfully on every single CPU architecture
> supported by both Fedora and Debian.

Well, I cannot help you with the sponsoring thing, but here's a preliminary
(unofficial) package review

I'd probably move the API documentations into their own packages, but that's
just me.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
===
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in libprimesieve
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (unspecified)", "BSD (2 clause)", "GPL (v3 or later)",
 "Unknown or generated". 107 files have unknown license. Detailed
 output of licensecheck in
 /home/jani/review_stuff/1540335-primesieve/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 942080 bytes in 179 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
 present.
 Note: Package has .a files: libprimesieve-static.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD 

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #8 from Kim Walisch  ---
I have released primesieve-6.4 on GitHub yesterday. Today I have updated the
primesieve spec file and corresponding SRPM package to version 6.4:

Spec URL:
https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/v6.4-5/primesieve.spec
SRPM URL:
https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/v6.4-5/primesieve-6.4-5.fc27.src.rpm

Hers's the link to the successful koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25943211

I am still looking for a sponsor for the primesieve package. The development of
primesieve was started 8 years ago and it is now very mature i.e. primesieve
builds and runs successfully on every single CPU architecture supported by both
Fedora and Debian.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #7 from Kim Walisch  ---
Hi Micheal,

I have released a new version of the primesieve spec file and corresponding
SRPM package: 

Spec URL:
https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/master/primesieve.spec
SRPM URL:
https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/master/primesieve-6.4-4.fc27.src.rpm

> primesieve : for the executable
> libprimesieve : for the shared runtime lib
> libprimesieve-devel : for the shared buildtime lib
> libprimesieve-static : for the static lib

I like your idea of adding a libprimesieve package so I have implemented that.
Previously, if the user would have installed the libprimesieve-devel package
this would also install the primesieve package with the binary. This issue is
fixed now.

> you may also drop the primesieve package and include it in the libprimesieve 
> package.

I don't like this idea because most users will be interested in the primesieve
binary and I want users to be able to install the binary with 'dnf install
primesieve'.

I have also improved the summaries and descriptions of the different packages.

Hers's the link to the successful koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25096373

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #6 from Michael Schwendt  ---
> 1)

That is a recent change indeed.
https://fedoraproject.org/wiki/Packaging:Scriptlets#Shared_Libraries


> 3)

If the package naming bugs you that much, you could go a step further and build
the following packages:

  primesieve : for the executable
  libprimesieve : for the shared runtime lib
  libprimesieve-devel : for the shared buildtime lib
  libprimesieve-static : for the static lib

That would be even closer to Debian, where they use a versioned libprimesieve8
package. Of course, if no other program links with libprimesieve [yet], you may
also drop the primesieve package and include it in the libprimesieve package.
Adding "Provides: primesieve" would extend the namespace with regard to user
searches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #5 from Kim Walisch  ---
Hi Micheal,

Thanks for your feedback. I have fixed the issues you pointed out and pushed a
new version of the spec and SRPM to GitHub:

Spec URL:
https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/master/primesieve.spec
SRPM URL:
https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/master/primesieve-6.4-3.fc27.src.rpm

Note that I have also fixed the following issues pointed out by Jerry James:

> %post -p /sbin/ldconfig
> %postun -p /sbin/ldconfig

> should be replaced with this:
> %ldconfig_scriptlets

1) Done, use ldconfig_scriptlets.

> Also, the spec file at the URL given in the review bug has release
> number 2, but the one inside the SRPM has release number 1. 
> Make sure those match.

2) Done, spec release number now matches SRPM release number.

> ...it is a good idea for the binary and the library to
be in separate packages.

3) I have now put the binary in the primesieve package, the shared
libprimesieve and the header files are in the libprimesieve-devel package and
the static libprimesieve is in the libprimesieve-static package. The naming of
the packages is similar to Debian/Ubuntu where the binary is in primesieve and
the libraries and header in libprimesieve-dev.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #4 from Michael Schwendt  ---
> %check
> make test
> 
> %install

During rpmbuild, %check gets executed _after_ %install, so putting %check below
%install in the spec file is common practice. Sometimes tests are run on
buildroot contents, btw, which explains the order of those sections.


> %package static
> Requires: %{name}-devel = %{version}-%{release}

Make it arch-specific as explained in the base package guidelines:
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %{_includedir}/primesieve/PrimeSieve.hpp

If you list individual files like that (which may be beneficial because the
build would abort for added/removed files), you need to specify also
directories:

  %dir %{_includedir}/primesieve

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
https://fedoraproject.org/wiki/Packaging:UnownedDirectories

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335

Kim Walisch  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #3 from Kim Walisch  ---
Reading through the documentation:

> Use a Release: tag starting with 1 (never 0). Append the Dist tag. Increment 
> the release (by 1) for each update you make. Reset to 1 whenever you change 
> Version:.

OK, I missed this. But I have now increased the release to 2%{?dist}.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #2 from Kim Walisch  ---
Thanks for your feedback. I have fixed the issues you pointed out and pushed a
new version of the spec and SRPM to GitHub:

Spec URL:
https://github.com/kimwalisch/primesieve-rpm/blob/master/primesieve.spec
SRPM URL:
https://github.com/kimwalisch/primesieve-rpm/raw/master/primesieve-6.4-1.fc27.src.rpm

Hers's the link to the successful koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24601545

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #1 from Iwicki Artur  ---
>Group: Development/Libraries
The "Group:" tag is not used in Fedora.

>%clean
%clean should not be used in Fedora.
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>pushd [...]
>popd
rpmbuild resets the working directory at the start of %build, %check and
%install, so these are not needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org