[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833



--- Comment #15 from Robert-André Mauchin  ---
Seems good, package is ok to be approved once you find a sponsor.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833



--- Comment #14 from David Benoit  ---
SPEC:
https://copr-be.cloud.fedoraproject.org/results/dbenoit/racket/fedora-27-x86_64/00742662-racket/racket.spec

SRPM:
https://copr-be.cloud.fedoraproject.org/results/dbenoit/racket/fedora-27-x86_64/00742662-racket/racket-6.12-6.fc27.src.rpm

Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=26440249

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833



--- Comment #13 from Robert-André Mauchin  ---
 - Don't use 

%license %{_datadir}/racket/COPYING*

   use:

%license COPYING.txt COPYING_LESSER.txt COPYING-libscheme.txt

 - You must install the %license in every package combination possible, so also
in %files minimal and %files doc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833



--- Comment #12 from David Benoit  ---
SPEC:
https://copr-be.cloud.fedoraproject.org/results/dbenoit/racket/fedora-27-x86_64/00740429-racket/racket.spec

SRPM:
https://copr-be.cloud.fedoraproject.org/results/dbenoit/racket/fedora-27-x86_64/00740429-racket/racket-6.12-5.fc27.src.rpm

Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=26310121

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833



--- Comment #11 from Robert-André Mauchin  ---
 - This is not needed, as it is now done automatically:

%post
update-mime-database %{_datadir}/mime &> /dev/null || :
update-desktop-database &> /dev/null || :

%postun
update-mime-database %{_datadir}/mime &> /dev/null || :
update-desktop-database &> /dev/null || :

 - The libracket3m.so file should go to the devel package:

   "The versioned shared library files (/usr/lib/libfoo.so.3.2.0 and
/usr/lib/libfoo.so.3) are necessary for users to run programs linked against
libfoo, so they belong in the base package. The other, unversioned, shared
library file (/usr/lib/libfoo.so) is only used to actually link libfoo to code
being compiled, and is not necessary to be installed on a users system. This
means that it belongs in a -devel package."
https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages

%files
%{_bindir}/*
%{_libdir}/racket
%{_libdir}/libracket3m*.so
%{_datadir}/racket
%{_datadir}/applications/*
%{_datadir}/man/*
%{_sysconfdir}/racket/config.rktd

%files devel
%{_includedir}/*
%{_libdir}/libracket3m.so


The versioning of the library is also highly suspicious, it should be in the
format libfoo.so.3.2.0, not libfoo-3.2.0.so. See with upstream the rationale
for doing it this way instead of the typical one.


 - I don't think distributing startup.inc as is is an issue.

 - Since you install a .so in %{_libdir}, you need to run %ldconfig_scriptlets
after %install

 - As per the guidelines: "each architecture listed in ExcludeArch needs to
have a bug filed in bugzilla, describing the reason that the package does not
compile/build/work on that architecture."

See
https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Build_Failures
on how to file these bugs once approved. Also file bugs apstream reporting the
failures, there's already once for Debian/s390x:
https://github.com/racket/racket/issues/2018

 - Remove:

# Prevent empty debuginfo package.
%global debug_package %{nil}

   Instead pass --disable-strip to %configure:

%configure \
--enable-pthread \
--enable-shared \
--enable-libffi \
--disable-strip

 - You must include the license in %files with %license:

%files
%license COPYING.txt COPYING_LESSER.txt COPYING-libscheme.txt

   All those licenses must also be reflected in the License: field of the
header.

License:GPLv3 and LGPLv3 and MIT

 - You need to validate the .desktop files in %install with:

desktop-file-validate %{buildroot}/%{_datadir}/applications/*.desktop

   See
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

 - You must own %{_sysconfdir}/racket

[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/racket

   Add this to do so:

%dir %{_sysconfdir}/racket
%{_sysconfdir}/racket/config.rktd

 - You need to include the Release info in your %changelog entries and you must
increment the Release: field as well for each release you make:

Name:   racket
Version:6.12
Release:3%{?dist}

   And the corresponding %changelog entries:

* Tue Mar 20 2018 David Benoit  6.12-3

* Wed Jan 31 2018 David Benoit  - 6.12-1

* Thu Oct 26 2017 David Benoit  - 6.10-1

* Thu Jul 6 2017 David Benoit  - 6.9-1

* Fri Jan 22 2016 Brandon Thomas  - 6.3-1


 - You should be more specific in which man to include. Don't use:

%{_datadir}/man/*

   instead use:

%{_datadir}/man/man1/*



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING-libscheme.txt is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched 

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833



--- Comment #10 from David Benoit  ---
Just to clarify, the concern with startup.inc is that it requires an existing
copy of Racket to generate.  It is a source file though, not a binary, so I'm
not sure whether the package bootstrapping policy applies.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833



--- Comment #9 from David Benoit  ---
SRPM:
https://copr-be.cloud.fedoraproject.org/results/dbenoit/racket/fedora-27-x86_64/00736626-racket/racket-6.12-1.fc27.src.rpm

SPEC:
https://copr-be.cloud.fedoraproject.org/results/dbenoit/racket/fedora-27-x86_64/00736626-racket/racket.spec

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=26153505

[dbenoit@dbenoit]$ rpmlint racket.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[dbenoit@dbenoit]$ rpmlint racket-6.12-1.fc27.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.



Additionally, it has come to my attention that the following source file is
pre-generated by Racket.  

https://github.com/racket/racket/blob/master/racket/src/racket/src/startup.inc

Racket distributes the sources used to generate this file as part of the main
source distribution.  Instructions on generating the file can be found here:

https://github.com/racket/racket/blob/master/racket/src/expander/README.txt

Please let me know whether this file meets the following packaging guideline,
or whether it needs to be further addressed.

https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Use_of_pregenerated_code

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #8 from Robert-André Mauchin  ---
 No time for review but I think -doc should be noarch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

David Benoit  changed:

   What|Removed |Added

 Whiteboard|NotReady|



--- Comment #7 from David Benoit  ---
Latest build

SRPM:
https://copr-be.cloud.fedoraproject.org/results/dbenoit/racket/fedora-27-x86_64/00730212-racket/racket-6.12-1.fc27.src.rpm

SPEC:
https://copr-be.cloud.fedoraproject.org/results/dbenoit/racket/fedora-27-x86_64/00730212-racket/racket.spec

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25844207


rpmlint:

[dbenoit@dbenoit]$ rpmlint racket.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[dbenoit@dbenoit]$ rpmlint racket-6.12-1.fc27.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


Changelog:
- fix text encoding issue in description section
- remove doc-open-url scriptlets
- add scriptlet to fix paths in html docs
- add patch2 to backport rpaths fix in compiled .zo files
- add patch3 to backport rpaths fix in web-server-lib
- add patch4 to configure doc open url dynamically at runtime
- remove override of __arch_install_post

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833



--- Comment #6 from David Benoit  ---
It seems FE-DEADREVIEW was auto-blocked when the old bug was marked as a
duplicate of this.  I have removed the block since we are still actively
working on this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

David Benoit  changed:

   What|Removed |Added

 Blocks|201449 (FE-DEADREVIEW)  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

Damian Wrobel  changed:

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|DUPLICATE   |---
   Keywords||Reopened



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

Damian Wrobel  changed:

   What|Removed |Added

 Blocks||201449 (FE-DEADREVIEW)
 CC||bthoma...@gmail.com



--- Comment #5 from Damian Wrobel  ---
*** Bug 1301219 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

Damian Wrobel  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||dwro...@ertelnet.rybnik.pl
 Resolution|--- |DUPLICATE
Last Closed||2018-02-12 08:25:34



--- Comment #4 from Damian Wrobel  ---


*** This bug has been marked as a duplicate of bug 1301219 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

David Benoit  changed:

   What|Removed |Added

 Whiteboard||NotReady



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833



--- Comment #3 from David Benoit  ---
Here is the rpmlint output of the updated package:

[dbenoit@dbenoit]$ rpmlint racket-6.12-1.fc27.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[dbenoit@dbenoit]$ rpmlint racket.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833



--- Comment #2 from David Benoit  ---
Thanks for the feedback!  I have addressed those items, and here are the
updated components:

SRPM:
https://copr-be.cloud.fedoraproject.org/results/dbenoit/racket/fedora-27-x86_64/00708107-racket/racket-6.12-1.fc27.src.rpm

SPEC:
https://copr-be.cloud.fedoraproject.org/results/dbenoit/racket/fedora-27-x86_64/00708107-racket/racket.spec

Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24633595

%changelog
* Thu Feb 1 2018 David Benoit  - 6.12
- Fix duplication of object files
- Add version to racket-devel requirements
- Remove base package as a dependency of racket-doc
- Remove Groups tag

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #1 from Iwicki Artur  ---
>Group: Development/Languages
The "Group:" tag is not used in Fedora.
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>%package devel
>Requires: racket
This should be an arch-specific, versioned dependency. Otherwise racket-devel
can be installed alongside any version of racket. Use "racket%{?_isa} =
%{version}-%{release}".
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

>%package doc
>Requires: racket
Documentation packages should not depend on the main package.
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

>%files
>%{_libdir}/lib*-*.so
>[...]
>%files devel
>%{_libdir}/*.so
Won't this cause the *.so files to be included in both the main package and the
-devel subpackage? Duplication should be avoided when possible.
https://fedoraproject.org/wiki/Packaging:Guidelines#Duplicate_Files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

David Benoit  changed:

   What|Removed |Added

Version|27  |rawhide



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

David Benoit  changed:

   What|Removed |Added

Version|rawhide |27
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org