[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-16 12:48:10 --- Comment #12 from Fedora Update System --- podman-0.2-3.git3d0100b.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- podman-0.2-2.git3d0100b.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-23fa359f4c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 --- Comment #10 from Fedora Update System --- podman-0.2-2.git3d0100b.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-23fa359f4c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- podman-0.2-1.git3d0100b.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-803745b92f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 --- Comment #8 from Fedora Update System --- podman-0.2-1.git3d0100b.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-803745b92f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- podman-0-0.3.git367213a.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-665045691d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 --- Comment #6 from Fedora Update System --- podman-0-0.3.git367213a.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-665045691d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 --- Comment #5 from Daniel Walsh --- Can we add me as a maintainer of this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/podman. You may commit to the branch "f27" in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 --- Comment #3 from Lokesh Mandvekar --- Thanks for the review and approval. I merged your PR, the link should be the same as the original posted above. RE: manpage macro, it's probably because the '.' character appears first on a newline followed by the word "You" in the mardown file. That will be taken care of once fixed upstream. Right now there's no ExcludeArch but ExclusiveArch, so I think we should be fine. RE: %gobuild, that's needed for debuginfo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 Frantisek Kluknavsky changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 --- Comment #2 from Frantisek Kluknavsky --- "MUST:rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review." $ rpmlint ./podman-* podman.src: W: spelling-error %description -l en_US libpod -> lib pod, lib-pod, libido podman.src: E: description-line-too-long C libpod provides a library for applications looking to use the Container Pod concept popularized by Kubernetes. podman.x86_64: W: spelling-error %description -l en_US libpod -> lib pod, lib-pod, libido podman.x86_64: E: description-line-too-long C libpod provides a library for applications looking to use the Container Pod concept popularized by Kubernetes. podman.x86_64: W: only-non-binary-in-usr-lib podman.x86_64: W: manual-page-warning /usr/share/man/man1/podman-run.1.gz 846: warning: macro `You' not defined podman-debugsource.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 2 errors, 5 warnings. Spelling error is obviously a false positive. only-non-binary-in-usr-lib is a known bug. Too long description should be fixed. I created a pull request. I am not aware if every subpackage must have some documentation, it does not make much sense here. Manual page is readable, the warning should probably be investigated anyway. "If a Fedora package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch needs to have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number should then be placed in a comment, next to the corresponding ExcludeArch line. New packages will not have bugzilla entries during the review process, so they should put this description in the comment until the package is approved, then file the bugzilla entry, and replace the long explanation with the bug number." The custom definition of %gobuild macro seems a buggy remnant of developing the spec, but in Fedora the spec does not use this definition, it should not be a problem. Overall, I can not find any serious blockers. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 --- Comment #1 from Lokesh Mandvekar --- raw format probably preferable for fedora-review tool. Spec URL: https://pagure.io/podman/raw/master/f/podman.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images
https://bugzilla.redhat.com/show_bug.cgi?id=1541554 Lokesh Mandvekar changed: What|Removed |Added Status|NEW |ASSIGNED CC||bba...@redhat.com, ||dwa...@redhat.com Assignee|nob...@fedoraproject.org|fkluk...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
