[Bug 1545349] Review Request: libplacebo - Reusable library for GPU-accelerated video/ image rendering primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545349

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-19 14:20:21



--- Comment #6 from Nicolas Chauvet (kwizart)  ---
Thx for the import and review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545349] Review Request: libplacebo - Reusable library for GPU-accelerated video/ image rendering primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545349



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libplacebo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545349] Review Request: libplacebo - Reusable library for GPU-accelerated video/ image rendering primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545349



--- Comment #4 from Nicolas Chauvet (kwizart)  ---
(In reply to Iwicki Artur from comment #2)
> >**libplacebo** is essentially the core rendering algorithms and ideas of 
> >[mpv](https://mpv.io)
> There's markdown in the %description.
I will fix before import. Thx for the notice

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545349] Review Request: libplacebo - Reusable library for GPU-accelerated video/ image rendering primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545349

leigh scott  changed:

   What|Removed |Added

 CC||leigh123li...@googlemail.co
   ||m
   Assignee|nob...@fedoraproject.org|leigh123li...@googlemail.co
   ||m
  Flags||fedora-review+



--- Comment #3 from leigh scott  ---
Approved

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Header files in -devel subpackage, if present.
  Note: libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/3rdparty/siphash.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/bstr/bstr.h libplacebo-
  debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/bstr/ctype.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/common.h libplacebo-
  debugsource : /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/context.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/gpu.h libplacebo-
  debugsource :
 
/usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/include/libplacebo/colorspace.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/include/libplacebo/common.h
  libplacebo-debugsource :
 
/usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/include/libplacebo/context.h
  libplacebo-debugsource :
 
/usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/include/libplacebo/dispatch.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/include/libplacebo/dither.h
  libplacebo-debugsource :
 
/usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/include/libplacebo/filters.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/include/libplacebo/gpu.h
  libplacebo-debugsource :
 
/usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/include/libplacebo/renderer.h
  libplacebo-debugsource :
 
/usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/include/libplacebo/shaders.h
  libplacebo-debugsource :
 
/usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/include/libplacebo/shaders/colorspace.h
  libplacebo-debugsource :
 
/usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/include/libplacebo/shaders/sampling.h
  libplacebo-debugsource :
 
/usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/include/libplacebo/swapchain.h
  libplacebo-debugsource :
 
/usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/include/libplacebo/utils/upload.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/include/libplacebo/vulkan.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/shaders.h libplacebo-
  debugsource : /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/spirv.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/swapchain.h libplacebo-
  debugsource : /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/ta/ta.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/ta/talloc.h libplacebo-
  debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/vulkan/command.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/vulkan/common.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/vulkan/formats.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/vulkan/gpu.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/vulkan/malloc.h
  libplacebo-debugsource :
  /usr/src/debug/libplacebo-0.4.0-1.fc28.x86_64/src/vulkan/utils.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in libplacebo
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries


= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "ISC", "LGPL (v2.1 or later)", "GPL (v2)", "Unknown or
 generated", "*No copyright* LGPL (v2.1 or later)". 26 files have
 unknown license. Detailed output of licensecheck 

[Bug 1545349] Review Request: libplacebo - Reusable library for GPU-accelerated video/ image rendering primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545349

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #2 from Iwicki Artur  ---
>**libplacebo** is essentially the core rendering algorithms and ideas of 
>[mpv](https://mpv.io)
There's markdown in the %description.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545349] Review Request: libplacebo - Reusable library for GPU-accelerated video/ image rendering primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545349



--- Comment #1 from Nicolas Chauvet (kwizart)  ---
koji scratch build on f28:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25048142

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org