[Bug 1548173] Review Request: yubikey-piv-manager - Tool for configuring your PIV-enabled YubiKey

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548173

Orion Poplawski  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||yubikey-piv-manager-1.4.2-2
   ||.fc29
 Resolution|--- |NEXTRELEASE
Last Closed||2018-02-28 12:22:24



--- Comment #5 from Orion Poplawski  ---
Checked in and built.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548173] Review Request: yubikey-piv-manager - Tool for configuring your PIV-enabled YubiKey

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548173



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/yubikey-piv-manager

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548173] Review Request: yubikey-piv-manager - Tool for configuring your PIV-enabled YubiKey

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548173

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548173] Review Request: yubikey-piv-manager - Tool for configuring your PIV-enabled YubiKey

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548173



--- Comment #2 from Orion Poplawski  ---
Thanks for the review

* Tue Feb 27 2018 Orion Poplawski  - 1.4.2-2
- Fix license field
- Install man page and documentation
- Add requires yubico-piv-tool

Spec URL: https://www.cora.nwra.com/~orion/fedora/yubikey-piv-manager.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/yubikey-piv-manager-1.4.2-2.fc29.src.rpm

Filed https://github.com/Yubico/yubikey-piv-manager/issues/35 upstream about
license differences.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548173] Review Request: yubikey-piv-manager - Tool for configuring your PIV-enabled YubiKey

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548173

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
 - License:BSD

   COPYING is GPLv3+ and licensecheck has both GPLv3+ and BSD:

BSD (2 clause)
--
yubikey-piv-manager-1.4.2/pivman/yubicommon/__init__.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/ctypes/__init__.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/__init__.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/setup/__init__.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/setup/exe.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/setup/qt.py

BSD (3 clause)
--
yubikey-piv-manager-1.4.2/pivman/yubicommon/ctypes/libloader.py

GPL (v3 or later)
-
yubikey-piv-manager-1.4.2/man/pivman.1
yubikey-piv-manager-1.4.2/pivman/__init__.py
yubikey-piv-manager-1.4.2/pivman/__main__.py
yubikey-piv-manager-1.4.2/pivman/controller.py
yubikey-piv-manager-1.4.2/pivman/libykpiv.py
yubikey-piv-manager-1.4.2/pivman/messages.py
yubikey-piv-manager-1.4.2/pivman/piv.py
yubikey-piv-manager-1.4.2/pivman/piv_cmd.py
yubikey-piv-manager-1.4.2/pivman/storage.py
yubikey-piv-manager-1.4.2/pivman/utils.py
yubikey-piv-manager-1.4.2/pivman/view/__init__.py
yubikey-piv-manager-1.4.2/pivman/view/generate_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/init_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/main.py
yubikey-piv-manager-1.4.2/pivman/view/manage.py
yubikey-piv-manager-1.4.2/pivman/view/set_key_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/set_pin_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/settings_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/usage_policy_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/utils.py
yubikey-piv-manager-1.4.2/pivman/watcher.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/classes.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/osx.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/settings.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/utils.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/worker.py
yubikey-piv-manager-1.4.2/setup.py

   Fix the license field and add a comment explaining the license breakdown.


 - Install the provided man file:

mkdir -p %{buildroot}%{_mandir}/man1
install -p -m 0644 man/pivman.1 %{buildroot}%{_mandir}/man1/pivman.1

   And:

%files
%{_bindir}/pivman
%{_mandir}/man1/pivman.1.*

 - Install the documentation:

%files -n python%{python3_pkgversion}-%{name}
%{python3_sitelib}/*
%license COPYING
%doc NEWS doc/



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "BSD (2 clause)", "GPL (v3 or later)",
 "Unknown or generated". 31 files have unknown license. Detailed output
 of licensecheck in /home/bob/packaging/review/yubikey-piv-manager
 /review-yubikey-piv-manager/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run