[Bug 1548762] Review Request: imgp - Multi-core batch image resizer and rotator
https://bugzilla.redhat.com/show_bug.cgi?id=1548762 --- Comment #11 from Fedora Update System --- imgp-2.5-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1548762] Review Request: imgp - Multi-core batch image resizer and rotator
https://bugzilla.redhat.com/show_bug.cgi?id=1548762 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-03-29 12:19:47 --- Comment #10 from Fedora Update System --- imgp-2.5-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1548762] Review Request: imgp - Multi-core batch image resizer and rotator
https://bugzilla.redhat.com/show_bug.cgi?id=1548762 --- Comment #9 from Fedora Update System --- imgp-2.5-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-7dd2ddec29 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1548762] Review Request: imgp - Multi-core batch image resizer and rotator
https://bugzilla.redhat.com/show_bug.cgi?id=1548762 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- imgp-2.5-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-6b9e5c485e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1548762] Review Request: imgp - Multi-core batch image resizer and rotator
https://bugzilla.redhat.com/show_bug.cgi?id=1548762 --- Comment #7 from Fedora Update System --- imgp-2.5-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-7dd2ddec29 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1548762] Review Request: imgp - Multi-core batch image resizer and rotator
https://bugzilla.redhat.com/show_bug.cgi?id=1548762 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1548762] Review Request: imgp - Multi-core batch image resizer and rotator
https://bugzilla.redhat.com/show_bug.cgi?id=1548762 --- Comment #6 from Fedora Update System --- imgp-2.5-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6b9e5c485e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1548762] Review Request: imgp - Multi-core batch image resizer and rotator
https://bugzilla.redhat.com/show_bug.cgi?id=1548762 --- Comment #5 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/imgp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1548762] Review Request: imgp - Multi-core batch image resizer and rotator
https://bugzilla.redhat.com/show_bug.cgi?id=1548762 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Assignee|nob...@fedoraproject.org|josdek...@gmail.com --- Comment #4 from Robert-André Mauchin --- It was an advice from another review, this macro is superfluous, it doesn't bring anything to use it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1548762] Review Request: imgp - Multi-core batch image resizer and rotator
https://bugzilla.redhat.com/show_bug.cgi?id=1548762 Jos de Kloe changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Jos de Kloe --- Thanks. I am happy with this version, so this review is approved. By the way, just curious. Why did you change the invocation of the install command to not use the macro anymore? Was there a need to do this? Best regards, Jos -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1548762] Review Request: imgp - Multi-core batch image resizer and rotator
https://bugzilla.redhat.com/show_bug.cgi?id=1548762 --- Comment #2 from Robert-André Mauchin --- Added the missing Requires: Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/57c1623/imgp.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/jarun/fedora-rawhide-x86_64/00720901-imgp/imgp-2.5-1.fc28.src.rpm Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1548762] Review Request: imgp - Multi-core batch image resizer and rotator
https://bugzilla.redhat.com/show_bug.cgi?id=1548762
--- Comment #1 from Jos de Kloe ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: make
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- the above remark generated by the fedora-review tool is correct,
but I think it does not hurt to have an explicit Requires for make
- I think a Requires for python3-pillow should be added
apart from that all seems fine to me.
It is not in the generated Requires list at the bottom.
-the rpmlint tool complains about spelling errors, but I do not think
these are actual problems.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v3 or later)", "Unknown or generated". 10 files have
unknown license. Detailed output of licensecheck in
/home/user_to_make_rpms/reviews/1548762-imgp/licensecheck.txt
[-]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/fish,
/usr/share/zsh, /usr/share/fish/vendor_functions.d
==>this package provides autocompletion for bash, fish or zsh
but having any of these installed is optional and is not needed for
the functioning of this package. Therefore the package should not,
and does not own the directories /usr/share/zsh,
/usr/share/zsh/site-functions and this seems correct to me.
[-]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/fish/vendor_functions.d(fish, ripgrep, exa), /usr/share/zsh
/site-functions(mercurial, systemd, pulseaudio, curl)
==>see above remark
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
==>should it require python3-pillow?
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
==>see above requires remark
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Packag
[Bug 1548762] Review Request: imgp - Multi-core batch image resizer and rotator
https://bugzilla.redhat.com/show_bug.cgi?id=1548762 Jos de Kloe changed: What|Removed |Added Status|NEW |ASSIGNED CC||josdek...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
