[Bug 1549011] Review Request: i3blocks - highly flexible status line for the i3 window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1549011 Bob Hepple changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2021-03-15 02:48:32 --- Comment #10 from Bob Hepple --- *** This bug has been marked as a duplicate of bug 1938637 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1549011] Review Request: i3blocks - highly flexible status line for the i3 window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1549011 --- Comment #9 from Robert-André Mauchin 🐧 --- (In reply to Bob Hepple from comment #8) > I use i3blocks and would like to see this finalized. > > Can I help this along in some way? I have reviewer credentials. It seems the reporter has not answered for a while, if you want to maintain it, you would need to create a new review request and mark this one as Duplicate. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1549011] Review Request: i3blocks - highly flexible status line for the i3 window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1549011 Bob Hepple changed: What|Removed |Added CC||bob.hep...@gmail.com --- Comment #8 from Bob Hepple --- I use i3blocks and would like to see this finalized. Can I help this along in some way? I have reviewer credentials. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1549011] Review Request: i3blocks - highly flexible status line for the i3 window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1549011 François Cami changed: What|Removed |Added CC||f...@fcami.net, ||i...@redhat.com Flags||needinfo?(i...@redhat.com) --- Comment #5 from François Cami --- Alice, Could you please fix the SPEC with Robert-André's comments? Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1549011] Review Request: i3blocks - highly flexible status line for the i3 window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1549011
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #4 from Robert-André Mauchin ---
%build
%make_build CFLAGS="%{optflags} -Iinclude" LDFLAGS="%{__global_ldflags}"
PREFIX="%{_prefix}"
You can now use
%build
%set_build_flags
%make_build
- Use a glob instead of .gz for the man page as the compression might change
in the future:
%{_mandir}/man1/%{name}.1.*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1549011] Review Request: i3blocks - highly flexible status line for the i3 window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1549011 --- Comment #3 from William Moreno --- Fedora review run fine with this package. will upload results soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549011] Review Request: i3blocks - highly flexible status line for the i3 window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1549011 William Moreno changed: What|Removed |Added CC||williamjmore...@gmail.com Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549011] Review Request: i3blocks - highly flexible status line for the i3 window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1549011 --- Comment #2 from Alice Rum --- Robert-André, thank you very much for the review! I fixed the issues as pointed out. new spec: https://bitbucket.org/wwyvie/i3blocks/raw/48cee6fab56eb692f92da7b90f34d6d9e12cfae7/i3blocks.spec new srpm: https://bitbucket.org/wwyvie/i3blocks/raw/48cee6fab56eb692f92da7b90f34d6d9e12cfae7/i3blocks-1.4-1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549011] Review Request: i3blocks - highly flexible status line for the i3 window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1549011
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
Blocks||177841 (FE-NEEDSPONSOR)
--- Comment #1 from Robert-André Mauchin ---
- Please link to the RAW SPEC in the future like:
https://bitbucket.org/wwyvie/i3blocks/raw/c5e0a1e2da7d2d102c68718b7afb4da5189a1a1c/i3blocks.spec
it allows fedora-review to fetch it directly from the bug report.
- PREFIX="/usr"
Use the macro %{_prefix}:
PREFIX="%{_prefix}"
- Not an error but the %description is usually put before the %prep part.
- [!]: %build honors applicable compiler flags or justifies otherwise.
You need to make sure that the build use Fedora CFLAGS and LDFLAGS. Usually it
is done with the %configure or %cmake macro but since they are no configure
step, pass the flags directly to make:
%make_build CFLAGS="%{optflags} -Iinclude" LDFLAGS="%{?__global_ldflags}"
PREFIX="%{_prefix}"
(no need for debug, the debug flags are already set by Fedora flags).
- [!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/libexec/i3blocks
You must own this directory, simply remove the * in %files:
%{_libexecdir}/i3blocks
- You must install the license file in %install with %license, and you should
include the *.md files as doc:
%files
%doc CHANGELOG.md README.md
%license COPYING
I can't sponsor you, I suggest introducing yourself to the -devel mailing list,
and do informalreview to show that you understand the guidelines.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* GPL (v3 or later)", "GPL (v3 or later)",
"Unknown or generated". 7 files have unknown license. Detailed output
of licensecheck in /home/bob/packaging/review/i3blocks/review-
i3blocks/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/libexec/i3blocks
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/libexec/i3blocks
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only w
