[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685

Fabian Affolter  changed:

   What|Removed |Added

 Status|POST|CLOSED
 CC||m...@fabian-affolter.ch
 Resolution|--- |RAWHIDE
Last Closed||2020-05-19 10:39:35




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685
Bug 1550685 depends on bug 1552883, which changed state.

Bug 1552883 Summary: Review Request: python-jinja2-time - Jinja2 Extension for 
Dates and Times
https://bugzilla.redhat.com/show_bug.cgi?id=1552883

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685
Bug 1550685 depends on bug 1552881, which changed state.

Bug 1552881 Summary: Review Request: python-poyo - A lightweight YAML Parser 
for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1552881

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685



--- Comment #9 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-cookiecutter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #8 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "*No copyright* Apache (v2.0) BSD
 (unspecified)", "Unknown or generated". 204 files have unknown
 license. Detailed output of licensecheck in /home/bob/packaging/review
 /python-cookiecutter/review-python-cookiecutter/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: Uses parallel make %{?_smp_mflags} macro.
[-]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-cookiecutter , python3-cookiecutter
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: 

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685



--- Comment #7 from Brett Lentz  ---
All dependencies are now packaged. The RPM builds, complete with docs and
tests.

SPEC & SRPM URLs from Comment #1 are updated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685

Brett Lentz  changed:

   What|Removed |Added

 Depends On||1552883




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1552883
[Bug 1552883] Review Request: python-jinja2-time - Jinja2 Extension for
Dates and Times
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685

Brett Lentz  changed:

   What|Removed |Added

 Depends On||1552881




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1552881
[Bug 1552881] Review Request: python-poyo - A lightweight YAML Parser for
Python
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685



--- Comment #6 from Brett Lentz  ---
You're right. After further investigation, these are runtime requires. I'll
work on packaging those dependencies then I'll come back to this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685



--- Comment #5 from Robert-André Mauchin  ---
It seems they are required for the library to work correctly? I mean as Runtime
Requires.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685



--- Comment #4 from Brett Lentz  ---
Thanks for the pointer. :)

It looks like poyo and jinja2-time are not packaged. Everything else listed in
setup.py appears to already be packaged.

So, same question - will that block this review if this package does not
include docs and tests?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685



--- Comment #3 from Robert-André Mauchin  ---
python-click is packaged, you've got the list of Requires in the setup.py:

requirements = [
'future>=0.15.2',
'binaryornot>=0.2.0',
'jinja2>=2.7',
'click>=5.0',
'whichcraft>=0.4.0',
'poyo>=0.1.0',
'jinja2-time>=0.1.0',
'requests>=2.18.0',
]

Also there are test to be run with:

pytest<3.3.0
pytest-cov
pytest-mock==1.1
pytest-catchlog
freezegun

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685



--- Comment #2 from Brett Lentz  ---
I've added the python-provides. Spec & SRPM URLs from comment #1 are updated.

However, building the docs requires additional sphinx contrib modules that
aren't currently in fedora. Let me know if that blocks this review until those
modules are packaged.

Here's the error output:

+ make docs
+ docs
Creating file docs/cookiecutter.rst.
Creating file docs/modules.rst.
make[1]: Entering directory '/builddir/build/BUILD/cookiecutter-1.6.0/docs'
rm -rf _build/*
make[1]: Leaving directory '/builddir/build/BUILD/cookiecutter-1.6.0/docs'
make[1]: Entering directory '/builddir/build/BUILD/cookiecutter-1.6.0/docs'
sphinx-build -b html -d _build/doctrees   . _build/html
Running Sphinx v1.6.6
making output directory...

Extension error:
Could not import extension docs.ccext (exception: No module named click)
make[1]: *** [Makefile:53: html] Error 1
make[1]: Leaving directory '/builddir/build/BUILD/cookiecutter-1.6.0/docs'
make: *** [Makefile:67: docs] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.aTHDN6 (%build)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - Same you didn't include the Python provide

%package -n python2-%{pkgname}
Summary: %{summary}
%{?python_provide:%python_provide python2-%{pkgname}}
%description -n python2-%{pkgname}
A command-line utility that creates projects from cookiecutters (project
templates), e.g. creating a Python package project from a Python package
project template.

%if %{with python3}
%package -n python3-%{pkgname}
Summary: %{summary}
%{?python_provide:%python_provide python3-%{pkgname}}
%description -n python3-%{pkgname}
A command-line utility that creates projects from cookiecutters (project
templates), e.g. creating a Python package project from a Python package
project template.
%endif # with python3

 - Also you must build the docs with Sphinx. Add a BR for python2-sphinx and
run:

make docs

  Then include the resulting html directory with %doc instead of %doc docs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org