[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022

Mattia Verga  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2021-07-10 11:03:24



--- Comment #13 from Mattia Verga  ---
Package is available in repos


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022



--- Comment #12 from Stefan Koch  ---
Because of a rpmgrill.manifest error I have moved the usbauth-npriv binary from
bindir to libexecdir:
"/usr/bin/usbauth-npriv", "Owned by group 'usbauth'; files in /usr/bin
must be group 'root'", "subpackage" : "usbauth-notifier"

The last build is at:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-65ec840e4c

There remain two rpmgrill.setxid errors, but I seems that there is no whitelist
within fedora.
"File /usr/libexec/usbauth-npriv is setuid root but is not on the
setxid whitelist.", "subpackage" : "usbauth-notifier"
"File /usr/libexec/usbauth-notifier/usbauth-notifier is setgid
usbauth but is not on the setxid whitelist.", "subpackage" : "usbauth-notifier"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022



--- Comment #11 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/usbauth-notifier

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Robert-André Mauchin  ---
Refreshing flag

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |
  Flags|fedora-review+  |fedora-review?




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022



--- Comment #9 from Stefan Koch  ---
Thank you for the good example. The build 895957 does not use hardcoded paths
anymore. Have you found one?
Commit:
https://github.com/kochstefan/usbauth-all/commit/76ee5774b0d8f1d1281720dba01db421a86f8f83

It uses within Makefile.am (as example):
usbauth_npriv_CFLAGS = -include config.h -DSBINDIR=\""$(sbindir)"\"
-DLIBEXECDIR=\""$(libexecdir)"\"

and .c source:
#define NOTIFIER_PATH LIBEXECDIR "/usbauth-notifier/usbauth-notifier"

This is described here:
"A corollary is that you should not use these variables except in makefiles.
For instance, instead of trying to evaluate datadir in configure and
hard-coding it in makefiles using e.g., ‘AC_DEFINE_UNQUOTED([DATADIR],
["$datadir"], [Data directory.])’, you should add -DDATADIR='$(datadir)' to
your makefile's definition of CPPFLAGS (AM_CPPFLAGS if you are also using
Automake)."
Soruce:
https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Installation-Directory-Variables.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #8 from Robert-André Mauchin  ---
I still think you shouldn't hardcode the path in your source code, what if one
ser builds it and installs it in /usr/local? Nothing works anymore.
Take a look at configmake.h and how it is used in Bison:
https://github.com/lcytxw/bison-3.0.4/blob/master/Makefile#L5402


Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022



--- Comment #7 from Stefan Koch  ---
The referenced package guidelines say:
"The Filesystem Hierarchy Standard does not include any provision for
libexecdir, but Fedora packages MAY store appropriate files there. Libexecdir
(aka, /usr/libexec on Fedora systems) should only be used as the directory for
executable programs that are designed primarily to be run by other programs
rather than by users."

So I have moved the binary from /usr/lib/usbauth-notifier/usbauth-notifier to
/usr/libexec/usbauth-notifier/usbauth-notifier, now. After this change,
depending files use paths using the libexec autoconf/automake variables.
usbauth-notifier is executed by using xdg autostart.

There is a new build at
https://copr.fedorainfracloud.org/coprs/kochstefan/usbauth-all/build/895957

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022



--- Comment #6 from Robert-André Mauchin  ---
I don't see how the number of files is relevant, if the code contains archful
data you need to put it in %{_libdir}, if the files are noarch, then it goes
into %{_datadir}. If it's a binary, put it in %{_bindir}. Why do you hardcode
/usr/lib into your code? In any case it must respect the FHS:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_filesystem_layout

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022



--- Comment #5 from Stefan Koch  ---
I have added a revised build at:
https://copr.fedorainfracloud.org/coprs/kochstefan/usbauth-all/build/893247

usbauth-notifier is currently installed to
/usr/lib/usbauth-notifier/usbauth-notifier because of
- there are a lot of files in it, even if /usr/lib64 is available on 64 bit
systems ...
- I need an architecture independent and distribution (Fedora, openSUSE,
Debian) independent path (the path is used by binaries and configuration-files,
too)
- /usr/bin not possible because subdirectory usbauth-notifier is needed
(special permissions are set)
- /usr/lib/libexec might be an option, but is not available for openSUSE and
debian
Can you recommend some other path that does not change for architecture and
distribution?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022



--- Comment #4 from Robert-André Mauchin  ---
%files -f %name.lang

%files

 - Squash this into one statement:

 %files -f %name.lang

 - This should not be needed:

%_datadir/locale/*/LC_MESSAGES/usbauth-notifier.mo

It should be included in %name.lang populated by %find_lang %name

 - %_usr → %{_prefix}

 - %verify(not mode) Not useful

 - Why is it installed in %_usr/lib instead of %{_libdir}? This should be fixed
upstream.

 - Add Requires(pre): shadow-utils

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022



--- Comment #3 from Stefan Koch  ---
I have added an new revised build at:
https://copr.fedorainfracloud.org/coprs/kochstefan/usbauth-all/build/849748

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022



--- Comment #2 from Robert-André Mauchin  ---
Sorry to have forgotten you.

 - Please space out your changelog entry, they are difficult to read

 - I would rather have you not mix Suse stuff with Fedora stuff.

 - Install the license file with %license, not %doc

%doc README
%license COPYING

 - Your %changelog entry must contain the release-version:

* Sat Mar 10 2018 stefan.koc...@gmail.com - 1.0-1

 - Add a BR for gcc

 - Split the description to stay below 80 characters

 - Use %autosetup or %setup -q to make the setup quiet:

 - Use %find_lang in %install to install the translations:

%install
%make_install

%find_lang %name

%files -f %name.lang



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Permissions on files are set properly.
  Note: See rpmlint output
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2)", "Unknown or generated". 14 files have unknown
 license. Detailed output of licensecheck in /home/bob/packaging/review
 /usbauth-notifier/review-usbauth-notifier/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /etc/xdg/autostart(filesystem)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022

Stefan Koch  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1554021



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022

Stefan Koch  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1554020



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554022] Review Request: usbauth-notifier - Notifier for USB Firewall to use with desktop environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554022

Stefan Koch  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1553496
 Blocks||177841 (FE-NEEDSPONSOR)



--- Comment #1 from Stefan Koch  ---
A first review was done by Robert-André Mauchin with Bug 1553496 (complete
usbauth suite review request). I have changed the spec files now.
There are new build available on COPR.
See Bugs:
1554020 libusbauth-configparser review request
1554021 usbauth review request
1554022 usbauth-notifier review request
(these bugs will replace bug 1553496)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org