[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766



--- Comment #18 from Fedora Update System  ---
libb2-0.98-1.20171225git60ea749.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766



--- Comment #17 from Fedora Update System  ---
libb2-0.98-1.20171225git60ea749.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766



--- Comment #16 from Fedora Update System  ---
libb2-0.98-1.20171225git60ea749.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-04-02 07:46:31



--- Comment #15 from Fedora Update System  ---
libb2-0.98-1.20171225git60ea749.fc28 has been pushed to the Fedora 28 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766



--- Comment #14 from Fedora Update System  ---
libb2-0.98-1.20171225git60ea749.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-acad70e6b1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766



--- Comment #13 from Fedora Update System  ---
libb2-0.98-1.20171225git60ea749.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-91d2ac0fb5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766



--- Comment #12 from Fedora Update System  ---
libb2-0.98-1.20171225git60ea749.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-aca5d9d9bb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
libb2-0.98-1.20171225git60ea749.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b23deee7f8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766



--- Comment #7 from Fedora Update System  ---
libb2-0.98-1.20171225git60ea749.fc26 has been submitted as an update to Fedora
26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-aca5d9d9bb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766



--- Comment #9 from Fedora Update System  ---
libb2-0.98-1.20171225git60ea749.el7 has been submitted as an update to Fedora
EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-91d2ac0fb5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766



--- Comment #10 from Fedora Update System  ---
libb2-0.98-1.20171225git60ea749.fc27 has been submitted as an update to Fedora
27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-acad70e6b1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766



--- Comment #8 from Fedora Update System  ---
libb2-0.98-1.20171225git60ea749.fc28 has been submitted as an update to Fedora
28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b23deee7f8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libb2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766



--- Comment #5 from Antonio Trande  ---
Thank you Robert.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
 - Remove all the Git things and use this tarball instead:

Source0: https://blake2.net/%{name}-%{version}.tar.gz

 - Split your description line to stay below 80 characters:

libb2.x86_64: E: description-line-too-long C BLAKE2 is a cryptographic hash
function faster than MD5, SHA-1, SHA-2, and SHA-3,

   Package is good otherwise. Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "FSF All Permissive", "GPL (v2 or later)", "GPL (v3 or later)",
 "Unknown or generated". 33 files have unknown license. Detailed output
 of licensecheck in /home/bob/packaging/review/libb2/review-
 libb2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are 

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766



--- Comment #3 from Antonio Trande  ---
I had missed LICENSE file...

Spec URL: https://sagitter.fedorapeople.org/libb2/libb2.spec
SRPM URL:
https://sagitter.fedorapeople.org/libb2/libb2-0.98-1.20171225git60ea749.fc27.src.rpm

Version is changed to 0.98 (as reported during checking); enable-native flag
disabled.

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25811539

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #2 from Elliott Sales de Andrade  ---
It's usually called shortcommit:
https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services

I'm not sure you want to enable native building, as e.g., 32-bit build machines
may support more specific flags (to build) than we allow (to run). A fat binary
*may* be the better choice.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #1 from Iwicki Artur  ---
>Source0: 
>https://github.com/BLAKE2/libb2/archive/%{checkout}.zip#/libb2-%{checkout}.zip
Use "archive/%{checkout}/libb2-%{checkout}.zip" instead. As a minor nitpick - I
think "%{git_commit}" is a more common name for this macro.

>Release: 1.%{date}git%(echo %{checkout} | cut -c-6)%{?dist}
Please define a separate macro for this ("%global checkout_short" or whatever);
it will help readability.

You should also include the LICENSE file (add "%license LICENSE" to %files).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org