[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-04-11 19:02:04



--- Comment #9 from Fedora Update System  ---
git-crypt-0.6.0-3.fc28 has been pushed to the Fedora 28 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
git-crypt-0.6.0-3.fc28 has been pushed to the Fedora 28 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-74979395a9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519



--- Comment #7 from Fedora Update System  ---
git-crypt-0.6.0-3.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-74979395a9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519



--- Comment #6 from Jason Tibbitts  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/git-crypt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
Seems good, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519



--- Comment #4 from Christian Kellner  ---
Thanks a lot. Updated:

https://github.com/gicmo/spec/blob/master/git-crypt/git-crypt.spec
https://koji.fedoraproject.org/koji/taskinfo?taskID=26092757

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #3 from Robert-André Mauchin  ---
 - Add a BR to gcc-c++ See
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B :

BuildRequires:gcc-c++

 - Define ldflags too:

export LDFLAGS="%{__global_ldflags}"

 - Use %make_install to install automatically in the buildroot:

%make_install ENABLE_MAN=yes PREFIX=%{_prefix}

 - Patch the Makefile to use "install -p" instead of "install" to keep
timestamps:

%prep
%autosetup
sed -i "s|^\tinstall -|\t\$(INSTALL) -|" Makefile

 - There's some MIT code too:

MIT/X11 (BSD like)
--
git-crypt-0.6.0/fhstream.cpp
git-crypt-0.6.0/fhstream.hpp
git-crypt-0.6.0/parse_options.cpp
git-crypt-0.6.0/parse_options.hpp

   Add it to the license field and add a commet explaining the license
breakdown.

 - Remove the INSTALL file from %doc:

git-crypt.x86_64: W: install-file-in-docs /usr/share/doc/git-crypt/INSTALL



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "GPL (v3 or later)", "Unknown or
 generated". 17 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/git-crypt/review-git-
 crypt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source 

[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519



--- Comment #2 from Christian Kellner  ---
Thanks for the review comments!

Hopefully addressed all of them.

New spec:
https://github.com/gicmo/spec/blob/master/git-crypt/git-crypt.spec

New scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=26084103

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #1 from Iwicki Artur  ---
>Summary: transparent file encryption in git
This should start with a capital (uppercase) letter.

>URL: https://www.agwa.name/projects/git-crypt/
>Source0: 
>https://www.agwa.name/projects/git-crypt/downloads/%{name}-%{version}.tar.gz
You can replace the beginning of Source0 with %{URL}.

>export DOCBOOK_XSL=/usr/share/sgml/docbook/xsl-stylesheets/manpages/docbook.xsl
I think %{_datadir} would be preferred here, instead of /usr/share.

>make install ENABLE_MAN=yes PREFIX=%{buildroot}/usr
Use %{_prefix} instead of /usr.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org