[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706



--- Comment #14 from Fedora Update System  ---
gravity-beams-and-evaporating-stars-0-5.20180114git3f2aa58.fc27 has been pushed
to the Fedora 27 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706



--- Comment #13 from Fedora Update System  ---
gravity-beams-and-evaporating-stars-0-5.20180114git3f2aa58.fc26 has been pushed
to the Fedora 26 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-05-05 16:32:29



--- Comment #12 from Fedora Update System  ---
gravity-beams-and-evaporating-stars-0-5.20180114git3f2aa58.fc28 has been pushed
to the Fedora 28 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706



--- Comment #11 from Fedora Update System  ---
gravity-beams-and-evaporating-stars-0-5.20180114git3f2aa58.fc26 has been pushed
to the Fedora 26 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-811fef29b4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706



--- Comment #10 from Fedora Update System  ---
gravity-beams-and-evaporating-stars-0-5.20180114git3f2aa58.fc27 has been pushed
to the Fedora 27 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6899423456

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
gravity-beams-and-evaporating-stars-0-5.20180114git3f2aa58.fc28 has been pushed
to the Fedora 28 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d25b249b5f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706



--- Comment #8 from Fedora Update System  ---
gravity-beams-and-evaporating-stars-0-5.20180114git3f2aa58.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-811fef29b4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706



--- Comment #7 from Fedora Update System  ---
gravity-beams-and-evaporating-stars-0-5.20180114git3f2aa58.fc27 has been
submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6899423456

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706



--- Comment #6 from Fedora Update System  ---
gravity-beams-and-evaporating-stars-0-5.20180114git3f2aa58.fc28 has been
submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d25b249b5f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/gravity-beams-and-evaporating-stars

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
Sorry for the delay, I had a tons of mails to get through.

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706



--- Comment #3 from Iwicki Artur  ---
Ah, I've just noticed that the man page has the executable bit set. Fixed that.
SPEC and SRPM remain as above. New koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=26196170

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706



--- Comment #2 from Iwicki Artur  ---
Thanks for the review. All the remarks have been addressed.

spec: https://svgames.pl/fedora/gravity-beams-and-evaporating-stars-0-5.spec
srpm: https://svgames.pl/fedora/gravity-beams-and-evaporating-stars-0-5.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=26196100

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - Why don't you use the %cmake macro instead of:

export CFLAGS="${RPM_OPT_FLAGS}"
export CXXFLAGS="${RPM_OPT_FLAGS}"

cd build
cmake .

 - You made a typo in the %changelog: 0.4.20180114git3f2aa58 →
0-4.20180114git3f2aa58

 - Use either spaces or tabs, not both:

gravity-beams-and-evaporating-stars.src:15: W: mixed-use-of-spaces-and-tabs
(spaces: line 15, tab: line 9)



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 47 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/gravity-beams-and-evaporating-stars/review-
 gravity-beams-and-evaporating-stars/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane 

[Bug 1563706] Review Request: gravity-beams-and-evaporating-stars - a game about hurling asteroids into the sun

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563706

Iwicki Artur  changed:

   What|Removed |Added

 Blocks||1364745 (FE-GAMESIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] Games SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org