[Bug 1578151] Review Request: perl-Mojo-Pg - Mojolicious ♥ PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578151

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-05-26 16:41:14



--- Comment #6 from Fedora Update System  ---
perl-Mojo-Pg-4.08-2.fc28 has been pushed to the Fedora 28 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/IRZ4RGG6G2FLDTP7CGL55QYWIPYYH6UC/

[Bug 1578151] Review Request: perl-Mojo-Pg - Mojolicious ♥ PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578151

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
perl-Mojo-Pg-4.08-2.fc28 has been pushed to the Fedora 28 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2c189241db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1578151] Review Request: perl-Mojo-Pg - Mojolicious ♥ PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578151

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1578151] Review Request: perl-Mojo-Pg - Mojolicious ♥ PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578151



--- Comment #4 from Fedora Update System  ---
perl-Mojo-Pg-4.08-2.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2c189241db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1578151] Review Request: perl-Mojo-Pg - Mojolicious ♥ PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578151



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Mojo-Pg

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1578151] Review Request: perl-Mojo-Pg - Mojolicious ♥ PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578151



--- Comment #2 from Emmanuel Seyman  ---
(In reply to Jitka Plesnikova from comment #1)
> 
> FIX: Please add run-requires
>  perl(SQL::Abstract) >= 1.85 (lib/SQL/Abstract/Pg.pm:2 and
> Makefile.PL:33)

Done.

> TODO: Please consider adding following versioned run-requires
> (Makefile.PL:33)
>  perl(DBD::Pg) >= 3.005001

I've used the version 3.5.1 since that's the format the perl-DBD-Pg package
uses.

>  perl(Mojolicious) >= 7.53

Grumble... Done.

> Please correct all 'FIX' issues and consider fixing 'TODO' items.

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Mojo-Pg/perl-Mojo-Pg.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Mojo-Pg/perl-Mojo-Pg-4.08-2.fc28.src.rpm

> Otherwise the package looks good.
> Approved

Thank you for the review, Jitka.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1578151] Review Request: perl-Mojo-Pg - Mojolicious ♥ PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578151

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Mojo-Pg-4.08-1.fc29.noarch.rpm | sort | uniq -c
  1 perl(Carp)
  1 perl(constant)
  1 perl(DBD::Pg)
  1 perl(DBI)
  1 perl(:MODULE_COMPAT_5.26.2)
  1 perl(Mojo::Base)
  1 perl(Mojo::Collection)
  1 perl(Mojo::File)
  1 perl(Mojo::IOLoop)
  1 perl(Mojo::JSON)
  1 perl(Mojo::Loader)
  1 perl(Mojo::Pg::Database)
  1 perl(Mojo::Pg::Migrations)
  1 perl(Mojo::Pg::PubSub)
  1 perl(Mojo::Pg::Results)
  1 perl(Mojo::Pg::Transaction)
  1 perl(Mojo::Promise)
  1 perl(Mojo::URL)
  1 perl(Mojo::Util)
  1 perl(Scalar::Util)
  1 perl(SQL::Abstract::Pg)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1

FIX: Please add run-requires
 perl(SQL::Abstract) >= 1.85 (lib/SQL/Abstract/Pg.pm:2 and Makefile.PL:33)

TODO: Please consider adding following versioned run-requires (Makefile.PL:33)
 perl(DBD::Pg) >= 3.005001
 perl(Mojolicious) >= 7.53

$ rpm -qp --provides perl-Mojo-Pg-4.08-1.fc29.noarch.rpm | sort | uniq -c
  1 perl(Mojo::Pg) = 4.08
  1 perl-Mojo-Pg = 4.08-1.fc29
  1 perl(Mojo::Pg::Database)
  1 perl(Mojo::Pg::Migrations)
  1 perl(Mojo::Pg::PubSub)
  1 perl(Mojo::Pg::Results)
  1 perl(Mojo::Pg::Transaction)
  1 perl(SQL::Abstract::Pg)
Binary provides are Ok.

$ rpmlint ./perl-Mojo-Pg*
perl-Mojo-Pg.noarch: W: spelling-error Summary(en_US) Mojolicious -> Malicious
perl-Mojo-Pg.src: W: spelling-error Summary(en_US) Mojolicious -> Malicious
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

Please correct all 'FIX' issues and consider fixing 'TODO' items.

Otherwise the package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1578151] Review Request: perl-Mojo-Pg - Mojolicious ♥ PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578151

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1578151] Review Request: perl-Mojo-Pg - Mojolicious ♥ PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578151

Emmanuel Seyman  changed:

   What|Removed |Added

 Blocks||1578152




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1578152
[Bug 1578152] Review Request: perl-Minion - High performance job queue for
the Perl programming language
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org