[Bug 1581318] Review Request: python-requests-credssp - HTTPS CredSSP authentication using the requests library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581318

Mattia Verga  changed:

   What|Removed |Added

 Resolution|--- |CURRENTRELEASE
 Status|POST|CLOSED
Last Closed||2021-08-21 15:38:52



--- Comment #5 from Mattia Verga  ---
Package is available in repos


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1581318] Review Request: python-requests-credssp - HTTPS CredSSP authentication using the requests library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581318

Robert-André Mauchin   changed:

   What|Removed |Added

 CC||m...@fabian-affolter.ch



--- Comment #4 from Robert-André Mauchin   ---
*** Bug 1876601 has been marked as a duplicate of this bug. ***


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1581318] Review Request: python-requests-credssp - HTTPS CredSSP authentication using the requests library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581318

Mohamed El Morabity  changed:

   What|Removed |Added

 CC||pikachu.2...@gmail.com



--- Comment #3 from Mohamed El Morabity  ---
What is the state of this package? Looks like the SRPM was neither built, nor
even imported.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1581318] Review Request: python-requests-credssp - HTTPS CredSSP authentication using the requests library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581318



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-requests-credssp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MNMAEREVZSF6EUQEXITP2RBEORHOFTSQ/

[Bug 1581318] Review Request: python-requests-credssp - HTTPS CredSSP authentication using the requests library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581318

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Remove the dot at the end of summary and split the description to stay below
80 characters per line:

python3-requests-credssp.noarch: E: description-line-too-long C This package
allows for HTTPS CredSSP authentication using the requests library. CredSSP is
a Microsoft authentication that allows your credentials to be delegated to a
server giving you double hop authentication.
python-requests-credssp.src: W: summary-ended-with-dot C This package allows
for HTTPS CredSSP authentication using the requests library.

 - Remove the tab line 13:

python-requests-credssp.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line
11, tab: line 13)


Package approved. Please fix the aforementioned issues before import.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 18 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-requests-credssp/review-python-
 requests-credssp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs 

[Bug 1581318] Review Request: python-requests-credssp - HTTPS CredSSP authentication using the requests library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581318

James Hogarth  changed:

   What|Removed |Added

 Blocks||1572178




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1572178
[Bug 1572178] Please include CredSSP support
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/53NH5WS2J5L2HDQCWRKCA7F4IVBBKNLF/