[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||quantum.anal...@gmail.com
   Fixed In Version||shobhika-fonts-1.04-3.fc29
 Resolution|--- |RAWHIDE
Last Closed||2018-08-28 20:46:40



--- Comment #7 from Elliott Sales de Andrade  ---
Please re-open if necessary, but this appears to have been built.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1583023



--- Comment #6 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/shobhika-fonts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/75YQXHOMEVOMILUQKU2CAAZ5OMPZ5SVN/

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

Parag AN(पराग)  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/HZ7L5XFHAVED2S226R2EKH646NYSKIYJ/

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

Parag AN(पराग)  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/Y6FCPITF6DWFJP6KE5BKGXW32IWJJZAQ/

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

Parag AN(पराग)  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/E7JL2CLMZTVL3CIVEURC5T5QGHRCLKN5/

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1583023



--- Comment #5 from Parag AN(पराग)  ---
Looks good now.

Thanks for this package submission.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/CIHUKKCACLWOVW4BAIOBPQ652NBJHOYA/

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1583023



--- Comment #4 from vishalvvr  ---
SPEC URL :
https://copr-be.cloud.fedoraproject.org/results/vishalvvr/shobhika-fonts/fedora-28-x86_64/00763914-shobhika-fonts/shobhika-fonts.spec

SRPM URL :
https://copr-be.cloud.fedoraproject.org/results/vishalvvr/shobhika-fonts/fedora-28-x86_64/00763914-shobhika-fonts/shobhika-fonts-1.04-3.fc28.src.rpm

Resolved the fontconfig conf file issue mentioned above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/TNUO5IOBIOKX2HKQHBZKOSWYQSYBEXJF/

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1583023



--- Comment #3 from Parag AN(पराग)  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Suggestions:
1) fontconfig conf file is not correct. This package should use fontconfig file
similar to 65-1-lohit-devanagari.conf file.

fix this and submit new SPEC and SRPM.



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 6 files have unknown license. Detailed
 output of licensecheck in /home/parag/1583023-shobhika-
 fonts/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[x]: Rpmlint is run on all installed packages.
 Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

fonts:
[!]: 

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1583023



--- Comment #2 from vishalvvr  ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/vishalvvr/shobhika-fonts/fedora-28-x86_64/00759724-shobhika-fonts/shobhika-fonts.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/vishalvvr/shobhika-fonts/fedora-28-x86_64/00759724-shobhika-fonts/shobhika-fonts-1.04-2.fc28.src.rpm


Resolved the issues mentioned above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7PMBDMKZJH6SRRLNEBF6HUE3HTSH3NQI/

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1583023



--- Comment #1 from Parag AN(पराग)  ---
Suggestions:
1) You have added common_desc macro but not used it anywhere. Also, I don't
think you need it as this is not generating more than one subpackage.

2) You can use %autosetup macro instead of %setup as
%autosetup -n Shobhika-%{version}

3) You can also add Appstream metainfo file for font. So if you have that as
Source2 in spec file then you can add it as
# Add AppStream metadata file
install -Dm 0644 -p %{SOURCE2} \
%{buildroot}%{_datadir}/metainfo/%{fontname}.metainfo.xml

%check
appstream-util validate-relax --nonet \
%{buildroot}%{_datadir}/metainfo/%{fontname}.metainfo.xml

then add this file entry to %_font_pkg macro of main package.

4) When you will update spec file, increase release count as 2 and add related
changelog entry and submit new SPEC and SRPM urls for further review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/SXPX6JAR4VRC4XSJVRBB4M4AQBBIFRK3/

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: ${hyperkitty_url}