[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 Raphael Groner changed: What|Removed |Added Resolution|NEXTRELEASE |NOTABUG --- Comment #28 from Raphael Groner --- (In reply to Georg Sauthoff from comment #27) … > Ok, done: > https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/ > thread/UNPQ7YKHG6NPRQWNVD2EYQDM753OGI3I/ Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 Raphael Groner changed: What|Removed |Added Resolution|NOTABUG |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 Georg Sauthoff changed: What|Removed |Added Resolution|NOTABUG |NEXTRELEASE --- Comment #27 from Georg Sauthoff --- (In reply to Raphael Groner from comment #26) > For the update to 1.14.0: > Please announce new license on devel mailing list. > https://fedoraproject.org/wiki/Licensing:Main#License_Changes Ok, done: https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/thread/UNPQ7YKHG6NPRQWNVD2EYQDM753OGI3I/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 Raphael Groner changed: What|Removed |Added Resolution|ERRATA |NOTABUG --- Comment #26 from Raphael Groner --- For the update to 1.14.0: Please announce new license on devel mailing list. https://fedoraproject.org/wiki/Licensing:Main#License_Changes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #25 from Fedora Update System --- python-asyncssh-1.13.3-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-08-28 20:55:29 --- Comment #24 from Fedora Update System --- python-asyncssh-1.13.3-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #23 from Fedora Update System --- python-asyncssh-1.13.3-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-445825fdc3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #22 from Fedora Update System --- python-asyncssh-1.13.3-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-5b5c69e114 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #21 from Fedora Update System --- python-asyncssh-1.13.3-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-445825fdc3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/4GDRTEPYU2U2JWZ5L74NQ6LNSEPP2FML/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #20 from Fedora Update System --- python-asyncssh-1.13.3-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5b5c69e114 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/WTCX37YDMQVJ2HHLM4CZF5N2H7BLLJMW/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LXPWYVFY2MFTE7VQCMEGAVG7M2IVMBVV/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828
--- Comment #19 from Georg Sauthoff ---
(In reply to Igor Gnatenko from comment #18)
> > %{python3_sitelib}/*
>
> Don't use this.
Ok, I don't have to use it. I just got the idea from the Fedora Packaging
Guidelines for Python (
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file ). Are
the guidelines wrong in this point?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/WAQXJT4Q43GP3LL3ZDLDEVL746PKKBKS/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828
Igor Gnatenko changed:
What|Removed |Added
CC||i.gnatenko.br...@gmail.com
--- Comment #18 from Igor Gnatenko ---
> %{python3_sitelib}/*
Don't use this.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/WXBMNIVPSAIQSXNDRXTULOLD7SFH66JU/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #17 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-asyncssh -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5KBG5UY6UGA3YBTI4HC4ELALM6EIDLZW/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #16 from Georg Sauthoff --- Good catch, I've updated the sed command. Current spec: https://raw.githubusercontent.com/gsauthof/copr-fedora/f6d0f57d11a31817512b12d3a5c68d8d2adb0bea/python-asyncssh/python-asyncssh.spec COPR: https://copr-be.cloud.fedoraproject.org/results/gsauthof/fedora/fedora-rawhide-x86_64/00787078-python-asyncssh/python-asyncssh-1.13.3-1.fc29.src.rpm Btw, my pull-request for rpmlint (syncs the license short names): https://src.fedoraproject.org/rpms/rpmlint/pull-request/5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/EG534IKD5WQYOH3UIPREFCIFSRGZMBMN/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828
Raphael Groner changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #15 from Raphael Groner ---
Sure. I've full trust in the result of comment #6. Sorry for the delay, I had
some hope for a license upgrade requested from upstream.
Just another hint: Replace explicit path for python3 binary in the follwing
line as you also do correctly in %check, the macro is defined within
python3-devel.
- sed -i '1,1s@^#!.*$@#!/usr/bin/python3@' examples/*.py
+ sed -i '1,1s@^#!.*$@#!%{__python3}@' examples/*.py
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/CFJLPY3MLTCMZQE2H7TXT2MQQ3IXQM7W/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #14 from Georg Sauthoff --- (In reply to Raphael Groner from comment #7) > Thanks for this review and the package. I can approve this request on trust > in the result from original reviewer. Do you mind setting the fedora-review flag on this issue? Without that I can't request a repository for this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/BJI2YBR6JXVEZ5A5KGACR5Y3UTATA4W2/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #13 from Georg Sauthoff --- (In reply to Raphael Groner from comment #10) > Well, the authors try to get compatible with GPL. Maybe ask upstream to > upgrade. > https://www.eclipse.org/legal/epl-2.0/faq.php#h.60mjudroo8e5 FWIW, the EPL 2.0 FAQ lists 4 'major' changes. The _optional_ GPL2+ compatibility (through specifying the GPL as a secondary license) is just one of them: https://www.eclipse.org/legal/epl-2.0/faq.php#h.a0eux401qus Thus, the EPL 2.0 (without the secondary license option) is as GPL compatible as EPL 1.0, i.e. it isn't GPL compatible. cf. e.g. https://en.wikipedia.org/wiki/Eclipse_Public_License#Version_2.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/RIIRBSJWAO3VKZVUJJZIJXPMOE2OC7OG/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #12 from Raphael Groner --- License upgrade requested: https://github.com/ronf/asyncssh/issues/161 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/BWVD5HJHAFV7GAKSUHJJUNGAIRTTNGRJ/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #11 from Raphael Groner --- (In reply to Raphael Groner from comment #10) > Well, the authors try to get compatible with GPL. Maybe ask upstream to > upgrade. > https://www.eclipse.org/legal/epl-2.0/faq.php#h.60mjudroo8e5 Further: "You must re-license to EPL-2.0 adding GPL Compatibility as per Exhibit A." - but not always needed for LGPL. https://www.eclipse.org/legal/epl-2.0/faq.php#h.r4jspab0hx2c https://www.eclipse.org/legal/epl-2.0/faq.php#h.hsnsfg4e0htq "a project can use the new version by simply updating the file headers and notices. […] You must gain permission from all copyright holders to re-license the content" https://www.eclipse.org/legal/epl-2.0/faq.php#h.tci84nlsqpgw https://www.eclipse.org/legal/epl-2.0/faq.php#h.cktcxkzh8ks4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MOEHWVC26WEROLI4B4IKFSKFPHXUG3YW/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 Raphael Groner changed: What|Removed |Added Assignee|nob...@fedoraproject.org|projects...@smart.ms -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/DLWFDYPB5ONZTBX4YCDSP6J7LEZPXEKU/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #10 from Raphael Groner --- Well, the authors try to get compatible with GPL. Maybe ask upstream to upgrade. https://www.eclipse.org/legal/epl-2.0/faq.php#h.60mjudroo8e5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/3AZPXUCCDZULICJZA6MADHFA5NPNIPZS/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #9 from Georg Sauthoff --- (In reply to Georg Sauthoff from comment #8) > The asyncssh author explicitly chose the EPL for it's weak copyleft features > (cf. https://groups.google.com/d/msg/asyncssh-users/lS8FlyxSVEo/iDsuUH9or-EJ > ). When the first code was released in 2013, EPL 2.0 simply wasn't > available. EPL 2.0 was just released in August 2018. to correct myself: s/it's/its/ and the EPL 2.0 was released in August 2017. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5DPYGQE7YUS7KQC6GTWK4B4DDPRTDLSO/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #8 from Georg Sauthoff --- The asyncssh author explicitly chose the EPL for it's weak copyleft features (cf. https://groups.google.com/d/msg/asyncssh-users/lS8FlyxSVEo/iDsuUH9or-EJ ). When the first code was released in 2013, EPL 2.0 simply wasn't available. EPL 2.0 was just released in August 2018. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/BRQQES2D5GUX4DYOZX3AOIZAWWI2AAIX/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 Raphael Groner changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? --- Comment #7 from Raphael Groner --- Thanks for this review and the package. I can approve this request on trust in the result from original reviewer. A question: Any idea why upstream explicitly choose EPL 1.0? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/WNKOS5FDNDPJC6DN5KEBGPQW2UBRVMDN/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828
--- Comment #6 from Iñaki Ucar ---
Thanks, Georg. It looks good to me, but I cannot assign this to myself, because
I still need a sponsor. I attach below the revised version of the output of
the fedora-review tool as a reference for another reviewer.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 92160 bytes in 40 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #5 from Georg Sauthoff --- Yes, it makes sense to suggest/recommend the optional packages. I added the optional packages as weak dependencies (one recommends and the rest as suggests). Regarding EPL-1.0 - yes, it's a false positive because the rpmlint config includes this comment: # These are the short names for all of the Fedora approved licenses. # The master list is kept here: http://fedoraproject.org/wiki/Licensing # Last synced with revision "2.36, 18 April 2017" of that page. (https://src.fedoraproject.org/rpms/rpmlint/blob/master/f/rpmlint.config#_43-45 or /usr/share/rpmlint/config) Also, the config even lists 'EPL' (without version qualifier): https://src.fedoraproject.org/rpms/rpmlint/blob/master/f/rpmlint.config#_114 I'll try to submit a pull-request that adds the version qualified EPL tags to the rpmlint package. I added a sed call that fixes the shebang lines. The spec file now uses the srcname macro in more places. AFAICS, the main advantage of the py3_dist macro is that I don't have to change a dependency name (in requires/buildrequires) when the fedora name of such a dependency changes - because the standardized name (usually) doesn't change. Since I don't see this as a big advantage for this package right now, I haven't transformed the requires/buildrequires to py3_dist macro calls. Updated SPEC file: https://raw.githubusercontent.com/gsauthof/copr-fedora/196fafef5f720f7322ae4b44e599d09eadedc83d/python-asyncssh/python-asyncssh.spec New SRPM: https://copr-be.cloud.fedoraproject.org/results/gsauthof/fedora/fedora-rawhide-x86_64/00784369-python-asyncssh/python-asyncssh-1.13.3-1.fc29.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/P6TKSIELKLV4WMCGCVLDPYS65NPZQ4SL/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828
--- Comment #4 from Iñaki Ucar ---
Oh, also:
- You may consider reusing the global srcname, instead of repeating "asyncssh".
- You may consider using %{py3_dist} to list dependencies.
https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/DNQOSS5DXOQF62FLWQE4MUSSOGMCGCC4/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #3 from Iñaki Ucar --- This is an informal review. Some comments: - Shouldn't be the optional packages suggested? - EPL-1.0 is reported as an invalid license by rpmlint, but I'm not sure whether this could be a false positive, because it is listed here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses - Note that all the examples have "/usr/bin/env" in the shebang line. This must be fixed. https://fedoraproject.org/wiki/Packaging:Guidelines#Shebang_lines -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/3DFC6ZHKNF77C5FSBON3FSFWEVDDGV6B/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 Georg Sauthoff changed: What|Removed |Added Flags|needinfo?(fed...@georg.so) | --- Comment #2 from Georg Sauthoff --- Sure, the direct link to the SRPM is: https://copr-be.cloud.fedoraproject.org/results/gsauthof/fedora/fedora-rawhide-x86_64/00782178-python-asyncssh/python-asyncssh-1.13.3-1.fc29.src.rpm And the direct SPEC file URL: https://raw.githubusercontent.com/gsauthof/copr-fedora/d83704e0829d7f6da9b101b946ae6ee6f5cc3b0e/python-asyncssh/python-asyncssh.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2L2VDP3NPHN7I32TI4OZFWXO6S4KEFXZ/
[Bug 1611828] Review Request: python-asyncssh - Asynchronous SSH for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1611828 Iñaki Ucar changed: What|Removed |Added CC||fed...@georg.so, ||i.uca...@gmail.com Flags||needinfo?(fed...@georg.so) --- Comment #1 from Iñaki Ucar --- Could you provide the SRPM, please? Also note that the URL provided for the SPEC is not a direct download. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/6YSMM4A7VNCLQ3CSSXAHSR5GX7XXVXMF/
