[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 Bug 1623220 depends on bug 1623469, which changed state. Bug 1623469 Summary: Review Request: python-click-man - Generate man pages for click based CLI applications https://bugzilla.redhat.com/show_bug.cgi?id=1623469 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 Mattia Verga changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed||2020-06-13 15:45:38 --- Comment #12 from Mattia Verga --- This package was approved and imported in repositories and it was later retired, but this review ticket was never closed. I'm closing it now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 --- Comment #11 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mmdzanata -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 Petr Šabata changed: What|Removed |Added Flags||fedora-review+ --- Comment #10 from Petr Šabata --- Ack. Approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 --- Comment #9 from Stephen Gallagher --- Spec URL: https://sgallagh.fedorapeople.org/packagereview/python-mmdzanata/python-mmdzanata.spec SRPM URL: https://sgallagh.fedorapeople.org/packagereview/python-mmdzanata/python-mmdzanata-0.7-2.fc29.src.rpm COPR Build: https://copr.fedorainfracloud.org/coprs/sgallagh/mmdzanata/package/python-mmdzanata/ I fixed the description. Regarding the binary directory purge, that's future-proof in case for some reason the python2 build ever produces different content from the python3 one. It was put there by pyp2rpm and I don't see a good reason to remove it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220
Petr Šabata changed:
What|Removed |Added
Flags|needinfo?(psab...@redhat.co |
|m) |
--- Comment #8 from Petr Šabata ---
Almost there!
%{description} isn't an expandable macro. If you want to re-use the
description text, define something else and use that. The current result is
you have the literal "%{description}" as your package description.
Also not sure whether you need line 74, doesn't the next step overwrite it?
Though I haven't tried that, just thinking.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220
Stephen Gallagher changed:
What|Removed |Added
Flags||needinfo?(psab...@redhat.co
||m)
--- Comment #7 from Stephen Gallagher ---
Spec URL:
https://sgallagh.fedorapeople.org/packagereview/python-mmdzanata/python-mmdzanata.spec
SRPM URL:
https://sgallagh.fedorapeople.org/packagereview/python-mmdzanata/python-mmdzanata-0.7-1.fc29.src.rpm
COPR Build:
https://copr.fedorainfracloud.org/coprs/sgallagh/mmdzanata/package/python-mmdzanata/
I fixed the runtime dep on setuptools.
Yes, the manpage generation needed the builddeps to function. I'm not sure why
it didn't need requests, but I've added it for future-proofing.
I replaced most of the runtime deps with the
%{?python_enable_dependency_generator}
macro, but left the pygobject one because that can't be present in setup.py (I
don't think) and therefore auto-detected.
I added a python2 subpackage to support pungi in more places.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 --- Comment #6 from Petr Šabata --- * I still see the runtime dep on setuptools. * Build deps on click-man and pygobject are listed twice. * I suppose this method of manpage generation loads the files, so that's why you need all those build deps. Is that right? In that case you should also add python(requests) as a build dep. * I confirm the shebang and copyright changes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 --- Comment #5 from Stephen Gallagher --- Spec URL: https://sgallagh.fedorapeople.org/packagereview/python-mmdzanata/python-mmdzanata.spec SRPM URL: https://sgallagh.fedorapeople.org/packagereview/python-mmdzanata/python-mmdzanata-0.6-2.fc29.src.rpmCopr Build: https://copr.fedorainfracloud.org/coprs/sgallagh/mmdzanata/package/python-mmdzanata/ Previous build failed missing some BuildRequires. This fixes that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 --- Comment #4 from Stephen Gallagher --- Spec URL: https://sgallagh.fedorapeople.org/packagereview/python-mmdzanata/python-mmdzanata.spec SRPM Url: https://sgallagh.fedorapeople.org/packagereview/python-mmdzanata/python-mmdzanata-0.6-1.fc29.src.rpm Copr Build: https://copr.fedorainfracloud.org/coprs/sgallagh/mmdzanata/package/python-mmdzanata/ This review now depends on BZ #1623469 to provide the tool needed to generate the requested manpages. I've dropped the setuptools runtime dep, added python3-gobject-base, fixed the copyright headers, dropped the shebang line and added the manpage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 Stephen Gallagher changed: What|Removed |Added Depends On||1623469 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1623469 [Bug 1623469] Review Request: python-click-man - Generate man pages for click based CLI applications -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 --- Comment #3 from Stephen Gallagher --- (In reply to Petr Šabata from comment #2) > * I don't see the need for that runtime dependency on setuptools. > What's the point? That was added automatically by pyp2rpm; it's probably not needed. > > * Missing runtime dependency on python3-gobject-base or equivalent. Ah, right. Good catch. > > * All files state "Copyright (C) 2017-2018 Stephen Gallagher", yet the > first upstream commit is from a week ago. Oops, copy-paste error. > > * Does cli.py need the shebang line? It does not need one, it's not meant to be directly executable. It's wrapped by console_scripts in setup.py. > > * As an executable, mmdzanata could have a manpage. It probably should, but I haven't written one yet and this isn't a blocker for initial review IMHO. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 --- Comment #2 from Petr Šabata --- * I don't see the need for that runtime dependency on setuptools. What's the point? * Missing runtime dependency on python3-gobject-base or equivalent. * All files state "Copyright (C) 2017-2018 Stephen Gallagher", yet the first upstream commit is from a week ago. * Does cli.py need the shebang line? * As an executable, mmdzanata could have a manpage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 --- Comment #1 from Stephen Gallagher --- Spec URL: https://sgallagh.fedorapeople.org/packagereview/python-mmdzanata/python-mmdzanata.spec SRPM URL: https://sgallagh.fedorapeople.org/packagereview/python-mmdzanata/python-mmdzanata-0.5-1.fc29.src.rpm COPR Build: https://copr.fedorainfracloud.org/coprs/sgallagh/mmdzanata/ This version properly includes the COPYING file referenced in the source header comments. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 Petr Šabata changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
