[Bug 1626733] Review Request: python-nb2plots - Convert between Jupyter notebooks and sphinx docs

2018-09-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1626733

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-09-21 01:31:11



--- Comment #9 from Fedora Update System  ---
python-nb2plots-0.6-2.fc29 has been pushed to the Fedora 29 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1626733] Review Request: python-nb2plots - Convert between Jupyter notebooks and sphinx docs

2018-09-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1626733

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
python-nb2plots-0.6-2.fc29 has been pushed to the Fedora 29 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c8dda0053d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1626733] Review Request: python-nb2plots - Convert between Jupyter notebooks and sphinx docs

2018-09-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1626733

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #7 from Fedora Update System  ---
python-nb2plots-0.6-2.fc29 has been submitted as an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c8dda0053d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1626733] Review Request: python-nb2plots - Convert between Jupyter notebooks and sphinx docs

2018-09-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1626733



--- Comment #6 from Igor Gnatenko  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-nb2plots

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1626733] Review Request: python-nb2plots - Convert between Jupyter notebooks and sphinx docs

2018-09-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1626733

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
Seems ok, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1626733] Review Request: python-nb2plots - Convert between Jupyter notebooks and sphinx docs

2018-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1626733



--- Comment #4 from Jerry James  ---
Thank you for the review!  I obviously rushed that one too much.  I have fixed
all of the problems you identified.  It is true that setup.py does not mention
python 2, and I sincerely hope that the python 2 subpackage is very
short-lived.  In any case, it passes its test suite and appears to otherwise
work correctly with python 2.  New URLs:

Spec URL: https://jjames.fedorapeople.org/python-nb2plots/python-nb2plots.spec
SRPM URL:
https://jjames.fedorapeople.org/python-nb2plots/python-nb2plots-0.6-2.fc30.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1626733] Review Request: python-nb2plots - Convert between Jupyter notebooks and sphinx docs

2018-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1626733



--- Comment #3 from Robert-André Mauchin  ---
The pycache issue seems to be caused by the redefinition of PATH and PYTHONPATH
before %install

export PATH=$PWD/build/scripts-%{python3_version}:$PATH
export PYTHONPATH=$PWD/build/lib

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1626733] Review Request: python-nb2plots - Convert between Jupyter notebooks and sphinx docs

2018-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1626733



--- Comment #2 from Robert-André Mauchin  ---
Also you build the docs but you're not installing it anywhere.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1626733] Review Request: python-nb2plots - Convert between Jupyter notebooks and sphinx docs

2018-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1626733

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #1 from Robert-André Mauchin  ---
 - You must install the LICENSE file with %license in %files

 - Install Changelog with %doc

 - Seems Python 3 files are installed in Python 2 directories:


python2-nb2plots.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python2.7/site-packages/nb2plots/__pycache__/__init__.cpython-37.pyc
expected 62211 (2.7), found 3394 (3.7)
python2-nb2plots.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python2.7/site-packages/nb2plots/__pycache__/_version.cpython-37.pyc
expected 62211 (2.7), found 3394 (3.7)
python2-nb2plots.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python2.7/site-packages/nb2plots/__pycache__/codelinks.cpython-37.pyc
expected 62211 (2.7), found 3394 (3.7)
python2-nb2plots.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python2.7/site-packages/nb2plots/__pycache__/commands.cpython-37.pyc
expected 62211 (2.7), found 3394 (3.7)
python2-nb2plots.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python2.7/site-packages/nb2plots/__pycache__/converters.cpython-37.pyc
expected 62211 (2.7), found 3394 (3.7)
python2-nb2plots.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python2.7/site-packages/nb2plots/__pycache__/doctree2md.cpython-37.pyc
expected 62211 (2.7), found 3394 (3.7)
python2-nb2plots.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python2.7/site-packages/nb2plots/__pycache__/doctree2nb.cpython-37.pyc
expected 62211 (2.7), found 3394 (3.7)
python2-nb2plots.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python2.7/site-packages/nb2plots/__pycache__/doctree2py.cpython-37.pyc
expected 62211 (2.7), found 3394 (3.7)
python2-nb2plots.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python2.7/site-packages/nb2plots/__pycache__/from_notebook.cpython-37.pyc
expected 62211 (2.7), found 3394 (3.7)
python2-nb2plots.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python2.7/site-packages/nb2plots/__pycache__/ipython_shim.cpython-37.pyc
expected 62211 (2.7), found 3394 (3.7)
python2-nb2plots.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python2.7/site-packages/nb2plots/__pycache__/mpl_interactive.cpython-37.pyc
expected 62211 (2.7), found 3394 (3.7)
python2-nb2plots.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python2.7/site-packages/nb2plots/__pycache__/nbplots.cpython-37.pyc
expected 62211 (2.7), found 3394 (3.7)
python2-nb2plots.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python2.7/site-packages/nb2plots/__pycache__/runroles.cpython-37.pyc
expected 62211 (2.7), found 3394 (3.7)
python2-nb2plots.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python2.7/site-packages/nb2plots/__pycache__/sphinx2foos.cpython-37.pyc
expected 62211 (2.7), found 3394 (3.7)

   The setup.py only mention compatibility with Python 3, not Python 2.

 - Remove the shebangs from:

python2-nb2plots.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/nb2plots/from_notebook.py python 
python2-nb2plots.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/nb2plots/from_notebook.py 644 python 

python3-nb2plots.noarch: E: wrong-script-interpreter
/usr/lib/python3.7/site-packages/nb2plots/from_notebook.py python 
python3-nb2plots.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/nb2plots/from_notebook.py 644 python

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1626733] Review Request: python-nb2plots - Convert between Jupyter notebooks and sphinx docs

2018-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1626733

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org