[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 Mattia Verga changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2021-06-26 12:48:13 --- Comment #25 from Mattia Verga --- Package is in repo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 Robert-André Mauchin changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 --- Comment #24 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kdsoap -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 --- Comment #23 from Casper Meijn --- Thank you all for reviewing and sponsoring me! (In reply to Luis Segundo from comment #22) > This was already approved and sponsored, any idea why you have not created > the repository yet? I just now requested the repo, I just had to find some time :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 Luis Segundo changed: What|Removed |Added CC||l...@blackfile.net --- Comment #22 from Luis Segundo --- This was already approved and sponsored, any idea why you have not created the repository yet? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 Luis Bazan changed: What|Removed |Added CC||bazanlui...@gmail.com --- Comment #21 from Luis Bazan --- Congratulations! Welcome aboard! Sponsored! FAS: caspermeijn Regards! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #20 from Robert-André Mauchin --- The package is approved. Now you need to find a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824
--- Comment #19 from Casper Meijn ---
(In reply to Robert-André Mauchin from comment #18)
> - Own theses dirs:
>
> /usr/share/mkspecs/features, /usr/share/mkspecs
>
>Use:
>
> %dir %{datadir}/mkspecs
> %dir %{datadir}/mkspecs/features
Done
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-rawhide-x86_64/00817063-kdsoap/kdsoap.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-rawhide-x86_64/00817063-kdsoap/kdsoap-1.7.0-1.fc30.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824
--- Comment #18 from Robert-André Mauchin ---
- Own theses dirs:
/usr/share/mkspecs/features, /usr/share/mkspecs
Use:
%dir %{datadir}/mkspecs
%dir %{datadir}/mkspecs/features
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 --- Comment #17 from Casper Meijn --- Thanks for your comments (In reply to Robert-André Mauchin from comment #14) > - Split tte doc into a noarch -doc subpackage > I created a separate doc package for the documentation > - Own theses dirs: > > /usr/share/mkspecs/features, /usr/share/mkspecs I don't know how to fix this. Could you give me instructions or point to the documentation? Thanks. > > - Fix the line encodings: > > kdsoap.x86_64: W: wrong-file-end-of-line-encoding > /usr/share/doc/kdsoap/doc/config/doxygen.css I converted these using dos2unix. Spec URL: https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-28-x86_64/00816655-kdsoap/kdsoap.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-28-x86_64/00816655-kdsoap/kdsoap-1.7.0-1.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 --- Comment #16 from Robert-André Mauchin --- Wrong tab sorry. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 --- Comment #15 from Robert-André Mauchin --- If you have trouble rebuilding your SRPM: rpmbuild --define "python3_pkgversion 34" --define "_sourcedir $PWD" --define "_srcrpmdir $PWD" --target epel-7-x86_64 -bs boost-python3.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #14 from Robert-André Mauchin ---
- Split tte doc into a noarch -doc subpackage
- Own theses dirs:
/usr/share/mkspecs/features, /usr/share/mkspecs
- Fix the line encodings:
kdsoap.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/kdsoap/doc/config/doxygen.css
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 2344960 bytes in 293 files.
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GNU Lesser General Public License (v2.1)", "GNU Lesser General
Public License", "Unknown or generated", "GNU General Public License
(v2)", "AGPL", "LGPL (v2 or v3)", "GPL (v2)", "Expat License", "GNU
Lesser General Public License (v2 or later)", "LGPL (v2.1 or v3)",
"*No copyright* BSD 3-clause "New" or "Revised" License". 634 files
have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/kdsoap/review-kdsoap/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/mkspecs/features,
/usr/share/mkspecs
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824
--- Comment #13 from Casper Meijn ---
(In reply to Robert-André Mauchin from comment #12)
> - Not needed:
>
> rm -rf $RPM_BUILD_ROOT
I removed this line
>
> - Not needed anymore:
>
> %post -p /sbin/ldconfig
>
> %postun -p /sbin/ldconfig
I removed these lines
>
>If you plan on packaging for F27 or EPEL7, use %ldconfig_scriptlets
> instead.
>
> - To avoid unintentional soname bump, it is now forbidden to glob the major
> soname vension, be more specific instead:
>
> %{_libdir}/*.so.1*
I added the library name and major version number
>
> - you seem to have forgotten to include the doc:
>
> %files
> %doc doc
I added doc directory to the package, thanks
>
> - Why? These are not doc:
>
> %doc kdsoap.pri kdwsdl2cpp.pri
I primarily added these because upstream does it this way. I haven't used these
myself, but I believe this is needed for including the library in some
applications. What would be an appropriate path for these files?
>
> - Why are the binaries in the devel package?
>
> %{_bindir}/*
The kdwsdl2cpp binary is a converter for translating WSDL files to c++ code,
which can be included in an application and this code uses the kdsoap library.
The binary is only useful during development.
>
> - Be more specific here:
>
> %{_includedir}/*
> %{_libdir}/cmake/
I added the directory names to these.
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-rawhide-x86_64/00813018-kdsoap/kdsoap.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-rawhide-x86_64/00813018-kdsoap/kdsoap-1.7.0-1.fc30.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #12 from Robert-André Mauchin ---
- Not needed:
rm -rf $RPM_BUILD_ROOT
- Not needed anymore:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
If you plan on packaging for F27 or EPEL7, use %ldconfig_scriptlets instead.
- To avoid unintentional soname bump, it is now forbidden to glob the major
soname vension, be more specific instead:
%{_libdir}/*.so.1*
- you seem to have forgotten to include the doc:
%files
%doc doc
- Why? These are not doc:
%doc kdsoap.pri kdwsdl2cpp.pri
- Why are the binaries in the devel package?
%{_bindir}/*
- Be more specific here:
%{_includedir}/*
%{_libdir}/cmake/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 --- Comment #11 from Casper Meijn --- (In reply to Luis Segundo from comment #10) > I understand, if the license does not apply, it can be removed. I removed LICENSE.txt again > please check this last issue > > Issues: > === > - If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %license. > Note: License file license.cpp is not marked as %license > See: > http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text I am not sure what you mean with this. I package LICENSE.GPL.txt and LICENSE.AGPL3-modified.txt, which are the two license under which we want use the code. The other license files are for a commercial license or LGPL. Spec URL: https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-28-x86_64/00811928-kdsoap/kdsoap.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-28-x86_64/00811928-kdsoap/kdsoap-1.7.0-1.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824
--- Comment #10 from Luis Segundo ---
(In reply to Casper Meijn from comment #9)
> The "LICENSE.txt" is not the license under which we want to use the
> software. Is it then still necessary to include it?
I understand, if the license does not apply, it can be removed.
> I replaced %{_datarootdir} by %{_datadir}.
Nice!
please check this last issue
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file license.cpp is not marked as %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824
--- Comment #9 from Casper Meijn ---
Thanks Luis,
The "LICENSE.txt" is not the license under which we want to use the software.
Is it then still necessary to include it?
I replaced %{_datarootdir} by %{_datadir}.
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-rawhide-x86_64/00810756-kdsoap/kdsoap.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-rawhide-x86_64/00810756-kdsoap/kdsoap-1.7.0-1.fc30.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824
--- Comment #8 from Luis Segundo ---
Nice Casper,
It is necessary to add this license "LICENSE.txt"
and replace %{_datarootdir} to %{_datadir} on
%{_datarootdir}/mkspecs/features/kdsoap.prf
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824
--- Comment #7 from Casper Meijn ---
(In reply to Antonio Trande from comment #6)
> %doc = %_pkgdocdir = %{_docdir}/%{name} != %{_datarootdir}/doc/KDSoap
I understand now; the doc files were installed to the wrong path. I now delete
the doc files and install them using the %doc macro.
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-28-x86_64/00809343-kdsoap/kdsoap.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-28-x86_64/00809343-kdsoap/kdsoap-1.7.0-1.fc28.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824
--- Comment #6 from Antonio Trande ---
(In reply to Casper Meijn from comment #5)
> Am I correct that the %doc and %license marcos are for installing files from
> the source to the correct buildroot directory?
>
> I now remove the license files and use the %license macro. I added a comment
> for the multiple licenses. And added gcc-c++ to the BuildRequires again.
>
Yes. But you're not using '%doc' yet.
See https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
In your package:
%doc = %_pkgdocdir = %{_docdir}/%{name} != %{_datarootdir}/doc/KDSoap
Luis, please go on with your revision.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 --- Comment #5 from Casper Meijn --- Am I correct that the %doc and %license marcos are for installing files from the source to the correct buildroot directory? I now remove the license files and use the %license macro. I added a comment for the multiple licenses. And added gcc-c++ to the BuildRequires again. Spec URL: https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-28-x86_64/00808948-kdsoap/kdsoap.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-28-x86_64/00808948-kdsoap/kdsoap-1.7.0-1.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824
--- Comment #4 from Antonio Trande ---
(In reply to Luis Segundo from comment #1)
> you need to make some changes
>
> Issues:
> ===
> - All build dependencies are listed in BuildRequires, except for any that
> are listed in the exceptions section of Packaging Guidelines.
> Note: These BR are not needed: gcc-c++
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
It's a false positive. 'gcc-c++' must be listed as BuildRequires package else
compiler is not installed.
(In reply to Luis Segundo from comment #3)
> Hi Casper,
>
> For documentation use the macro: %doc
> and this one "%{_datarootdir}" can be removed
>
>
> for License replace
> %license %{_datarootdir}/doc/KDSoap/LICENSE.txt
> %license %{_datarootdir}/doc/KDSoap/LICENSE.GPL.txt
> %license %{_datarootdir}/doc/KDSoap/LICENSE.US.txt
>
> to %doc doc/KDSoap/LICENSE*
'doc/KDSoap/' is the wrong place for installing license files. Casper needs to
remove all LICENSE* files inside 'doc/KDSoap/', mark them with the '%license'
macro and comment for indicate which files are licensed with a specific
license.
See
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824
--- Comment #3 from Luis Segundo ---
Hi Casper,
For documentation use the macro: %doc
and this one "%{_datarootdir}" can be removed
for License replace
%license %{_datarootdir}/doc/KDSoap/LICENSE.txt
%license %{_datarootdir}/doc/KDSoap/LICENSE.GPL.txt
%license %{_datarootdir}/doc/KDSoap/LICENSE.US.txt
to %doc doc/KDSoap/LICENSE*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 --- Comment #2 from Casper Meijn --- Thanks for the quick reaction. I cleaned up the BuildRequires and Requires and marked the license files. However I am not sure whether I used the %license macro correctly nor how to validate it. Spec URL: https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-28-x86_64/00808791-kdsoap/kdsoap.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-28-x86_64/00808791-kdsoap/kdsoap-1.7.0-1.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 Luis Segundo changed: What|Removed |Added CC||l...@blackfile.net --- Comment #1 from Luis Segundo --- you need to make some changes Issues: === - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE.GPL.txt is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638824] Review Request: kdsoap - Qt-based SOAP library
https://bugzilla.redhat.com/show_bug.cgi?id=1638824 Casper Meijn changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
