[Bug 1645917] Review Request: python-nitime - Timeseries analysis for neuroscience data
https://bugzilla.redhat.com/show_bug.cgi?id=1645917 --- Comment #13 from Fedora Update System --- python-nitime-0.8-0.2.git1fab571.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645917] Review Request: python-nitime - Timeseries analysis for neuroscience data
https://bugzilla.redhat.com/show_bug.cgi?id=1645917 --- Comment #12 from Fedora Update System --- python-nitime-0.8-0.2.git1fab571.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645917] Review Request: python-nitime - Timeseries analysis for neuroscience data
https://bugzilla.redhat.com/show_bug.cgi?id=1645917 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-11-16 21:08:21 --- Comment #11 from Fedora Update System --- python-nitime-0.8-0.2.git1fab571.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645917] Review Request: python-nitime - Timeseries analysis for neuroscience data
https://bugzilla.redhat.com/show_bug.cgi?id=1645917 --- Comment #10 from Fedora Update System --- python-nitime-0.8-0.2.git1fab571.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-e0b8748c55 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645917] Review Request: python-nitime - Timeseries analysis for neuroscience data
https://bugzilla.redhat.com/show_bug.cgi?id=1645917 --- Comment #9 from Fedora Update System --- python-nitime-0.8-0.2.git1fab571.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-4a17374ba2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645917] Review Request: python-nitime - Timeseries analysis for neuroscience data
https://bugzilla.redhat.com/show_bug.cgi?id=1645917 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- python-nitime-0.8-0.2.git1fab571.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-6ff5e25689 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645917] Review Request: python-nitime - Timeseries analysis for neuroscience data
https://bugzilla.redhat.com/show_bug.cgi?id=1645917 --- Comment #7 from Fedora Update System --- python-nitime-0.8-0.2.git1fab571.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6ff5e25689 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645917] Review Request: python-nitime - Timeseries analysis for neuroscience data
https://bugzilla.redhat.com/show_bug.cgi?id=1645917 --- Comment #6 from Fedora Update System --- python-nitime-0.8-0.2.git1fab571.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-e0b8748c55 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645917] Review Request: python-nitime - Timeseries analysis for neuroscience data
https://bugzilla.redhat.com/show_bug.cgi?id=1645917 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- python-nitime-0.8-0.2.git1fab571.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-4a17374ba2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645917] Review Request: python-nitime - Timeseries analysis for neuroscience data
https://bugzilla.redhat.com/show_bug.cgi?id=1645917 --- Comment #4 from Ankur Sinha (FranciscoD) --- Thank you, Robert. SCM requested. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645917] Review Request: python-nitime - Timeseries analysis for neuroscience data
https://bugzilla.redhat.com/show_bug.cgi?id=1645917 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- LGTM, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645917] Review Request: python-nitime - Timeseries analysis for neuroscience data
https://bugzilla.redhat.com/show_bug.cgi?id=1645917 --- Comment #2 from Ankur Sinha (FranciscoD) --- Thanks for the review, Robert! (In reply to Robert-André Mauchin from comment #1) > - Use %bcond_with/bcond_without for these: These commands do not work on koji, so I don't find them particularly useful. I've got to then change the spec before committing to SCM, and I only use scratch builds to test my packages where these commands don't work either. > > # Multiple tests fail > %global run_tests 0 > > # The documentation fails to build on F29, so we'll just point to upstream > # documentation > %global with_doc 0 > > > # Requires nibabel which is only available for python3-nibabel > %global with_py2 0 > > > - Py2 package: THANKS should be in a %doc not %license Gah---corrected. > > - Build was successful with doc and tests in Rawhide. I suggest enabling > them. Unfortunately not. The tests fail on i686: https://koji.fedoraproject.org/koji/taskinfo?taskID=30715258 Igor already reported these upstream. I've added the tickets as comments to the spec file (and bumped them too). I've enabled the docs on rawhide (F30+). > > - Remove the sphinx-build leftovers: > > python-nitime-doc.x86_64: W: hidden-file-or-dir > /usr/share/doc/python-nitime-doc/html/.buildinfo Removed. > > - You doc subpackage should be noarch Corrected. > Generic: > [!]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > Note: Arch-ed rpms have a total of 8376320 bytes in /usr/share This was the -doc sub package that has been corrected. > series, Time-series, Timeservers > python3-nitime.x86_64: W: spelling-error Summary(en_US) neuroscience -> > pseudoscience > python3-nitime.x86_64: W: spelling-error %description -l en_US neuroscience > -> pseudoscience Eh? Neuroscience is NOT pseudoscience!! XD > python-nitime-doc.x86_64: W: summary-ended-with-dot C Documentation for > python-nitime. Corrected. > python-nitime-doc.x86_64: W: hidden-file-or-dir > /usr/share/doc/python-nitime-doc/html/.buildinfo Removed. New F29 build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30715539 New rawhide build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30715529 Updated spec/srpm: https://ankursinha.fedorapeople.org/python-nitime/python-nitime.spec https://ankursinha.fedorapeople.org/python-nitime/python-nitime-0.8-0.2.git1fab571.fc29.src.rpm Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645917] Review Request: python-nitime - Timeseries analysis for neuroscience data
https://bugzilla.redhat.com/show_bug.cgi?id=1645917
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- Use %bcond_with/bcond_without for these:
# Multiple tests fail
%global run_tests 0
# The documentation fails to build on F29, so we'll just point to upstream
# documentation
%global with_doc 0
# Requires nibabel which is only available for python3-nibabel
%global with_py2 0
- Py2 package: THANKS should be in a %doc not %license
- Build was successful with doc and tests in Rawhide. I suggest enabling them.
- Remove the sphinx-build leftovers:
python-nitime-doc.x86_64: W: hidden-file-or-dir
/usr/share/doc/python-nitime-doc/html/.buildinfo
- You doc subpackage should be noarch
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD 3-clause "New" or "Revised" License", "Unknown or
generated". 160 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/python-nitime/review-
python-nitime/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging
[Bug 1645917] Review Request: python-nitime - Timeseries analysis for neuroscience data
https://bugzilla.redhat.com/show_bug.cgi?id=1645917 Ankur Sinha (FranciscoD) changed: What|Removed |Added Blocks||1276941 (fedora-neuro) Alias||python-nitime Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
