[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 --- Comment #15 from Fedora Update System --- python-nilearn-0.4.2-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 --- Comment #14 from Fedora Update System --- python-nilearn-0.4.2-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-11-17 21:57:17 --- Comment #13 from Fedora Update System --- python-nilearn-0.4.2-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 --- Comment #12 from Fedora Update System --- python-nilearn-0.4.2-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9ccbc1b490 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 --- Comment #11 from Fedora Update System --- python-nilearn-0.4.2-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-3be256c3d7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- python-nilearn-0.4.2-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f50a900df5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 --- Comment #8 from Fedora Update System --- python-nilearn-0.4.2-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f50a900df5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 --- Comment #9 from Fedora Update System --- python-nilearn-0.4.2-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-3be256c3d7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #7 from Fedora Update System --- python-nilearn-0.4.2-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9ccbc1b490 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-nilearn -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 --- Comment #5 from Ankur Sinha (FranciscoD) --- Thanks! SCM requested: https://pagure.io/releng/fedora-scm-requests/issue/8776 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Robert-André Mauchin --- Ok, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 --- Comment #3 from Ankur Sinha (FranciscoD) --- Thanks for the review, Robert! Updated spec/srpm: https://ankursinha.fedorapeople.org/python-nilearn/python-nilearn.spec https://ankursinha.fedorapeople.org/python-nilearn/python-nilearn-0.4.2-2.fc29.src.rpm rpmlint still gives this, but it's a false positive: python3-nilearn.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/nilearn/surface/tests/data/test.label ascii label , from subject fsaverage5 vox2ras=TkReg python3-nilearn.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/nilearn/surface/tests/data/test.label 644 ascii label , from subject fsaverage5 vox2ras=TkReg The file is a data file, the "shebang" is part of the header. * Fri Nov 09 2018 Ankur Sinha - 0.4.2-2 - Correct license - Remvoe shebangs - Remove pre-compiled files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #2 from Robert-André Mauchin ---
# Requires nibabel that is py3 only in Fedora
%global with_py2 0
- Use %bcond_with
- Main license seems to be BSD, not MIT
- Remove the shebang in %prep:
python3-nilearn.noarch: E: wrong-script-interpreter
/usr/lib/python3.7/site-packages/nilearn/plotting/glass_brain_files/plot_align_svg.py
/usr/bin/env python
python3-nilearn.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/nilearn/plotting/glass_brain_files/plot_align_svg.py
644 /usr/bin/env python
- I'd remove these two pre-bytecompiled files in %prep:
python3-nilearn.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python3.7/site-packages/nilearn/datasets/tests/data/__init__.pyc
expected 3390 or 3391 or 3392 or 3393 or 3394 (3.7), found 62211 (2.7)
python3-nilearn.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python3.7/site-packages/nilearn/tests/data/__init__.pyc expected 3390
or 3391 or 3392 or 3393 or 3394 (3.7), found 62211 (2.7)
They will be byte-compiled correctly by the build process.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD 3-clause "New" or "Revised" License", "Unknown or
generated", "*No copyright* BSD (unspecified)". 188 files have unknown
license. Detailed output of licensecheck in /home/bob/packaging/review
/python-nilearn/review-python-nilearn/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 --- Comment #1 from Ankur Sinha (FranciscoD) --- Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30737047 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647825] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data
https://bugzilla.redhat.com/show_bug.cgi?id=1647825 Ankur Sinha (FranciscoD) changed: What|Removed |Added Blocks||1276941 (fedora-neuro) Alias||python-nilearn Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
