[Bug 1672601] Review Request: rubygem-bcrypt_pbkdf - OpenBSD's bcrypt_pdkfd (a variant of PBKDF2 with bcrypt-based PRF)
https://bugzilla.redhat.com/show_bug.cgi?id=1672601 Pavel Valena changed: What|Removed |Added Resolution|--- |RAWHIDE Status|POST|CLOSED Fixed In Version||rubygem-bcrypt_pbkdf-1.1.0- ||1.fc35 Last Closed||2021-07-31 08:29:59 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1672601] Review Request: rubygem-bcrypt_pbkdf - OpenBSD's bcrypt_pdkfd (a variant of PBKDF2 with bcrypt-based PRF)
https://bugzilla.redhat.com/show_bug.cgi?id=1672601 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-bcrypt_pbkdf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1672601] Review Request: rubygem-bcrypt_pbkdf - OpenBSD's bcrypt_pdkfd (a variant of PBKDF2 with bcrypt-based PRF)
https://bugzilla.redhat.com/show_bug.cgi?id=1672601 --- Comment #6 from Pavel Valena --- Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1672601] Review Request: rubygem-bcrypt_pbkdf - OpenBSD's bcrypt_pdkfd (a variant of PBKDF2 with bcrypt-based PRF)
https://bugzilla.redhat.com/show_bug.cgi?id=1672601 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #5 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1672601] Review Request: rubygem-bcrypt_pbkdf - OpenBSD's bcrypt_pdkfd (a variant of PBKDF2 with bcrypt-based PRF)
https://bugzilla.redhat.com/show_bug.cgi?id=1672601 Pavel Valena changed: What|Removed |Added Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1672601] Review Request: rubygem-bcrypt_pbkdf - OpenBSD's bcrypt_pdkfd (a variant of PBKDF2 with bcrypt-based PRF)
https://bugzilla.redhat.com/show_bug.cgi?id=1672601 Pavel Valena changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1672601] Review Request: rubygem-bcrypt_pbkdf - OpenBSD's bcrypt_pdkfd (a variant of PBKDF2 with bcrypt-based PRF)
https://bugzilla.redhat.com/show_bug.cgi?id=1672601 Pavel Valena changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://raw.githubusercontent.com/fedora-distgit/rubygem-bcrypt_pbkdf/rawhide/rubygem-bcrypt_pbkdf.spec SRPM URL: https://raw.githubusercontent.com/fedora-distgit/rubygem-bcrypt_pbkdf/rawhide/rubygem-bcrypt_pbkdf-1.1.0-1.fc35.src.rpm Description: This gem implements bcrypt_pdkfd (a variant of PBKDF2 with bcrypt-based PRF). Fedora Account System Username: pvalena COPR build: https://copr.fedorainfracloud.org/coprs/build/2340844 Koji scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=72405887 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1672601] Review Request: rubygem-bcrypt_pbkdf - OpenBSD's bcrypt_pdkfd (a variant of PBKDF2 with bcrypt-based PRF)
https://bugzilla.redhat.com/show_bug.cgi?id=1672601 --- Comment #4 from Pavel Valena --- I've fixed the Spec file and updated links in Description. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1672601] Review Request: rubygem-bcrypt_pbkdf - OpenBSD's bcrypt_pdkfd (a variant of PBKDF2 with bcrypt-based PRF)
https://bugzilla.redhat.com/show_bug.cgi?id=1672601 Pavel Valena changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://raw.githubusercontent.com/fedora-distgit/rubygem-bcrypt_pbkdf/rawhide/rubygem-bcrypt_pbkdf.spec SRPM URL: https://raw.githubusercontent.com/fedora-distgit/rubygem-bcrypt_pbkdf/rawhide/rubygem-bcrypt_pbkdf-1.1.0-1.fc35.src.rpm Description: This gem implements bcrypt_pdkfd (a variant of PBKDF2 with bcrypt-based PRF). Fedora Account System Username: pvalena COPR build: https://copr.fedorainfracloud.org/coprs/build/2336156 Koji scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=72312098 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
needinfo canceled: [Bug 1672601] Review Request: rubygem-bcrypt_pbkdf - OpenBSD's bcrypt_pdkfd (a variant of PBKDF2 with bcrypt-based PRF)
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for Robert-André Mauchin 's needinfo: Bug 1672601: Review Request: rubygem-bcrypt_pbkdf - OpenBSD's bcrypt_pdkfd (a variant of PBKDF2 with bcrypt-based PRF) https://bugzilla.redhat.com/show_bug.cgi?id=1672601 --- Comment #3 from Package Review --- This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672601] Review Request: rubygem-bcrypt_pbkdf - OpenBSD's bcrypt_pdkfd (a variant of PBKDF2 with bcrypt-based PRF)
https://bugzilla.redhat.com/show_bug.cgi?id=1672601
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- Source0 should be a URL
Source0: https://rubygems.org/downloads/%{gem_name}-%{version}.gem
- Some of the code is ASD and ISC: add it to the license field and add a
comment explaining the license breakdown:
BSD 2-clause "Simplified" License
-
bcrypt_pbkdf-1.0.0/ext/mri/hash_sha512.c
BSD 4-clause "Original" or "Old" License
bcrypt_pbkdf-1.0.0/ext/mri/blf.h
bcrypt_pbkdf-1.0.0/ext/mri/blowfish.c
ISC License
---
bcrypt_pbkdf-1.0.0/ext/mri/bcrypt_pbkdf.c
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[-]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD 4-clause "Original" or "Old" License", "BSD 2-clause
"Simplified" License", "Expat License", "Unknown or generated", "ISC
License". 18 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/rubygem-bcrypt_pbkdf
/review-rubygem-bcrypt_pbkdf/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
