[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code
https://bugzilla.redhat.com/show_bug.cgi?id=1685200 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-06-26 04:06:48 --- Comment #12 from Fedora Update System --- build2-0.11.0-1.fc30~bootstrap has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code
https://bugzilla.redhat.com/show_bug.cgi?id=1685200 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- build2-0.11.0-1.fc30~bootstrap has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-17d1334a4b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code
https://bugzilla.redhat.com/show_bug.cgi?id=1685200 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #10 from Fedora Update System --- FEDORA-2019-17d1334a4b has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-17d1334a4b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code
https://bugzilla.redhat.com/show_bug.cgi?id=1685200 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code
https://bugzilla.redhat.com/show_bug.cgi?id=1685200 --- Comment #9 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/build2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code
https://bugzilla.redhat.com/show_bug.cgi?id=1685200 Kevin Fenzi changed: What|Removed |Added CC||ke...@scrye.com --- Comment #8 from Kevin Fenzi --- I've sponsored Matthew. Please feel free to continue the process at https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner If you have any questions at all feel free to mail me or ask in mailing lists or irc... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code
https://bugzilla.redhat.com/show_bug.cgi?id=1685200 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #7 from Robert-André Mauchin --- Seems everything is good, package is approved. You still need to find a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code
https://bugzilla.redhat.com/show_bug.cgi?id=1685200
--- Comment #6 from Matthew Krupcale ---
Thanks for the prompt review.
(In reply to Robert-André Mauchin from comment #1)
> Package looks mostly good.
>
> - %{_prefix}/share/doc/ → %{_docdir}
>
> - Licenses should be placed in %{_defaultlicensedir}/%{name} When you
> specify an absolute path with %license, it doesn't copy the files. So either
> manually move the files in %install, or patch the install scripts, or use
> relative paths to locate the LICENSE files.
Done[1].
(In reply to Robert-André Mauchin from comment #3)
> Created attachment 1540776 [details]
> Build.log on Rawhide
>
> The program doesn't compile on Rawhide. The list of errors is very long.
Strange. These look like they have to do with libstdc++ and not build2.
(In reply to Robert-André Mauchin from comment #4)
> Heh it's working in Koji but not my local yet clean mock.
> https://koji.fedoraproject.org/koji/taskinfo?taskID=33168751
That's interesting. I'm not sure what the difference is compared to local mock,
but I also don't encounter these errors in COPR rawhide.
(In reply to Robert-André Mauchin from comment #5)
> - Got some GPLv2 and BSD in there:
>
> *No copyright* GPL (v2)
> ---
> build2-toolchain-0.9.0/libodb-2.5.0-b.11/LICENSE
> build2-toolchain-0.9.0/libodb-sqlite-2.5.0-b.11/LICENSE
>
> BSD 2-clause "Simplified" License
> -
> build2-toolchain-0.9.0/build2-0.9.0/libbutl-0.9.0/libbutl/sha256c.c
> build2-toolchain-0.9.0/build2-0.9.0/libbutl-0.9.0/libbutl/strptime.c
> build2-toolchain-0.9.0/build2-0.9.0/libbutl-0.9.0/libbutl/timelocal.c
> build2-toolchain-0.9.0/build2-0.9.0/libbutl-0.9.0/libbutl/timelocal.h
>
> BSD 3-clause "New" or "Revised" License
> ---
> build2-toolchain-0.9.0/build2-0.9.0/libbutl-0.9.0/libbutl/sha1.c
>
>
>Please add them to the License: field
I believe the BSD license is listed under the libbutl{,-devel,-static}
subpackages, which I believe are the only packages using BSD licensed code. The
Licensing guidelines[2] don't appear to distinguish the short-names between BSD
3-clause and 2-clause. Is this proper?
The case of the libodb license is a little more complicated. These are linked
(currently statically due to the bundling) with the bpkg and bdep packages.
Both of these packages state in their licenses[3,4] that they are exempt from
the usual ODB licensing with the intention of allowing bpkg and bdep to be
MIT-licensed[5]. I have been in contact with upstream[6], who is the author of
both ODB and build2, about this matter, and I believe their intention is to
allow bpkg and bdep to be purely MIT licensed rather than e.g. "MIT and GPLv2".
Having read the exception, I believe this is possible provided that we do not
modify the GPLv2 ODB code, but I'm not an expert on this matter. What do you
suggest in this case?
> and add a comment explaining the license breakdown.
Done for libbutl[1].
> - These files should be utf-8:
>
> build2-doc.noarch: W: file-not-utf8
> /usr/share/doc/build2/build2-build-system-manual-a4.ps
> build2-doc.noarch: W: file-not-utf8
> /usr/share/doc/build2/build2-build-system-manual-letter.ps
>
> Please fix them in %prep.
Done[1].
[1]
https://copr-be.cloud.fedoraproject.org/results/mkrupcale/build2/fedora-rawhide-x86_64/00864655-build2/build2.spec
[2] https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses
[3] https://git.build2.org/cgit/bpkg/tree/LICENSE
[4] https://git.build2.org/cgit/bdep/tree/LICENSE
[5]
https://git.codesynthesis.com/cgit/odb/odb-etc/tree/license-exceptions/build2-odb-license-exception.txt
[6] private email communication, 2018-10-17
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code
https://bugzilla.redhat.com/show_bug.cgi?id=1685200
--- Comment #5 from Robert-André Mauchin ---
- Got some GPLv2 and BSD in there:
*No copyright* GPL (v2)
---
build2-toolchain-0.9.0/libodb-2.5.0-b.11/LICENSE
build2-toolchain-0.9.0/libodb-sqlite-2.5.0-b.11/LICENSE
BSD 2-clause "Simplified" License
-
build2-toolchain-0.9.0/build2-0.9.0/libbutl-0.9.0/libbutl/sha256c.c
build2-toolchain-0.9.0/build2-0.9.0/libbutl-0.9.0/libbutl/strptime.c
build2-toolchain-0.9.0/build2-0.9.0/libbutl-0.9.0/libbutl/timelocal.c
build2-toolchain-0.9.0/build2-0.9.0/libbutl-0.9.0/libbutl/timelocal.h
BSD 3-clause "New" or "Revised" License
---
build2-toolchain-0.9.0/build2-0.9.0/libbutl-0.9.0/libbutl/sha1.c
Please add them to the License: field and add a comment explaining the
license breakdown.
- These files should be utf-8:
build2-doc.noarch: W: file-not-utf8
/usr/share/doc/build2/build2-build-system-manual-a4.ps
build2-doc.noarch: W: file-not-utf8
/usr/share/doc/build2/build2-build-system-manual-letter.ps
Please fix them in %prep.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD 3-clause "New" or "Revised" License", "BSD 2-clause
"Simplified" License", "Expat License", "Unknown or generated", "*No
copyright* GPL (v2)". 1844 files have unknown license. Detailed output
of licensecheck in /home/bob/packaging/review/build2/review-
build2/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 112640 bytes in 17 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match
[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code
https://bugzilla.redhat.com/show_bug.cgi?id=1685200 --- Comment #4 from Robert-André Mauchin --- Heh it's working in Koji but not my local yet clean mock. https://koji.fedoraproject.org/koji/taskinfo?taskID=33168751 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code
https://bugzilla.redhat.com/show_bug.cgi?id=1685200 --- Comment #3 from Robert-André Mauchin --- Created attachment 1540776 --> https://bugzilla.redhat.com/attachment.cgi?id=1540776=edit Build.log on Rawhide The program doesn't compile on Rawhide. The list of errors is very long. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code
https://bugzilla.redhat.com/show_bug.cgi?id=1685200
--- Comment #2 from Robert-André Mauchin ---
(%{_defaultlicensedir} is /usr/share/licenses)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code
https://bugzilla.redhat.com/show_bug.cgi?id=1685200
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
Package looks mostly good.
- %{_prefix}/share/doc/ → %{_docdir}
- Licenses should be placed in %{_defaultlicensedir}/%{name} When you specify
an absolute path with %license, it doesn't copy the files. So either manually
move the files in %install, or patch the install scripts, or use relative paths
to locate the LICENSE files.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code
https://bugzilla.redhat.com/show_bug.cgi?id=1685200 Matthew Krupcale changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
