[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #28 from Fedora Update System --- aeskeyfind-1.0-7.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #27 from Fedora Update System --- aeskeyfind-1.0-7.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #26 from Fedora Update System --- aeskeyfind-1.0-7.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #25 from Fedora Update System --- aeskeyfind-1.0-7.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #24 from Fedora Update System --- aeskeyfind-1.0-7.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-03-03 20:53:30 --- Comment #23 from Fedora Update System --- aeskeyfind-1.0-7.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #22 from Fedora Update System --- aeskeyfind-1.0-7.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-5f0edef101 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #21 from Fedora Update System --- aeskeyfind-1.0-7.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-dcfce7a05e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System --- aeskeyfind-1.0-7.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-71f1c089e3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #17 from Fedora Update System --- FEDORA-2020-71f1c089e3 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-71f1c089e3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #18 from Fedora Update System --- FEDORA-EPEL-2020-dcfce7a05e has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-dcfce7a05e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #19 from Fedora Update System --- FEDORA-EPEL-2020-5f0edef101 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-5f0edef101 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #16 from Fedora Update System --- aeskeyfind-1.0-7.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f5bdcff86b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- aeskeyfind-1.0-7.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-2c5eb82fae -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #13 from Fedora Update System --- FEDORA-2020-f5bdcff86b has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f5bdcff86b --- Comment #14 from Fedora Update System --- FEDORA-2020-2c5eb82fae has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-2c5eb82fae -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #13 from Fedora Update System --- FEDORA-2020-f5bdcff86b has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f5bdcff86b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #12 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/aeskeyfind -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #11 from Michal Ambroz --- Thank you Robert-Andre . Requesting the package repo - https://pagure.io/releng/fedora-scm-requests/issue/22261 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|needinfo? |fedora-review+ |needinfo?(zebo...@gmail.com | |) | --- Comment #10 from Robert-André Mauchin --- Package reapproved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 Michal Ambroz changed: What|Removed |Added Flags||needinfo? ||needinfo?(zebo...@gmail.com ||) --- Comment #9 from Michal Ambroz --- Unfortunately the approval is 60+ days old and pagure won't let me to create the package. Please Robert, may I ask you for re-approval? Thank you Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 Michal Ambroz changed: What|Removed |Added Status|POST|ASSIGNED Flags|fedora-review+ | |needinfo?(re...@seznam.cz) | --- Comment #8 from Michal Ambroz --- Hello, yes my fault ... I failed to process this and forgot about it with the Xmass frenzy. Here is the updated package. Unfortunately the approval is 60+ days old. Please Robert, may I ask you for re-approval? Spec URL: http://rebus.fedorapeople.org/aeskeyfind.spec SRPM URL: http://rebus.fedorapeople.org/aeskeyfind-1.0-7.fc31.src.rpm Best regards Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 dan.cer...@cgc-instruments.com changed: What|Removed |Added CC||dan.cermak@cgc-instruments. ||com Flags||needinfo?(re...@seznam.cz) --- Comment #7 from dan.cer...@cgc-instruments.com --- The package got approved but apparently never imported into dist-git. Was that forgotten? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #6 from Robert-André Mauchin ---
We have guidelines regarding gpg verification:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_verifying_signatures
BuildRequires: gnupg2
…
%prep
%{gpgverify} --keyring='%{SOURCE3}' --signature='%{SOURCE1}'
--data='%{SOURCE0}'
Please use this.
Package approved. Please fix the aforementioned issue before import.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD 2-clause "Simplified" License", "Unknown or generated". 7
files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/aeskeyfind/review-
aeskeyfind/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]:
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 Robert-André Mauchin changed: What|Removed |Added Flags||needinfo?(re...@seznam.cz) --- Comment #3 from Robert-André Mauchin --- Any news here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 Fabian Affolter changed: What|Removed |Added Alias||aeskeyfind -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 Fabian Affolter changed: What|Removed |Added CC||m...@fabian-affolter.ch Blocks||563471 (FE-SECLAB) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=563471 [Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #2 from Robert-André Mauchin ---
- Group: is not used in Fedora
- also use install -pm 0644 for the man page
- Please document what the patch is for:
Patch1: %{name}-%{version}-patch-001
- export CFLAGS="%{optflags}"
Use %set_build_flags instead
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD 2-clause "Simplified" License", "Unknown or generated",
"*No copyright* GPL (v2)". 7 files have unknown license. Detailed
output of licensecheck in
/home/bob/packaging/review/aeskeyfind/review-
aeskeyfind/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
aeskeyfind
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #1 from Michal Ambroz --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=33879121 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
