[Bug 1699846] Review Request: libyang - YANG data modeling language library
https://bugzilla.redhat.com/show_bug.cgi?id=1699846 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #9 from Fedora Update System --- libyang-0.16.105-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699846] Review Request: libyang - YANG data modeling language library
https://bugzilla.redhat.com/show_bug.cgi?id=1699846 --- Comment #8 from Fedora Update System --- libyang-0.16.105-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e5c06ff672 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699846] Review Request: libyang - YANG data modeling language library
https://bugzilla.redhat.com/show_bug.cgi?id=1699846 --- Comment #7 from Fedora Update System --- libyang-0.16.105-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-e5c06ff672 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699846] Review Request: libyang - YANG data modeling language library
https://bugzilla.redhat.com/show_bug.cgi?id=1699846 Tomas Korbar changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed||2019-05-07 08:11:41 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699846] Review Request: libyang - YANG data modeling language library
https://bugzilla.redhat.com/show_bug.cgi?id=1699846 --- Comment #6 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libyang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699846] Review Request: libyang - YANG data modeling language library
https://bugzilla.redhat.com/show_bug.cgi?id=1699846 Martin Osvald changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Martin Osvald --- things mentioned in comment 3 got fixed, looks good to me now, therefore giving it fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699846] Review Request: libyang - YANG data modeling language library
https://bugzilla.redhat.com/show_bug.cgi?id=1699846 Tomas Korbar changed: What|Removed |Added Flags|needinfo?(tkor...@redhat.co | |m) | --- Comment #4 from Tomas Korbar --- Problems solved. Files updated. Thanks for pointing out all of these issues. New Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=34465888 SRPM: https://tkorbar.fedorapeople.org/libyang/libyang-0.16.105-1.fc31.src.rpm Specfile: https://tkorbar.fedorapeople.org/libyang/libyang.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699846] Review Request: libyang - YANG data modeling language library
https://bugzilla.redhat.com/show_bug.cgi?id=1699846
Martin Osvald changed:
What|Removed |Added
Flags||needinfo?(tkor...@redhat.co
||m)
--- Comment #3 from Martin Osvald ---
What needs to be looked further into (evaluated)...
In short the most important stuff to me:
1. Remove ldconfig scriptlets as they are not needed since and including F28.
Besides there is a duplication of the same thing %ldconfig_scriptlets does the
same thing as the lines 103 & 104:
~~~
101 %ldconfig_scriptlets
102
103 %post -n libyang-cpp -p /sbin/ldconfig
104 %postun -n libyang-cpp -p /sbin/ldconfig
~~~
2. Change libyang-devel-doc from x86_64 to noarch
3. Add python_provide macro
The below is cherry-picked list from comment 2:
Issues:
===
- ldconfig not called in %post and %postun for Fedora 28 and later.
Note: /sbin/ldconfig called in libyang-cpp
See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
= MUST items =
[!]: Spec file is legible and written in American English.
- libyang.x86_64: W: spelling-error %description -l en_US modelling ->
modeling, model ling, model-ling
[!]: Package meets the Packaging Guidelines::Python
- XXX NOTE: Not a python expert, but shouldn't spec file contain python_provide
macro if it provides python module?
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_python_provide_macro
e.g something like the below?
~~~
%global srcname libyang
%package -n python3-%{srcname}
Summary:Python3 bindings for libyang
Requires: libyang-cpp%{?_isa} = %{version}-%{release}
Requires: %{name}%{?_isa} = %{version}-%{release}
%{?python_provide:%python_provide python3-%{srcname}}
~~~
= SHOULD items =
Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
= EXTRA items =
Generic:
[!]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Note: Arch-ed rpms have a total of 11233280 bytes in /usr/share
libyang-devel-doc-0.16.105-1.fc31.x86_64.rpm:11212800
See:
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699846] Review Request: libyang - YANG data modeling language library
https://bugzilla.redhat.com/show_bug.cgi?id=1699846
--- Comment #2 from Martin Osvald ---
The below is output from 'fedora-review' utility and where needed I added extra
comments starting with '- XXX NOTE:':
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- ldconfig not called in %post and %postun for Fedora 28 and later.
Note: /sbin/ldconfig called in libyang-cpp
See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
License", "Expat License", "BSD 2-clause "Simplified" License", "*No
copyright* BSD 3-clause "New" or "Revised" License", "GPL (v3 or
later)", "BSD (unspecified)". 1360 files have unknown license.
Detailed output of licensecheck in /home/mosvald/Work/redhat/src/pkg-
review/libyang/review-libyang/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[!]: Spec file is legible and written in American English.
- libyang.x86_64: W: spelling-error %description -l en_US modelling ->
modeling, model ling, model-ling
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[-]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an
[Bug 1699846] Review Request: libyang - YANG data modeling language library
https://bugzilla.redhat.com/show_bug.cgi?id=1699846 Martin Osvald changed: What|Removed |Added CC||mosv...@redhat.com Assignee|nob...@fedoraproject.org|mosv...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
