[Bug 1701005] Review Request: golang-github-oracle-oci-sdk - Go SDK for Oracle Cloud Infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1701005 --- Comment #12 from Fedora Update System --- golang-github-oracle-oci-sdk-5.4.0-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1701005] Review Request: golang-github-oracle-oci-sdk - Go SDK for Oracle Cloud Infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1701005 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-05-01 00:40:30 --- Comment #11 from Fedora Update System --- golang-github-oracle-oci-sdk-5.4.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1701005] Review Request: golang-github-oracle-oci-sdk - Go SDK for Oracle Cloud Infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1701005 --- Comment #10 from Fedora Update System --- golang-github-oracle-oci-sdk-5.4.0-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8d9952b783 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1701005] Review Request: golang-github-oracle-oci-sdk - Go SDK for Oracle Cloud Infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1701005 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- golang-github-oracle-oci-sdk-5.4.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d3d8b7c371 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1701005] Review Request: golang-github-oracle-oci-sdk - Go SDK for Oracle Cloud Infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1701005 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #7 from Fedora Update System --- golang-github-oracle-oci-sdk-5.4.0-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8d9952b783 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1701005] Review Request: golang-github-oracle-oci-sdk - Go SDK for Oracle Cloud Infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1701005 --- Comment #8 from Fedora Update System --- golang-github-oracle-oci-sdk-5.4.0-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d3d8b7c371 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1701005] Review Request: golang-github-oracle-oci-sdk - Go SDK for Oracle Cloud Infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1701005 --- Comment #6 from Carl George --- Rawhide build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1253220 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1701005] Review Request: golang-github-oracle-oci-sdk - Go SDK for Oracle Cloud Infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1701005 --- Comment #5 from Carl George --- Sure, I'll take a closer look at go2rpm. Thanks for the suggestion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1701005] Review Request: golang-github-oracle-oci-sdk - Go SDK for Oracle Cloud Infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1701005 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-oracle-oci-sdk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1701005] Review Request: golang-github-oracle-oci-sdk - Go SDK for Oracle Cloud Infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1701005 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1701005] Review Request: golang-github-oracle-oci-sdk - Go SDK for Oracle Cloud Infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1701005
--- Comment #3 from Robert-André Mauchin ---
Package approved.
May I suggest you to beta-test go2rpm for you future SPEC?
https://pagure.io/GoSIG/go2rpm
go2rpm -p1 github.com/oracle/oci-go-sdk
produces:
# Generated by go2rpm
%bcond_without check
# https://github.com/oracle/oci-go-sdk
%global goipath github.com/oracle/oci-go-sdk
Version:5.4.0
%gometa
%global common_description %{expand:
Go sdk for oracle cloud infrastructure.}
Name: %{goname}
Release:1%{?dist}
Summary:Go sdk for oracle cloud infrastructure
# Upstream license specification: Apache-2.0
License:ASL 2.0
URL:%{gourl}
Source0:%{gosource}
%if %{with check}
# Tests
BuildRequires: golang(github.com/stretchr/testify/assert)
BuildRequires: golang(github.com/stretchr/testify/mock)
%endif
%description
%{common_description}
%package devel
Summary: %{summary}
BuildArch: noarch
%description devel
%{common_description}
This package contains library source intended for
building other packages which use import path with
%{goipath} prefix.
%prep
%forgeautosetup -p1
%build
%gobuildroot
for cmd in cmd/* ; do
%gobuild -o _bin/$(basename $cmd) %{goipath}/$cmd
done
%install
%goinstall
install -m 0755 -vd %{buildroot}%{_bindir}
install -m 0755 -vp _bin/* %{buildroot}%{_bindir}/
%if %{with check}
%check
%gochecks
%endif
%files
%license LICENSE.txt
%doc example CHANGELOG.md CONTRIBUTING.md README.md
%{_bindir}/*
%files devel -f devel.file-list
%license LICENSE.txt
%doc example CHANGELOG.md CONTRIBUTING.md README.md
%changelog
* Mon Apr 22 17:51:04 CEST 2019 Robert-André Mauchin -
5.4.0-1
- Initial package
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 1536 files have unknown license.
Detailed output of licensecheck in /home/bob/packaging/review/golang-
github-oracle-oci-sdk/review-golang-github-oracle-oci-
sdk/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source,
[Bug 1701005] Review Request: golang-github-oracle-oci-sdk - Go SDK for Oracle Cloud Infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1701005 --- Comment #2 from Carl George --- That was a typo, thanks for catching that. Fixed. Spec URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/00886401-golang-github-oracle-oci-sdk/golang-github-oracle-oci-sdk.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/00886401-golang-github-oracle-oci-sdk/golang-github-oracle-oci-sdk-5.4.0-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1701005] Review Request: golang-github-oracle-oci-sdk - Go SDK for Oracle Cloud Infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1701005 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- - Should these be two %goinstall here: %install %goinstall # upstream has a versioning tool that is not useful for us %goinstall -t cmd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
