[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||python-makefun-1.6.11-1.fc3
   ||2
 Resolution|--- |RAWHIDE
Last Closed||2019-10-04 13:16:13



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786



--- Comment #22 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-makefun

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #21 from Zbigniew Jędrzejewski-Szmek  ---
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786

Miro Hrončok  changed:

   What|Removed |Added

   Assignee|sanjay.an...@gmail.com  |mhron...@redhat.com
  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks||1752196



--- Comment #20 from Zbigniew Jędrzejewski-Szmek  ---
successful koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=38046960

Please give the ack.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1752196
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during
test execution and retrieve it at the end
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-09-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

  Flags|needinfo?(sanjay.ankur@gmai |
   |l.com)  |



--- Comment #19 from Ankur Sinha (FranciscoD)  ---
Low on cycles---will be done by next week. Please take it up if you have
cycles, Robert.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-09-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags||needinfo?(sanjay.ankur@gmai
   ||l.com)



--- Comment #18 from Robert-André Mauchin  ---
Ping, ready to finish this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-09-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786



--- Comment #17 from Zbigniew Jędrzejewski-Szmek  ---
Thanks for all the discussion and sorry for the delay.

- update to latest version
- add .toml override
- add missing %python_provide

Spec URL: https://in.waw.pl/~zbyszek/fedora/python-makefun.spec
SRPM URL:
https://in.waw.pl/~zbyszek/fedora/python-makefun-1.6.11-1.fc32.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-09-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786



--- Comment #16 from Miro Hrončok  ---
I am waiting for new mock to be deployed on Koji.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-09-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786



--- Comment #15 from Ankur Sinha (FranciscoD)  ---
We can proceed here---Miro said they'd make an announcement to -devel about the
experimental macros.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786



--- Comment #14 from Ankur Sinha (FranciscoD)  ---
I've filed a ticket with the packaging committee discussing the use of these
macros. Please wait till they make their suggestion:

https://pagure.io/packaging-committee/issue/918

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786



--- Comment #13 from Robert-André Mauchin  ---
You're missing the Python provide macros:


%package -n python3-makefun
Summary: %{summary}
%{?python_provide:%python_provide python3-makefun}

%description -n python3-makefun %_description

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #12 from Robert-André Mauchin  ---
With Mock 1.4.17 and 

cat >pyproject.toml 

[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786



--- Comment #11 from Ankur Sinha (FranciscoD)  ---
I forgot to add: 

So, if we can please remove these from the spec for the time being, we can get
this review back on track. 

(Further discussion of these macros and their adoption should occur on the
devel ML, probably via a Change announcement:
https://fedoraproject.org/wiki/Changes/Policy similar to how the automated dep
generators were announced:
https://fedoraproject.org/wiki/Changes/EnablingPythonGenerators)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

  Flags|needinfo?(pkop...@redhat.co |
   |m)  |



--- Comment #10 from Ankur Sinha (FranciscoD)  ---
(In reply to Petr Viktorin from comment #9)
> > There's also no mention of these macros in the python packaging 
> > guidelines---should we wait for them to be made public before using them?
> 
> They are currently experimental. If you use them, you should be prepared to
> follow the development and maybe adjust the package if we need to do any
> changes (though we'll try to not break stuff).
> 

In this case, I think it is best to wait until they're announced to the whole
community---as part of the Python packaging guidelines---before using them.


What do you think Zbigniew? We need to ensure that these specs remain
consistent since all members of the neuro-sig (at least) would be looking after
them.

I'm all for early adoption, but I do not think these are ready for adoption
yet, especially since the review process also requires others to know how they
are meant to be used. We may not mind keeping up with the changes to these
macros, but it isn't fair to expect others to keep up with their development
also.

(Additionally, the current set of python macros already makes the spec quite
short and neat, so moving to these new ones doesn't seem too urgent to me.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786

Petr Viktorin  changed:

   What|Removed |Added

 CC||pvikt...@redhat.com



--- Comment #9 from Petr Viktorin  ---
> There's also no mention of these macros in the python packaging 
> guidelines---should we wait for them to be made public before using them?

They are currently experimental. If you use them, you should be prepared to
follow the development and maybe adjust the package if we need to do any
changes (though we'll try to not break stuff).


Anyway, you should put SETUP_REQUIRES in your pyproject.toml as well:
['pytest-runner', 'setuptools_scm', 'pypandoc', 'pandoc', 'six']
Unfortunately, setuptools needs to download code from the Internet to bootstrap
and read the info from setup.py -- which isn't allowed in Fedora. It's one of
the reasons for the move to pyproject.toml.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786

Patrik Kopkan  changed:

   What|Removed |Added

  Flags||needinfo?(pkop...@redhat.co
   ||m)



--- Comment #8 from Patrik Kopkan  ---
diff -Naur makefun-1.6.10.orig/pyproject.toml makefun-1.6.10/pyproject.toml
--- makefun-1.6.10.orig/pyproject.toml  1970-01-01 01:00:00.0 +0100
+++ makefun-1.6.10/pyproject.toml   2019-08-13 13:39:52.688122126 +0200
@@ -0,0 +1,3 @@
+[build-system]
+requires = ["setuptools", "setuptools-scm", "wheel"]
+build-backend = "setuptools.build_meta"

I tried this patch adding pyproject.toml. Build still fails, will investigate.

INFO: mock.py version 1.4.17 starting (python version = 3.7.3)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
INFO: Start(python-makefun-1.6.10-1.fc29.src.rpm) 
Config(fedora-rawhide-x86_64)
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.17
INFO: Mock Version: 1.4.17
Finish: chroot init
Start: build phase for python-makefun-1.6.10-1.fc29.src.rpm
Start: build setup for python-makefun-1.6.10-1.fc29.src.rpm
Building target platforms: x86_64
Building for target x86_64
setting SOURCE_DATE_EPOCH=1565395200
Wrote: /builddir/build/SRPMS/python-makefun-1.6.10-1.fc31.src.rpm
fedora37
kB/s |  19 kB 00:00
Package pyproject-rpm-macros-0-4.fc31.noarch is already installed.
Dependencies resolved.
Nothing to do.
Complete!
Finish: build setup for python-makefun-1.6.10-1.fc29.src.rpm
Start: rpmbuild python-makefun-1.6.10-1.fc29.src.rpm
Start: Outputting list of installed packages
Finish: Outputting list of installed packages
Building target platforms: x86_64
Building for target x86_64
setting SOURCE_DATE_EPOCH=1565395200
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.TUBPvu
+ umask 022
+ cd /builddir/build/BUILD
+ cd /builddir/build/BUILD
+ rm -rf makefun-1.6.10
+ /usr/bin/gzip -dc /builddir/build/SOURCES/makefun-1.6.10.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd makefun-1.6.10
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ /usr/bin/cat /builddir/build/SOURCES/pyproject.toml.patch
+ /usr/bin/patch -s --fuzz=0 --no-backup-if-mismatch
+ sed -r -i 's/'\''pandoc'\'', //' setup.py
+ RPM_EC=0
++ jobs -p
+ exit 0
Executing(%generate_buildrequires): /bin/sh -e /var/tmp/rpm-tmp.oYCEIw
+ umask 022
+ cd /builddir/build/BUILD
+ cd makefun-1.6.10
+ echo python3-devel
+ echo 'python3dist(packaging)'
+ echo 'python3dist(pip) >= 19'
+ echo 'python3dist(pytoml)'
+ rm -rfv '*.dist-info/'
+ '[' -f /usr/bin/python3 ']'
+ /usr/bin/python3 -I /usr/lib/rpm/redhat/pyproject_buildrequires.py -r
Handling setuptools from build-system.requires
Requirement satisfied: setuptools
   (installed: setuptools 41.0.1)
Handling setuptools-scm from build-system.requires
Requirement satisfied: setuptools-scm
   (installed: setuptools-scm 3.3.3)
Handling wheel from build-system.requires
Requirement satisfied: wheel
   (installed: wheel 0.33.1)
setup.py:46: DeprecationWarning: Due to possible ambiguity, 'convert()' is
deprecated. Use 'convert_file()'  or 'convert_text()'.
  LONG_DESCRIPTION = pypandoc.convert(path.join(here, 'docs',
'long_description.md'), 'rst').replace('\r', '')
Handling wheel from get_requires_for_build_wheel
Requirement satisfied: wheel
   (installed: wheel 0.33.1)
Handling pytest-runner from get_requires_for_build_wheel
Handling setuptools_scm from get_requires_for_build_wheel
Handling pypandoc from get_requires_for_build_wheel
Requirement satisfied: pypandoc
   (installed: pypandoc 1.4)
Handling six from get_requires_for_build_wheel
Requirement satisfied: six
   (installed: six 1.12.0)
setup.py:46: DeprecationWarning: Due to possible ambiguity, 'convert()' is
deprecated. Use 'convert_file()'  or 'convert_text()'.
  LONG_DESCRIPTION = pypandoc.convert(path.join(here, 'docs',
'long_description.md'), 'rst').replace('\r', '')
Download error on https://pypi.org/simple/pytest-runner/: [Errno -2] Name or
service not known -- Some packages may not be found!
Couldn't find index page for 'pytest-runner' (maybe misspelled?)
Download error on https://pypi.org/simple/: [Errno -2] Name or service not
known -- Some packages may not be found!
No local packages or working download links found for pytest-runner
Traceback (most recent call last):
  File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 241, in main
extras=args.extras,
  File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 195, in
generate_requires
generate_run_requirements(backend, requirements)
  File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 169, in
generate_run_requirements

[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786

Miro Hrončok  changed:

   What|Removed |Added

 CC||mhron...@redhat.com
  Flags|needinfo?(pkop...@redhat.co |
   |m)  |



--- Comment #7 from Miro Hrončok  ---
+ /usr/bin/python3 -I /usr/lib/rpm/redhat/pyproject_buildrequires.py
Handling setuptools >= 40.8 from default build backend
Requirement satisfied: setuptools >= 40.8
   (installed: setuptools 41.0.1)
Handling wheel from default build backend
Requirement satisfied: wheel
   (installed: wheel 0.33.1)


It seem the project has no pyproject.toml and hence the pyproject macros cannot
know the setup dependencies before executing setup. Either add setuptools_scm
to pyproject.toml or BR it manually before that happens.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||pkop...@redhat.com
  Flags||needinfo?(pkop...@redhat.co
   ||m)



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
Patrik, could you take a look?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786



--- Comment #5 from Ankur Sinha (FranciscoD)  ---
Hrm, no luck:

---

Mock Version: 1.4.17
Mock Version: 1.4.17
Mock Version: 1.4.17
ENTER ['do_with_status'](['bash', '--login', '-c', '/usr/bin/rpmbuild -bs
--target x86_64 --nodeps /builddir/build/SPECS/python-makefun.spec'],
chrootPath='/var/lib/mock/fedora-rawhide-x86_64/root'env={'TERM': 'vt100',
'SHELL': '/bin/bash', 'HOME': '/builddir', 'HOSTNAME': 'mock', 'PATH':
'/usr/bin:/bin:/usr/sbin:/sbin', 'PROMPT_COMMAND': 'printf
"\\033]0;\\007"', 'PS1': ' \\s-\\v\\$ ', 'LANG':
'en_GB.UTF-8'}shell=Falselogger=timeout=0uid=1000gid=135user='mockbuild'nspawn_args=['--capability=cap_ipc_lock',
'--bind=/tmp/mock-resolv.lle62yzs:/etc/resolv.conf']unshare_net=TrueprintOutput=False)
Using nspawn with args ['--capability=cap_ipc_lock',
'--bind=/tmp/mock-resolv.lle62yzs:/etc/resolv.conf']
Executing command: ['/usr/bin/systemd-nspawn', '-q', '-M',
'b2485c78596e47c58b8dfb7be024a637', '-D',
'/var/lib/mock/fedora-rawhide-x86_64/root', '-a', '--capability=cap_ipc_lock',
'--bind=/tmp/mock-resolv.lle62yzs:/etc/resolv.conf', '--setenv=TERM=vt100',
'--setenv=SHELL=/bin/bash', '--setenv=HOME=/builddir',
'--setenv=HOSTNAME=mock', '--setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin',
'--setenv=PROMPT_COMMAND=printf "\\033]0;\\007"',
'--setenv=PS1= \\s-\\v\\$ ', '--setenv=LANG=en_GB.UTF-8', '-u',
'mockbuild', 'bash', '--login', '-c', '/usr/bin/rpmbuild -bs --target x86_64
--nodeps /builddir/build/SPECS/python-makefun.spec'] with env {'TERM': 'vt100',
'SHELL': '/bin/bash', 'HOME': '/builddir', 'HOSTNAME': 'mock', 'PATH':
'/usr/bin:/bin:/usr/sbin:/sbin', 'PROMPT_COMMAND': 'printf
"\\033]0;\\007"', 'PS1': ' \\s-\\v\\$ ', 'LANG':
'en_GB.UTF-8'} and shell False
Building target platforms: x86_64
Building for target x86_64
setting SOURCE_DATE_EPOCH=1565395200
Wrote: /builddir/build/SRPMS/python-makefun-1.6.10-1.fc31.src.rpm
Child return code was: 0
ENTER ['do_with_status'](['bash', '--login', '-c', '/usr/bin/rpmbuild -br
--target x86_64 --nodeps /builddir/build/SPECS/python-makefun.spec'],
chrootPath='/var/lib/mock/fedora-rawhide-x86_64/root'env={'TERM': 'vt100',
'SHELL': '/bin/bash', 'HOME': '/builddir', 'HOSTNAME': 'mock', 'PATH':
'/usr/bin:/bin:/usr/sbin:/sbin', 'PROMPT_COMMAND': 'printf
"\\033]0;\\007"', 'PS1': ' \\s-\\v\\$ ', 'LANG':
'en_GB.UTF-8'}shell=Falselogger=timeout=0uid=1000gid=135user='mockbuild'nspawn_args=['--capability=cap_ipc_lock',
'--bind=/tmp/mock-resolv.lle62yzs:/etc/resolv.conf']unshare_net=TrueprintOutput=False)
Using nspawn with args ['--capability=cap_ipc_lock',
'--bind=/tmp/mock-resolv.lle62yzs:/etc/resolv.conf']
Executing command: ['/usr/bin/systemd-nspawn', '-q', '-M',
'314bc3d5fae44452943fafc86a609b84', '-D',
'/var/lib/mock/fedora-rawhide-x86_64/root', '-a', '--capability=cap_ipc_lock',
'--bind=/tmp/mock-resolv.lle62yzs:/etc/resolv.conf', '--setenv=TERM=vt100',
'--setenv=SHELL=/bin/bash', '--setenv=HOME=/builddir',
'--setenv=HOSTNAME=mock', '--setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin',
'--setenv=PROMPT_COMMAND=printf "\\033]0;\\007"',
'--setenv=PS1= \\s-\\v\\$ ', '--setenv=LANG=en_GB.UTF-8', '-u',
'mockbuild', 'bash', '--login', '-c', '/usr/bin/rpmbuild -br --target x86_64
--nodeps /builddir/build/SPECS/python-makefun.spec'] with env {'TERM': 'vt100',
'SHELL': '/bin/bash', 'HOME': '/builddir', 'HOSTNAME': 'mock', 'PATH':
'/usr/bin:/bin:/usr/sbin:/sbin', 'PROMPT_COMMAND': 'printf
"\\033]0;\\007"', 'PS1': ' \\s-\\v\\$ ', 'LANG':
'en_GB.UTF-8'} and shell False
Building target platforms: x86_64
Building for target x86_64
setting SOURCE_DATE_EPOCH=1565395200
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.fsbTst
+ umask 022
+ cd /builddir/build/BUILD
+ cd /builddir/build/BUILD
+ rm -rf makefun-1.6.10
+ /usr/bin/gzip -dc /builddir/build/SOURCES/makefun-1.6.10.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd makefun-1.6.10
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ sed -r -i 's/'\''pandoc'\'', //' setup.py
+ RPM_EC=0
++ jobs -p
+ exit 0
Executing(%generate_buildrequires): /bin/sh -e /var/tmp/rpm-tmp.y0iHDt
+ umask 022
+ cd /builddir/build/BUILD
+ cd makefun-1.6.10
+ echo python3-devel
+ echo 'python3dist(packaging)'
+ echo 'python3dist(pip) >= 19'
+ echo 'python3dist(pytoml)'
+ rm -rfv '*.dist-info/'
+ '[' -f /usr/bin/python3 ']'
+ /usr/bin/python3 -I /usr/lib/rpm/redhat/pyproject_buildrequires.py
Handling setuptools >= 40.8 from default build backend
Requirement satisfied: setuptools >= 40.8
   (installed: setuptools 41.0.1)
Handling wheel from default build backend
Requirement satisfied: wheel
   (installed: wheel 0.33.1)
Traceback (most recent call last):
  File "setup.py", line 22, in 
from setuptools_scm import get_version
ModuleNotFoundError: No module named 'setuptools_scm'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 241, in main
extras=args.extras,
  File 

[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786



--- Comment #4 from Ankur Sinha (FranciscoD)  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> I was told to use mock from updates-testing. I have
> mock-1.4.17-1.fc29.noarch.
> I only looked at https://src.fedoraproject.org/rpms/pyproject-rpm-macros/.
> This should
> be enough, because the way that the macros are used is very simple.

Odd, I have this version already, but fedora-review fails:

mock-1.4.17-1.fc30.noarch

Trying again..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
I was told to use mock from updates-testing. I have mock-1.4.17-1.fc29.noarch.
I only looked at https://src.fedoraproject.org/rpms/pyproject-rpm-macros/. This
should
be enough, because the way that the macros are used is very simple.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786



--- Comment #1 from Ankur Sinha (FranciscoD)  ---
Hrm, build failing here in mock:

+ /usr/bin/python3 -I /usr/lib/rpm/redhat/pyproject_buildrequires.py
Handling setuptools >= 40.8 from default build backend
Requirement satisfied: setuptools >= 40.8
   (installed: setuptools 41.0.1)
Handling wheel from default build backend
Requirement satisfied: wheel
   (installed: wheel 0.33.1)
Traceback (most recent call last):
  File "setup.py", line 22, in 
from setuptools_scm import get_version
ModuleNotFoundError: No module named 'setuptools_scm'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 241, in main
extras=args.extras,
  File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 193, in
generate_requires
generate_build_requirements(backend, requirements)
  File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 157, in
generate_build_requirements
new_reqs = get_requires()
  File "/usr/lib/python3.7/site-packages/setuptools/build_meta.py", line 145,
in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=['wheel'])
  File "/usr/lib/python3.7/site-packages/setuptools/build_meta.py", line 126,
in _get_build_requires
self.run_setup()
  File "/usr/lib/python3.7/site-packages/setuptools/build_meta.py", line 141,
in run_setup
exec(compile(code, __file__, 'exec'), locals())
  File "setup.py", line 26, in 
'them manually using conda or other system. The list is : ' +
str(SETUP_REQUIRES)), e)
  File "", line 3, in raise_from
Exception: Required packages for setup not found. You may wish you execute "pip
install -r ci_tools/requirements-setup.txt" to install them or alternatively
install them manually using conda or other system. The list is :
['pytest-runner', 'setuptools_scm', 'pypandoc', 'six']
python3-devel
python3dist(packaging)
python3dist(pip) >= 19
python3dist(pytoml)
python3dist(setuptools) >= 40.8
python3dist(wheel)
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.B5svrt (%generate_buildrequires)
Bad exit status from /var/tmp/rpm-tmp.B5svrt (%generate_buildrequires)
Child return code was: 1
EXCEPTION: [Error()]
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line
95, in trace
result = func(*args, **kw)
  File "/usr/lib/python3.7/site-packages/mockbuild/util.py", line 748, in
do_with_status
raise exception.Error("Command failed: \n # %s\n%s" % (command, output),
child.returncode)
mockbuild.exception.Error: Command failed: 
 # /usr/bin/systemd-nspawn -q -M 892c670464364d028ef47657b304754c -D
/var/lib/mock/fedora-rawhide-x86_64/root -a --capability=cap_ipc_lock
--bind=/tmp/mock-resolv.m7ve4j6b:/etc/resolv.conf --setenv=TERM=vt100
--setenv=SHELL=/bin/bash --setenv=HOME=/builddir --setenv=HOSTNAME=mock
--setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf
"\033]0;\007" --setenv=PS1= \s-\v\$ 
--setenv=LANG=en_GB.UTF-8 -u mockbuild bash --login -c /usr/bin/rpmbuild -br
--target x86_64 --nodeps /builddir/build/SPECS/python-makefun.spec



%generate_build_requires not working properly?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786



--- Comment #2 from Ankur Sinha (FranciscoD)  ---
There's also no mention of these macros in the python packaging
guidelines---should we wait for them to be made public before using them? It
makes reviews very hard otherwise---one has to keep looking at their
definitions to see what they're doing. Or is there documentation somewhere
about them?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sanjay.an...@gmail.com
   Assignee|nob...@fedoraproject.org|sanjay.an...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature

2019-08-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1739786

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks||1739787




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1739787
[Bug 1739787] Review Request: python-decopatch - A helper to write python
decorators
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org