[Bug 1739798] Review Request: python-fiat - Generator of arbitrary order instances of Lagrange elements on lines, triangles, and tetrahedra
https://bugzilla.redhat.com/show_bug.cgi?id=1739798 Bug 1739798 depends on bug 1739795, which changed state. Bug 1739795 Summary: Review Request: python-pytest-cases - Separate test code from test cases in pytest https://bugzilla.redhat.com/show_bug.cgi?id=1739795 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739798] Review Request: python-fiat - Generator of arbitrary order instances of Lagrange elements on lines, triangles, and tetrahedra
https://bugzilla.redhat.com/show_bug.cgi?id=1739798 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Blocks||1759883 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1759883 [Bug 1759883] Review Request: dolfin - FEniCS computational backend and problem solving environment -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739798] Review Request: python-fiat - Generator of arbitrary order instances of Lagrange elements on lines, triangles, and tetrahedra
https://bugzilla.redhat.com/show_bug.cgi?id=1739798 --- Comment #6 from Zbigniew Jędrzejewski-Szmek --- https://src.fedoraproject.org/rpms/python-fiat/pull-request/1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739798] Review Request: python-fiat - Generator of arbitrary order instances of Lagrange elements on lines, triangles, and tetrahedra
https://bugzilla.redhat.com/show_bug.cgi?id=1739798 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CANTFIX Last Closed||2019-10-06 17:13:02 --- Comment #5 from Zbigniew Jędrzejewski-Szmek --- Duh, I screwed up badly. Package exists already. I'll submit my version as a PR. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739798] Review Request: python-fiat - Generator of arbitrary order instances of Lagrange elements on lines, triangles, and tetrahedra
https://bugzilla.redhat.com/show_bug.cgi?id=1739798 --- Comment #4 from Zbigniew Jędrzejewski-Szmek --- Thanks. Somehow the srpm had a patch from before I edited it to make it apply. Should be fixed now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739798] Review Request: python-fiat - Generator of arbitrary order instances of Lagrange elements on lines, triangles, and tetrahedra
https://bugzilla.redhat.com/show_bug.cgi?id=1739798
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #3 from Robert-André Mauchin ---
- There's a lot of mix of spaces and tabs:
python-fiat.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line
1)
Please unify under one standard.
Assuming you fix Patch0001 to remove the .travis.yml bits, the package is
approved. Please also fix the aforementioned issue.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should
[Bug 1739798] Review Request: python-fiat - Generator of arbitrary order instances of Lagrange elements on lines, triangles, and tetrahedra
https://bugzilla.redhat.com/show_bug.cgi?id=1739798 --- Comment #2 from Robert-André Mauchin --- Okay I fixed Theanos and Sympy. Build still fails, the first patch is not applied: + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch The text leading up to this was: -- |diff --git a/.travis.yml b/.travis.yml |index 9d326af..5dba4cb 100644 |--- a/.travis.yml |+++ b/.travis.yml -- File to patch: Skip this patch? [y] 1 out of 1 hunk ignored RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.ftOfvv (%prep) Bad exit status from /var/tmp/rpm-tmp.ftOfvv (%prep) There's no .travis.yml in the archive so it can't be applied. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739798] Review Request: python-fiat - Generator of arbitrary order instances of Lagrange elements on lines, triangles, and tetrahedra
https://bugzilla.redhat.com/show_bug.cgi?id=1739798
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- You need to add the Python provide macro:
%package -n python3-fiat
Summary: %summary
%{?python_provide:%python_provide python3-fiat}
%description -n python3-fiat %_description
- Build error:
DEBUG util.py:600: Error:
DEBUG util.py:600: Problem: package python3-sympy-1.4-2.fc31.noarch requires
python(abi) = 3.7, but none of the providers can be installed
DEBUG util.py:600:- package python3-devel-3.8.0~b3-4.fc32.x86_64 conflicts
with python3 < 3.8.0~b3-4.fc32 provided by python3-3.7.4-5.fc31.i686
DEBUG util.py:600:- package python3-devel-3.8.0~b3-4.fc32.x86_64 conflicts
with python3 < 3.8.0~b3-4.fc32 provided by python3-3.7.4-5.fc31.x86_64
DEBUG util.py:600:- cannot install the best candidate for the job
DEBUG util.py:602: (try to add '--skip-broken' to skip uninstallable packages
or '--nobest' to use not only best candidate packages)
python3-sympy needs python-theanos which is FTBFS.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
