[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059 Benson Muite changed: What|Removed |Added Blocks||2235055 (scancode-toolkit) CC||zebo...@gmail.com --- Comment #16 from Benson Muite --- *** Bug 2235069 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2235055 [Bug 2235055] Review Request: scancode-toolkit - Scan code and detect licenses, copyrights, and more. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1748059 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%201748059%23c16 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059 --- Comment #15 from Fedora Update System --- python-boolean.py-3.6-1.fc31, python-license-expression-0.999-1.fc31, reuse-0.5.0-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-09-16 01:10:18 --- Comment #14 from Fedora Update System --- python-license-expression-0.999-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059 --- Comment #13 from Fedora Update System --- python-license-expression-0.999-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fcbc111ef -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- python-boolean.py-3.6-1.fc31, python-license-expression-0.999-1.fc31, reuse-0.5.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-0c78f33af2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059 --- Comment #10 from Fedora Update System --- FEDORA-2019-0c78f33af2 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-0c78f33af2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059 --- Comment #11 from Fedora Update System --- FEDORA-2019-0c78f33af2 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-0c78f33af2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #9 from Fedora Update System --- FEDORA-2019-7fcbc111ef has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fcbc111ef -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059 --- Comment #8 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-license-expression -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059 Elliott Sales de Andrade changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Elliott Sales de Andrade --- Thanks. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059 --- Comment #6 from Carmen Bianca Bakker --- Updated the spec and SRPM to include the removal of the egg-info and PKG-INFO. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059
--- Comment #5 from Elliott Sales de Andrade ---
> # Remove bundled egg-info
> rm -rf %{pypi_name}.egg-info
comes from pyp2rpm when you generate a spec. Usually PKG-INFO is in there so it
gets deleted as well. I'm not sure why pyp2rpm adds this, when it's not in the
guidelines, but I guess it does help avoid installing it (without proper
rebuild) accidentally.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059 --- Comment #4 from Carmen Bianca Bakker --- Ah, I was looking at the wrong directory. The file is indeed there, sorry. I don't believe other Fedora Python packages remove these files, though? I mean, it'd be trivial to do this, but if it should be done, I'd expect to see a note in the Python packaging guidelines given how common these files would be. I checked an arbitrary package like python-flask to be sure, and Flask's tarball also has these files, but the specfile doesn't remove them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059 --- Comment #3 from Elliott Sales de Andrade --- (In reply to Carmen Bianca Bakker from comment #2) > > - You should delete PKG-INFO and src/license_expression.egg-info in %prep. > > These files don't exist in the source tarball, and they aren't included > in the final RPM either. I'm not sure about this step. > They definitely do: $ tar tf license-expression-0.999.tar.gz | grep -i info license-expression-0.999/src/license_expression.egg-info/ license-expression-0.999/src/license_expression.egg-info/SOURCES.txt license-expression-0.999/PKG-INFO but it's true that PKG-INFO doesn't end up in the RPM (I think; there's a file with the same name somewhere else though). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059
--- Comment #2 from Carmen Bianca Bakker ---
> - You should delete PKG-INFO and src/license_expression.egg-info in %prep.
These files don't exist in the source tarball, and they aren't included
in the final RPM either. I'm not sure about this step.
> - Passing %{pypi_name} to %pypi_source is unnecessary.
> - `irc-notify.py` is GPLv2+, but not installed. Please add a note above the
> License so others aren't confused by it.
> - `Requires: %{py3_dist boolean.py}` is unnecessary and redundant with
> automatic
> Provides/Requires.
Done x3. Spec and SRPM updated. Thanks :-)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1748059
Elliott Sales de Andrade changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||quantum.anal...@gmail.com
Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
Flags||fedora-review?
--- Comment #1 from Elliott Sales de Andrade ---
- You should delete PKG-INFO and src/license_expression.egg-info in %prep.
- Passing %{pypi_name} to %pypi_source is unnecessary.
- `irc-notify.py` is GPLv2+, but not installed. Please add a note above the
License so others aren't confused by it.
- `Requires: %{py3_dist boolean.py}` is unnecessary and redundant with
automatic
Provides/Requires.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Apache License (v2.0)", "*No
copyright* Apache License", "*No copyright* Apache License (v2.0)",
"GPL (v2 or later)", "*No copyright* GPL (v2 or later)". 16 files have
unknown license. Detailed output of licensecheck in
1748059-python-license-expression/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s)
