[Bug 1751660] Review Request: python-casttube - A library to support complex camera ISPs
https://bugzilla.redhat.com/show_bug.cgi?id=1751660 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Robert-André Mauchin --- > Because koji doesn't have connectivity to the internet, it is useful for > local use though. Add a comment saying so above the flag. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1751660] Review Request: python-casttube - A library to support complex camera ISPs
https://bugzilla.redhat.com/show_bug.cgi?id=1751660 --- Comment #3 from Peter Robinson --- SPEC: https://pbrobinson.fedorapeople.org/python-casttube.spec SRPM: https://pbrobinson.fedorapeople.org/python-casttube-0.2.0-2.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1751660] Review Request: python-casttube - A library to support complex camera ISPs
https://bugzilla.redhat.com/show_bug.cgi?id=1751660
--- Comment #2 from Peter Robinson ---
(In reply to Robert-André Mauchin from comment #1)
> - %global with_tests 0
>
> Use bcond_with/bcond_without
>
> Also why tests are disabled? If there is no tests drop the entire %check
> section.
Because koji doesn't have connectivity to the internet, it is useful for local
use though.
> - Use:
>
> Source0:
> https://github.com/ur1katz/casttube/archive/%{version}/%{pypi_name}-
> %{version}.tar.gz
Updated.
> - It is verbotten to glob the entire Python sitelib, be more precise
> instead:
What does verbotten mean? I figure it means forbidden. If so updated.
> %{python3_sitelib}/casttube
> %{python3_sitelib}/casttube-%{version}-py*.egg-info
>
>
> See
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
> #_files_to_include
>
> - Summary is coo long and should not repeat the app name:
>
> Summary:Python library to interact with the Youtube Chromecast api
>
> - Description is too long, split it to stbay under 80 characters per line:
>
> python3-casttube.noarch: E: description-line-too-long C Casttube is a python
> library which a way to interact with the Youtube Chromecast api.
Updated.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1751660] Review Request: python-casttube - A library to support complex camera ISPs
https://bugzilla.redhat.com/show_bug.cgi?id=1751660
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- %global with_tests 0
Use bcond_with/bcond_without
Also why tests are disabled? If there is no tests drop the entire %check
section.
- Use:
Source0:
https://github.com/ur1katz/casttube/archive/%{version}/%{pypi_name}-%{version}.tar.gz
- It is verbotten to glob the entire Python sitelib, be more precise instead:
%{python3_sitelib}/casttube
%{python3_sitelib}/casttube-%{version}-py*.egg-info
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_files_to_include
- Summary is coo long and should not repeat the app name:
Summary:Python library to interact with the Youtube Chromecast api
- Description is too long, split it to stbay under 80 characters per line:
python3-casttube.noarch: E: description-line-too-long C Casttube is a python
library which a way to interact with the Youtube Chromecast api.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
Note: Package contains %{pythonX_site(lib|arch)}/* in %files
See: https://pagure.io/packaging-committee/issue/782
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Expat License", "Unknown or generated". 5 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/python-casttube/review-python-
casttube/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg
[Bug 1751660] Review Request: python-casttube - A library to support complex camera ISPs
https://bugzilla.redhat.com/show_bug.cgi?id=1751660 Peter Robinson changed: What|Removed |Added Blocks||1716247 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1716247 [Bug 1716247] pychromecast uninstallable due to missing casttube -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
