[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||python-pytest-harvest-1.7.2 ||-1.fc32 Resolution|--- |RAWHIDE Last Closed||2019-10-14 20:44:59 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 --- Comment #12 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-harvest -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 Raphael Groner changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #11 from Raphael Groner --- Thanks for explanation. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 --- Comment #10 from Zbigniew Jędrzejewski-Szmek --- Hi, this package uses the new pyproject macros [https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/LB3GTGGWEKBT2QWOB77XQ3WXEWN4XRUK/]. > - Package contains BR: python2-devel or python3-devel That is not needed, "BuildRequires: pyproject-rpm-macros" pulls in the necessary deps. > [?]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > => Please explain why you use BSD. https://pypi.org/project/pytest-harvest/ shows License: BSD License (BSD 3-Clause), as does https://github.com/smarie/python-pytest-harvest/blob/master/LICENSE. > [!]: License field in the package spec file matches the actual license. > Note: There is no build directory. Running licensecheck on vanilla > upstream sources. No licenses found. Please check the source files for > licenses manually. > => Empty licensecheck.txt generated, why? Some problem with fedora-review maybe? Nothing I can fix. > [!]: A package which is used by another package via an egg interface should > provide egg info. The binary package provides this: /usr/lib/python3.7/site-packages/pytest_harvest-1.7.2.dist-info/ > [!]: Package meets the Packaging Guidelines::Python It does, afaict. It's using the new macros to automate this, but the end result should be correct according to the guidelines. > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. The source tarball includes "LICENSE", and this file is also present in the binary rpm. (In reply to Raphael Groner from comment #9) > > [?]: Binary eggs must be removed in %prep > > Note: Cannot find any build in BUILD directory (--prebuilt option?) > > Maybe better try to build from source instead of using pypi provides > binaries only. It is built from source. It is a pure-python package, so "source" and "binary" are pretty much the same, but fwiw, it is built from a "source" tarball downloaded from pypi (as most python packages are...). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 --- Comment #9 from Raphael Groner --- > [?]: Binary eggs must be removed in %prep > Note: Cannot find any build in BUILD directory (--prebuilt option?) Maybe better try to build from source instead of using pypi provides binaries only. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196
--- Comment #8 from Raphael Groner ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package contains BR: python2-devel or python3-devel
= MUST items =
Generic:
[?]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
=> Please explain why you use BSD.
[!]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
=> Empty licensecheck.txt generated, why?
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[?]: Requires correct, justified where necessary.
=> See issue about python version.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[?]: Binary eggs must be removed in %prep
Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
process.
[!]: A package which is used by another package via an egg interface should
provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[?]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[?]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 --- Comment #7 from Raphael Groner --- Sorry for the delay. f-r is running currently and I'll returm with new results asap. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 --- Comment #6 from Zbigniew Jędrzejewski-Szmek --- I'd be grateful for a quick review. This is blocking a bunch of other packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Whiteboard|FTBFS | --- Comment #5 from Zbigniew Jędrzejewski-Szmek --- New version: - updated version to 1.7.2 (this is essentially just moving the patches that were already applied in the rpm into the master branch.) - fixed tests (https://github.com/smarie/python-pytest-harvest/pull/27) Spec URL: https://in.waw.pl/~zbyszek/fedora/python-pytest-harvest.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/python-pytest-harvest-1.7.2-1.fc32.src.rpm successful koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=38066818 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 Bug 1752196 depends on bug 1739786, which changed state. Bug 1739786 Summary: Review Request: python-makefun - Dynamically create python functions with a proper signature https://bugzilla.redhat.com/show_bug.cgi?id=1739786 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Depends On||1739786 (python-makefun) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1739786 [Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 --- Comment #4 from Zbigniew Jędrzejewski-Szmek --- Yep, it seems this needs the latest mock to be deployed in infra. It's supposed to happen soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196
Raphael Groner changed:
What|Removed |Added
Whiteboard||FTBFS
--- Comment #3 from Raphael Groner ---
FTBFS
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=37673990
Processing /builddir/build/BUILD/pytest-harvest-1.7.1
Created temporary directory: /tmp/pip-req-build-df6cpr3q
Added file:///builddir/build/BUILD/pytest-harvest-1.7.1 to build tracker
'/tmp/pip-req-tracker-mgpz8ptg'
Preparing wheel metadata: started
BUILDSTDERR: Running command /usr/bin/python3
/usr/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py
prepare_metadata_for_build_wheel /tmp/tmp45fn8bcq
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR: File "setup.py", line 22, in
BUILDSTDERR: from setuptools_scm import get_version
BUILDSTDERR: ModuleNotFoundError: No module named 'setuptools_scm'
BUILDSTDERR: The above exception was the direct cause of the following
exception:
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR: File
"/usr/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 207,
in
BUILDSTDERR: main()
BUILDSTDERR: File
"/usr/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 197,
in main
BUILDSTDERR: json_out['return_val'] = hook(**hook_input['kwargs'])
BUILDSTDERR: File
"/usr/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 69,
in prepare_metadata_for_build_wheel
BUILDSTDERR: return hook(metadata_directory, config_settings)
BUILDSTDERR: File
"/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 156, in
prepare_metadata_for_build_wheel
BUILDSTDERR: self.run_setup()
BUILDSTDERR: File
"/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 142, in
run_setup
BUILDSTDERR: exec(compile(code, __file__, 'exec'), locals())
BUILDSTDERR: File "setup.py", line 24, in
BUILDSTDERR: raise_from(Exception("Required packages for setup not
found. Please install 'setuptools_scm'"), e)
BUILDSTDERR: File "", line 3, in raise_from
BUILDSTDERR: Exception: Required packages for setup not found. Please
install 'setuptools_scm'
:
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 Raphael Groner changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 --- Comment #2 from Raphael Groner --- Review swap maybe with bug #1709037. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 Raphael Groner changed: What|Removed |Added Status|NEW |ASSIGNED CC||projects...@smart.ms Assignee|nob...@fedoraproject.org|projects...@smart.ms --- Comment #1 from Raphael Groner --- Are you interested in a review swap? Maybe take a look into bug #1752210. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Blocks||1739793 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1739793 [Bug 1739793] Review Request: python-pytest-steps - Create step-wise / incremental tests in pytest -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
