[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 --- Comment #16 from Fedora Update System --- octave-jnifti-0.5-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #14 from Fedora Update System --- octave-jnifti-0.5-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 --- Comment #13 from Fedora Update System --- octave-jnifti-0.5-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7dc70a0156 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 --- Comment #12 from Fedora Update System --- octave-jnifti-0.5-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7965616639 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 --- Comment #11 from Fedora Update System --- octave-jnifti-0.5-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-24b37b0c7f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 --- Comment #10 from Fedora Update System --- FEDORA-2019-24b37b0c7f has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-24b37b0c7f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 --- Comment #9 from Fedora Update System --- FEDORA-2019-7965616639 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7965616639 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 --- Comment #8 from Fedora Update System --- FEDORA-2019-7dc70a0156 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7dc70a0156 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 Qianqian Fang changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-10-08 21:03:40 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/octave-jnifti -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #6 from Robert-André Mauchin --- (In reply to Qianqian Fang from comment #5) > to make it easier to manage, I created a sub-package (jnifti-demos) from > this spec file > > https://github.com/fangq/fedorapkg/commit/ > becd6b47956128267e30ae839d05e45b8d449a27 > > the current spec file can be found here > > https://github.com/fangq/fedorapkg/blob/jnifti/octave-jnifti.spec > > let me know if this is acceptable. it compiles fine on fc30 (this package is > script/data only). thanks Make the subpackage noarch. Package otherwise approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 --- Comment #5 from Qianqian Fang --- to make it easier to manage, I created a sub-package (jnifti-demos) from this spec file https://github.com/fangq/fedorapkg/commit/becd6b47956128267e30ae839d05e45b8d449a27 the current spec file can be found here https://github.com/fangq/fedorapkg/blob/jnifti/octave-jnifti.spec let me know if this is acceptable. it compiles fine on fc30 (this package is script/data only). thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 --- Comment #4 from Robert-André Mauchin --- > about the doc subpackage, do you have a sample octave-based project that has > a similar structure - a main package with a doc subpackage? No > I should avoid sharing the doc folder by both packages (should I make all > %doc files/folders into the -doc package? Just include the %doc sample into a new doc subpackage, and remove it from the main one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 --- Comment #3 from Qianqian Fang --- thanks. my spec file is now updated https://github.com/fangq/fedorapkg/commit/79d761bc34266a207c482719ef4e996c2f052407 about the doc subpackage, do you have a sample octave-based project that has a similar structure - a main package with a doc subpackage? I know I can use %package to make subpackages, but not sure if I should avoid sharing the doc folder by both packages (should I make all %doc files/folders into the -doc package?) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #2 from Robert-André Mauchin ---
- Missing BR to octave-devel
BuildRequires: octave-devel
- Do not repeat JNIfTI in the Summary:
- Use a better name for your archive:
Source0:
https://github.com/fangq/%{octpkg}/archive/v%{version}/%{name}-%{version}.tar.gz
- Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 11714560 bytes in 19 files.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_documentation
Make a separate doc noarch subpackage.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 11714560 bytes in 19 files.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_documentation
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v3 or later)", "Unknown or generated", "*No copyright*
Apache License (v2.0)", "Apache License (v2.0)". 32 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/octave-jnifti/review-octave-
jnifti/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 Ankur Sinha (FranciscoD) changed: What|Removed |Added Blocks||1276941 (fedora-neuro) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 --- Comment #1 from Qianqian Fang --- rpmlint output for srpm: -- fangq@localhost:~/rpmbuild/SRPMS$ rpmlint octave-jnifti-0.5-1.fc30.src.rpm octave-jnifti.src: W: spelling-error %description -l en_US nii -> ii, iii, nit octave-jnifti.src: W: spelling-error %description -l en_US gz -> g, z, gs octave-jnifti.src: W: spelling-error %description -l en_US hdr -> hr, her, HDD octave-jnifti.src: W: spelling-error %description -l en_US img -> mg, imp, i mg octave-jnifti.src: W: spelling-error %description -l en_US jnii -> genii octave-jnifti.src: W: spelling-error %description -l en_US bnii -> bani 1 packages and 0 specfiles checked; 0 errors, 6 warnings. -- rpmlint output for rpm: -- fangq@localhost:~/rpmbuild/RPMS/noarch$ rpmlint octave-jnifti-0.5-1.fc30.noarch.rpm octave-jnifti.noarch: W: spelling-error %description -l en_US nii -> ii, iii, nit octave-jnifti.noarch: W: spelling-error %description -l en_US gz -> g, z, gs octave-jnifti.noarch: W: spelling-error %description -l en_US hdr -> hr, her, HDD octave-jnifti.noarch: W: spelling-error %description -l en_US img -> mg, imp, i mg octave-jnifti.noarch: W: spelling-error %description -l en_US jnii -> genii octave-jnifti.noarch: W: spelling-error %description -l en_US bnii -> bani octave-jnifti.noarch: W: file-not-utf8 /usr/share/doc/octave-jnifti/samples/nifti2/avg152T1_LR_nifti2.nii.gz octave-jnifti.noarch: W: dangerous-command-in-%preun mv 1 packages and 0 specfiles checked; 0 errors, 8 warnings. -- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
