[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036 Elliott Sales de Andrade changed: What|Removed |Added Status|POST|CLOSED CC||quantum.anal...@gmail.com Fixed In Version||sentencepiece-0.1.83-1.fc32 Resolution|--- |RAWHIDE Last Closed||2020-08-03 00:34:18 --- Comment #12 from Elliott Sales de Andrade --- Please close your Review Requests when they are complete. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036 --- Comment #11 from Kentaro Hayashi --- (In reply to Robert-André Mauchin from comment #9) > I don't know tbh, please ask on the devel mailing list about your error. > Please double-check the API key? Did you correctly go to > https://pagure.io/settings#nav-api-tab and not src.fedoraproject.org ? Thanks, that's it! It's a API key issue.(It's my mistake) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sentencepiece -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Robert-André Mauchin --- I don't know tbh, please ask on the devel mailing list about your error. Please double-check the API key? Did you correctly go to https://pagure.io/settings#nav-api-tab and not src.fedoraproject.org ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036 Kentaro Hayashi changed: What|Removed |Added Flags|fedora-review+ |fedora-review? --- Comment #8 from Kentaro Hayashi --- Because of sentence piece package is approved, I've tried to request fedpkg request-repo [1], but it was failed. Here is the error log: $ fedpkg request-repo sentencepiece 1758036 Could not execute request_repo: The following error occurred while creating a new issue in Pagure: Invalid or expired token. Please visit https://pagure.io/settings#nav-api-tab to get or renew your API token. For invalid or expired token refer to "fedpkg request-repo -h" to set a token in your user configuration. Before requesting fedpkg request-repo, I've set up ~/config/rpkg/fedpkg.conf (fedpkg request-repo -h explains about pague API token) Even though full ACLs are checked (Fork a project,Modify an existing project,Comment on a pull-request,Open a new pull-request,Merge a pull-request,Update the watch status on a project), fedpkg request-repo fails. What am I missing to do next steps? [1] https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #7 from Robert-André Mauchin --- LGTM, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036
--- Comment #6 from Kentaro Hayashi ---
Thank you for reviewing.
I've updated spec.
Spec URL: https://packages.groonga.org/tmp/sentencepiece/sentencepiece.spec
SRPM URL:
https://packages.groonga.org/tmp/sentencepiece/sentencepiece-0.1.83-1.fc30.src.rpm
Description: unsupervised text tokenizer for Neural Network-based text
generation
(In reply to Robert-André Mauchin from comment #5)
> - You must include the python provide macros *for your Python package*:
>
> %package-n python3-%{name}
> Summary: Python module for SentencePiece
> %{?python_provide:%python_provide python3-%{name}}
>
> See
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
> #_the_python_provide_macro
>
I've fixed to define macro correctly.
> You should not include it in the main package.
>
> - Also use Fedora build flags:: cmake3 . -DCMAKE_INSTALL_PREFIX=%{_prefix}
> -DCMAKE_INSTALL_LIBDIR=%{_libdir} → %cmake3 .
> -DCMAKE_INSTALL_LIBDIR=%{_libdir}
I've fixed to use %cmake macro instead.
* Fixed to
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036
--- Comment #5 from Robert-André Mauchin ---
- You must include the python provide macros *for your Python package*:
%package-n python3-%{name}
Summary:Python module for SentencePiece
%{?python_provide:%python_provide python3-%{name}}
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_python_provide_macro
You should not include it in the main package.
- Also use Fedora build flags:: cmake3 . -DCMAKE_INSTALL_PREFIX=%{_prefix}
-DCMAKE_INSTALL_LIBDIR=%{_libdir} → %cmake3 . -DCMAKE_INSTALL_LIBDIR=%{_libdir}
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Apache License (v2.0)", "*No
copyright* Apache License (v2.0)", "BSD 3-clause "New" or "Revised"
License", "Expat License". 61 files have unknown license. Detailed
output of licensecheck in
/home/bob/packaging/review/sentencepiece/review-
sentencepiece/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[!]: Package meets the
[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036
--- Comment #4 from Kentaro Hayashi ---
Spec URL: https://packages.groonga.org/tmp/sentencepiece/sentencepiece.spec
SRPM URL:
https://packages.groonga.org/tmp/sentencepiece/sentencepiece-0.1.83-1.fc30.src.rpm
Description: unsupervised text tokenizer for Neural Network-based text
generation
Thank you for review I've fixed spec with feedback comments.
https://bugzilla.redhat.com/show_bug.cgi?id=1758036#c1
https://bugzilla.redhat.com/show_bug.cgi?id=1758036#c2
https://bugzilla.redhat.com/show_bug.cgi?id=1758036#c3
Here is the summary for updates.
* Removed unused Group
* Removed unused ldconfig scriptlet
* Removed needless %defattr, %clean
* Used %make_install, %make_build, %license
* Used %python_provide
* Fixed /usr to %{_prefix}
* Fixed to use -delete in find
* Fixed to unintentional soname bump (less globbing in %files)
* Fixed %description, add missing . in end of sentences
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036
--- Comment #3 from Robert-André Mauchin ---
- In order to avoid unintentional soname bump we forbud globbing the major
soname version, be more specific instead:
%{_libdir}/*.so.*
- Add dots at the end of your description sentences.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036 --- Comment #2 from Robert-André Mauchin --- - Also not ok: Provides: python3dist(sentencepiece) The python3dist macro is computed automatically for you Py3 subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
Blocks|177841 (FE-NEEDSPONSOR) |
--- Comment #1 from Robert-André Mauchin ---
- Group: is not used in Fedorba
- Not used since Fedora 28:
Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig
%post libs -p /sbin/ldconfig
%postun libs -p /sbin/ldconfig
- Not needed:
%defattr(-,root,root,-)
- make %{?_smp_mflags} → %make_build
- make install → %make_install
- find %{buildroot} -name '*.a' | xargs rm -f {}\; → find %{buildroot} -name
'*.a' -delete
- Not needed:
%clean
- You must install the license file with %license not %doc
%files libs
%doc README.md
%license LICENSE
- You must include the python provide macros for your Python package:
%package-n python3-%{name}
Summary:Python module for SentencePiece
%{?python_provide:%python_provide python3-%{name}}
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_python_provide_macro
- -DCMAKE_INSTALL_PREFIX=%{buildroot}/usr →
-DCMAKE_INSTALL_PREFIX=%{buildroot}%{_prefix}
You are already a member of the packager group, thus you don't need a sponsor.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036 Kentaro Hayashi changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
