[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database
https://bugzilla.redhat.com/show_bug.cgi?id=1758929 --- Comment #14 from Fedora Update System --- perl-WebService-MusicBrainz-1.0.5-3.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database
https://bugzilla.redhat.com/show_bug.cgi?id=1758929 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-10-18 00:48:22 --- Comment #12 from Fedora Update System --- perl-WebService-MusicBrainz-1.0.5-3.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database
https://bugzilla.redhat.com/show_bug.cgi?id=1758929 --- Comment #11 from Fedora Update System --- perl-WebService-MusicBrainz-1.0.5-3.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-68d69acb8d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database
https://bugzilla.redhat.com/show_bug.cgi?id=1758929 --- Comment #10 from Fedora Update System --- perl-WebService-MusicBrainz-1.0.5-3.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c43a59039d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database
https://bugzilla.redhat.com/show_bug.cgi?id=1758929 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- perl-WebService-MusicBrainz-1.0.5-3.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-63cd1d0d46 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database
https://bugzilla.redhat.com/show_bug.cgi?id=1758929 --- Comment #8 from Fedora Update System --- FEDORA-2019-68d69acb8d has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-68d69acb8d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database
https://bugzilla.redhat.com/show_bug.cgi?id=1758929 --- Comment #7 from Fedora Update System --- FEDORA-2019-c43a59039d has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c43a59039d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database
https://bugzilla.redhat.com/show_bug.cgi?id=1758929 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2019-63cd1d0d46 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-63cd1d0d46 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database
https://bugzilla.redhat.com/show_bug.cgi?id=1758929 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-WebService-MusicBrainz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database
https://bugzilla.redhat.com/show_bug.cgi?id=1758929
Dominik 'Rathann' Mierzejewski changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Dominik 'Rathann' Mierzejewski ---
Rpmlint
---
Checking: perl-WebService-MusicBrainz-1.0.5-2.fc32.noarch.rpm
perl-WebService-MusicBrainz-1.0.5-2.fc32.src.rpm
perl-WebService-MusicBrainz.noarch: W: invalid-license Artistic
perl-WebService-MusicBrainz.src: W: invalid-license Artistic
perl-WebService-MusicBrainz.src:10: W: mixed-use-of-spaces-and-tabs (spaces:
line 3, tab: line 10)
perl-WebService-MusicBrainz.src: E: specfile-error warning: bogus date in
%changelog: Mon Oct 06 2019 Gerald Cox - 1.0.5-2
2 packages and 0 specfiles checked; 1 errors, 3 warnings.
-> Please fix mixed spaces and tabs and bogus date in changelog.
Rpmlint (installed packages)
perl-WebService-MusicBrainz.noarch: W: description-shorter-than-summary
perl-WebService-MusicBrainz.noarch: W: invalid-license Artistic
perl-WebService-MusicBrainz.noarch: W: invalid-url URL:
https://metacpan.org/release/WebService-MusicBrainz
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
-> Could you change the %description to:
This module will search the MusicBrainz database through their web service and
return objects with the found data.
I would also make the files list a bit more specific:
%files
%doc Changes README.md
%{_mandir}/man3/WebService::MusicBrainz*.3pm*
%{perl_vendorlib}/WebService
The above can be fixed while importing. The rest is fine, so package is
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database
https://bugzilla.redhat.com/show_bug.cgi?id=1758929 --- Comment #3 from Gerald Cox --- Requested license text be included with source files: https://rt.cpan.org/Public/Bug/Display.html?id=130671 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database
https://bugzilla.redhat.com/show_bug.cgi?id=1758929 --- Comment #2 from Gerald Cox --- Thanks for the quick review. I made the requested changes and they are here: https://drive.google.com/open?id=1QIDIZSvnK0vT_1dsH2A4DGXsJ_kwZARs https://drive.google.com/open?id=1hfB_UdW3RRCcjuNakjO1JmLPOqNlyMG_ I also, built on COPR so you can use that copy if you prefer: https://copr.fedorainfracloud.org/coprs/gbcox/package_reviews/build/1049812/ Thanks again! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database
https://bugzilla.redhat.com/show_bug.cgi?id=1758929
Dominik 'Rathann' Mierzejewski changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|domi...@greysector.net
Flags||fedora-review?
--- Comment #1 from Dominik 'Rathann' Mierzejewski ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
1. Package contains no binaries and should be noarch.
2. License is the same as Perl itself, so License: GPL+ or Artistic should be
used per https://fedoraproject.org/wiki/Licensing:Main .
3. Please ask upstream to include license text(s) with the sources.
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[!]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 14 files
have unknown license. Detailed output of licensecheck in
/home/rathann/build/review/copr-build-1049238/review-perl-WebService-
MusicBrainz/licensecheck.txt
[-]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[x]: CPAN urls should be non-versioned.
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes
[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database
https://bugzilla.redhat.com/show_bug.cgi?id=1758929 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added Blocks||1758816 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1758816 [Bug 1758816] RFE: MusicBrainz lookup support for abcde -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
