[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 --- Comment #22 from Fedora Update System --- python-editdistance-0.5.3-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-12-01 00:45:58 --- Comment #21 from Fedora Update System --- python-editdistance-0.5.3-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 --- Comment #20 from Fedora Update System --- python-editdistance-0.5.3-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-67c38ce04a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 --- Comment #19 from Fedora Update System --- python-editdistance-0.5.3-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-297ad7f39c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System --- python-editdistance-0.5.3-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-6f8dee4c59 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #17 from Fedora Update System --- FEDORA-2019-297ad7f39c has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-297ad7f39c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 --- Comment #16 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-editdistance -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1765265 CC||ego.corda...@gmail.com --- Comment #15 from Elliott Sales de Andrade --- *** Bug 1771215 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1765265 [Bug 1765265] Review Request: python-identify - File identification library for Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297
Elliott Sales de Andrade changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #14 from Elliott Sales de Andrade ---
Approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Binary eggs must be removed in %prep
Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 --- Comment #13 from Aniket Pradhan --- Bumping the review. I hope spec and the srpm files are fine. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 --- Comment #12 from Aniket Pradhan --- Hello Elliott. I had done that in a hurry :P Anyways, I can see that only the file bypython.cpp is being generated through Cython, and it is not happening through setup.py (it is building editdistance.bycython through setup.py. So, I had to manually run `cythonize ...` in order to compile the cpp file. Also, _editdistance.cpp is not being generated through Cython, hence there is no point deleting it. I have updated the spec and the srpm in the above mentioned urls. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297
--- Comment #11 from Elliott Sales de Andrade ---
> find %{pypi_name}/ -name "*.c" -print -delete
This is not quite right, because the files are named *.cpp.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 --- Comment #10 from Aniket Pradhan --- Thank you for the review, Elliot. I have made the requested changes and have updated the source files (spec and srpm) in the fedorapeople workspace. The links to the files are as follows: spec: https://major.fedorapeople.org/python-editdistance/python-editdistance.spec srpm: https://major.fedorapeople.org/python-editdistance/python-editdistance-0.5.3-1.fc31.src.rpm The links are the same as the ones posted above. I am although unsure why the difference in the URL is coming up. I have generated the srpm using `rpmbuild -bs python-editdistance.spec`. I don't think it should be any different from the one created during the build procedure. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297
Elliott Sales de Andrade changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
Flags||fedora-review?
--- Comment #9 from Elliott Sales de Andrade ---
Summary is too long; "in Python" is redundant since it's in the package name,
and you can drop "A ".
The description says C++ and Cython, but you don't BR python3-Cython, and
rebuild Cython sources, which is required:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_packages_using_cython
You must own %{python3_sitearch}/%{pypi_name} and
%{python3_sitearch}/%{pypi_name}/__pycache__
Make sure to update both spec and srpm.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib64/python3.8/site-
packages/editdistance/__pycache__, /usr/lib64/python3.8/site-
packages/editdistance
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/python3.8/site-
packages/editdistance, /usr/lib64/python3.8/site-
packages/editdistance/__pycache__
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]:
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297
--- Comment #8 from Aniket Pradhan ---
Thanks a lot, Elliott!
I set the PATH to point to %{buildroot}%{python3_sitearch} where the package is
installed, and the tests now pass successfully [1]. I also shifted from nose to
pytest. I hope there are no problems now. :D
[1]: https://koji.fedoraproject.org/koji/taskinfo?taskID=38841256
P.S. I have updated the spec and the SRPM on the above-mentioned URLs.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297
Elliott Sales de Andrade changed:
What|Removed |Added
CC||quantum.anal...@gmail.com
--- Comment #7 from Elliott Sales de Andrade ---
(In reply to Aniket Pradhan from comment #4)
> %{__python3} setup.py test copies some the python module (.so) file to the
> source directory.
You don't usually need to do that; set PYTHONPATH and/or PATH to point to the
%{buildroot} correctly, and it should work with the one you just built.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 --- Comment #6 from Aniket Pradhan --- (In reply to Aniket Pradhan from comment #5) > (In reply to Ankur Sinha (FranciscoD) from comment #2) > > Aniket, please block "fedora-neuro" for all NeuroFedora related bugs---also > > helps us keep track of our stuff. > > What do you mean by "blocking fedora-neuro"? Is it adding the neuro sig to > the cc-list, then I had done that already. No worries, I got what you were referring to. :P -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 --- Comment #5 from Aniket Pradhan --- (In reply to Ankur Sinha (FranciscoD) from comment #2) > Aniket, please block "fedora-neuro" for all NeuroFedora related bugs---also > helps us keep track of our stuff. What do you mean by "blocking fedora-neuro"? Is it adding the neuro sig to the cc-list, then I had done that already. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297
--- Comment #4 from Aniket Pradhan ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> Splitting out the -devel subpackages seems bogus. The .so file is just the
> python module.
> Also, your -devel package is not installable.
>
> Merge the -devel package back into the python3- package.
> Those .h files can be %excluded, they are not used at runtime.
Yeah... I did that because of the header file warning. I was not sure if they
are used during the runtime. I'll exclude them if that is the case.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> I forgot to add:
> > %{__python3} setup.py test
> > nosetests test
>
> Why two calls? This second line could run with the wrong python versions on
> F<32.
%{__python3} setup.py test copies some the python module (.so) file to the
source directory. It also doesn't run the tests. If I don't run this, the tests
using nose fails. Hence I had added the two statements.
Sure, you are right. I should use nosetests-3 to run the test.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297
--- Comment #3 from Zbigniew Jędrzejewski-Szmek ---
I forgot to add:
> %{__python3} setup.py test
> nosetests test
Why two calls? This second line could run with the wrong python versions on
F<32.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 Ankur Sinha (FranciscoD) changed: What|Removed |Added CC||sanjay.an...@gmail.com Blocks||1276941 (fedora-neuro) --- Comment #2 from Ankur Sinha (FranciscoD) --- Aniket, please block "fedora-neuro" for all NeuroFedora related bugs---also helps us keep track of our stuff. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC||zbys...@in.waw.pl --- Comment #1 from Zbigniew Jędrzejewski-Szmek --- Splitting out the -devel subpackages seems bogus. The .so file is just the python module. Also, your -devel package is not installable. Merge the -devel package back into the python3- package. Those .h files can be %excluded, they are not used at runtime. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
