[Bug 1796711] Review Request: python-readthedocs-sphinx-ext - Sphinx extension for Read the Docs overrides
https://bugzilla.redhat.com/show_bug.cgi?id=1796711 --- Comment #9 from Jerry James --- (In reply to Miro Hrončok from comment #5) > Here I come, summoned by my name being spoken. Kibo is back! Thanks for the explanations, Miro and Petr. I feel enlightened. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796711] Review Request: python-readthedocs-sphinx-ext - Sphinx extension for Read the Docs overrides
https://bugzilla.redhat.com/show_bug.cgi?id=1796711 --- Comment #8 from Miro Hrončok --- Ha! We should fallback to setuptools.build_meta:__legacy__, not just setuptools.build_meta. https://src.fedoraproject.org/rpms/pyproject-rpm-macros/pull-request/29 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796711] Review Request: python-readthedocs-sphinx-ext - Sphinx extension for Read the Docs overrides
https://bugzilla.redhat.com/show_bug.cgi?id=1796711 Petr Viktorin changed: What|Removed |Added CC||pvikt...@redhat.com --- Comment #7 from Petr Viktorin --- > The pyproject.toml file specifies a build backend. For easier adoption, we > select "setuptools.build_meta" build backend when the pyproject.toml file is > not present or it is oresent but the backend is not specified. Note that this is standard behavior, not something Fedora-specific. See https://www.python.org/dev/peps/pep-0517/: > If the pyproject.toml file is absent, or the build-backend key is missing, > the source tree is not using this specification, and tools should revert to > the legacy behaviour of running setup.py (either directly, or by implicitly > invoking the setuptools.build_meta:__legacy__ backend). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796711] Review Request: python-readthedocs-sphinx-ext - Sphinx extension for Read the Docs overrides
https://bugzilla.redhat.com/show_bug.cgi?id=1796711 --- Comment #6 from Miro Hrončok --- I've also opened https://src.fedoraproject.org/rpms/python-readthedocs-sphinx-ext/pull-request/1 For https://github.com/readthedocs/readthedocs-sphinx-ext/issues/64 this is a bit messy, but once that is fixed upstream, it will be better. The idea was that when you use %pyproject_buildrequires -t, you already have tox, but OTOH from reading the specfile, you don't know you have pytest. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796711] Review Request: python-readthedocs-sphinx-ext - Sphinx extension for Read the Docs overrides
https://bugzilla.redhat.com/show_bug.cgi?id=1796711 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #5 from Miro Hrončok --- (In reply to Jerry James from comment #2) > Thanks for the review! > > (In reply to Sandro Mani from comment #1) > > (Curiosity: [1] states that the pyproject macros work if the project > > includes pyproject.toml, but the sources contain no such file. So how is > > this actually working?) > > I'm afraid I don't know the answer to that question myself, although I'm > sure Miro does. It looks like the commands invoked by the pyproject macros > must parse setup.py, since they find the requests and Jinja2 dependencies. > Either that or they invoke black magic. Possibly both. Here I come, summoned by my name being spoken. The pyproject.toml file specifies a build backend. For easier adoption, we select "setuptools.build_meta" build backend when the pyproject.toml file is not present or it is oresent but the backend is not specified. The "setuptools.build_meta" build backend is backwards compatible with setup.py files. For curiosity, see get_backend() in https://src.fedoraproject.org/rpms/pyproject-rpm-macros/blob/master/f/pyproject_buildrequires.py#_125 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796711] Review Request: python-readthedocs-sphinx-ext - Sphinx extension for Read the Docs overrides
https://bugzilla.redhat.com/show_bug.cgi?id=1796711 Jerry James changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-02-04 04:07:15 --- Comment #4 from Jerry James --- Built in Rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796711] Review Request: python-readthedocs-sphinx-ext - Sphinx extension for Read the Docs overrides
https://bugzilla.redhat.com/show_bug.cgi?id=1796711 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-readthedocs-sphinx-ext -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796711] Review Request: python-readthedocs-sphinx-ext - Sphinx extension for Read the Docs overrides
https://bugzilla.redhat.com/show_bug.cgi?id=1796711 --- Comment #2 from Jerry James --- Thanks for the review! (In reply to Sandro Mani from comment #1) > (Curiosity: [1] states that the pyproject macros work if the project > includes pyproject.toml, but the sources contain no such file. So how is > this actually working?) I'm afraid I don't know the answer to that question myself, although I'm sure Miro does. It looks like the commands invoked by the pyproject macros must parse setup.py, since they find the requests and Jinja2 dependencies. Either that or they invoke black magic. Possibly both. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796711] Review Request: python-readthedocs-sphinx-ext - Sphinx extension for Read the Docs overrides
https://bugzilla.redhat.com/show_bug.cgi?id=1796711
Sandro Mani changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #1 from Sandro Mani ---
Not terribly familiar with pyproject-rpm-macros, but it looks like it also
autogenerates BR: python3-devel, so the issue marked below is a non-issue.
Hence all good as far as I can see!
(Curiosity: [1] states that the pyproject macros work if the project includes
pyproject.toml, but the sources contain no such file. So how is this actually
working?)
[1]
https://src.fedoraproject.org/rpms/pyproject-rpm-macros/blob/master/f/README.md
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package contains BR: python2-devel or python3-devel
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified
[Bug 1796711] Review Request: python-readthedocs-sphinx-ext - Sphinx extension for Read the Docs overrides
https://bugzilla.redhat.com/show_bug.cgi?id=1796711 Sandro Mani changed: What|Removed |Added Status|NEW |ASSIGNED CC||manisan...@gmail.com Assignee|nob...@fedoraproject.org|manisan...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
