[Bug 1806018] Review Request: vernnobile-oswald-fonts - A reworked gothic style font family

2020-02-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1806018

Nicolas Mailhot  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2020-02-25 20:53:26



--- Comment #4 from Nicolas Mailhot  ---
Built for F32 (update) and F33

Thanks Parag and Gwyn

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1806018] Review Request: vernnobile-oswald-fonts - A reworked gothic style font family

2020-02-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1806018



--- Comment #3 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/vernnobile-oswald-fonts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1806018] Review Request: vernnobile-oswald-fonts - A reworked gothic style font family

2020-02-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1806018



--- Comment #2 from Nicolas Mailhot  ---
Fixed the warnings, thanks for the review!
https://pagure.io/releng/fedora-scm-requests/issue/22531

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1806018] Review Request: vernnobile-oswald-fonts - A reworked gothic style font family

2020-02-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1806018

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: vernnobile-oswald-fonts-4.101-1.20191208git5a5fff2.fc33.noarch.rpm
  vernnobile-oswald-fonts-4.101-1.20191208git5a5fff2.fc33.src.rpm
vernnobile-oswald-fonts.noarch: W: spelling-error Summary(en_US) gothic ->
Gothic, goths
vernnobile-oswald-fonts.noarch: W: spelling-error %description -l en_US gothic
-> Gothic, goths
vernnobile-oswald-fonts.noarch: W: spurious-executable-perm
/usr/share/doc/vernnobile-oswald-fonts/OFL.txt
vernnobile-oswald-fonts.noarch: E: wrong-script-end-of-line-encoding
/usr/share/doc/vernnobile-oswald-fonts/OFL.txt
vernnobile-oswald-fonts.src: W: spelling-error Summary(en_US) gothic -> Gothic,
goths
vernnobile-oswald-fonts.src: W: spelling-error %description -l en_US gothic ->
Gothic, goths
2 packages and 0 specfiles checked; 1 errors, 5 warnings.

Source checksums

https://github.com/googlefonts/OswaldFont/archive/5a5fff234687674f8531a8537455e626b08b3321/OswaldFont-5a5fff234687674f8531a8537455e626b08b3321.tar.gz
:
  CHECKSUM(SHA256) this package :
e6138d3982041ff3429e26e1814229826ad882b78cbb244a504ba19066c25b45
  CHECKSUM(SHA256) upstream package :
e6138d3982041ff3429e26e1814229826ad882b78cbb244a504ba19066c25b45


Requires

vernnobile-oswald-fonts (rpmlib, GLIBC filtered):
config(vernnobile-oswald-fonts)
fontpackages-filesystem



Provides

vernnobile-oswald-fonts:
config(vernnobile-oswald-fonts)
font(oswald)
font(oswaldextralight)
font(oswaldlight)
font(oswaldmedium)
font(oswaldsemibold)
metainfo()
metainfo(org.fedoraproject.vernnobile-oswald-fonts.metainfo.xml)
vernnobile-oswald-fonts


All other things like license, config, metainfo files looks good.


Issues:
1) Fix the rpmlint warnings/errors before import of this package.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1806018] Review Request: vernnobile-oswald-fonts - A reworked gothic style font family

2020-02-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1806018

Nicolas Mailhot  changed:

   What|Removed |Added

 CC||fonts-bugs@lists.fedoraproj
   ||ect.org
   Doc Type|--- |If docs needed, set a value



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org