[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860 --- Comment #15 from Fedora Update System --- FEDORA-2020-5eb0c28ee6 has been pushed to the Fedora 30 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860 --- Comment #14 from Fedora Update System --- FEDORA-2020-ddf4c8c827 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-03-24 01:48:27 --- Comment #13 from Fedora Update System --- FEDORA-2020-a4d894708a has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860 --- Comment #12 from Fedora Update System --- micropipenv-0.1.4-1.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ddf4c8c827 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860 --- Comment #11 from Fedora Update System --- micropipenv-0.1.4-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a4d894708a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- micropipenv-0.1.4-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-5eb0c28ee6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860 --- Comment #9 from Fedora Update System --- FEDORA-2020-a4d894708a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-a4d894708a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #8 from Fedora Update System --- FEDORA-2020-ddf4c8c827 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ddf4c8c827 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/micropipenv -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860 --- Comment #6 from Miro Hrončok --- Thanks for the fixes. Feel free to proceed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860
--- Comment #5 from Lumír Balhar ---
> > Requires: python3dist(pip)
> > Requires: python3dist(setuptools)
> > Requires: python3dist(toml)
>
> Why are those needed? Why are the automatic requires not working? There is
> an automatic requirement on setuptools, but not on pip or toml. Is the
> upstream metadata OK?
toml is defined in `extras_require` but pip is not defined anywhere. I'll
create an upstream issue.
>
> > %description
> > A lightweight wrapper for pip to support Pipenv and Poetry lock files or \
> > converting them to pip-tools compatible output.
>
> The backslash is a possible leftover form when description was defined via a
> macro.
Fixed.
> > # Remove bundled egg-info
> > rm -rf %{name}.egg-info
>
> Is this needed? Why?
Generated by pyp2rpm. Removed.
> > # Remove shebang line from the module
> > sed -i '1{\@^#!/usr/bin/env python@d}'
> > %{buildroot}/%{python3_sitelib}/%{name}.py
>
> Is it possible to do this in %prep? Or does that affect both the executable
> in %{_bindir} and this file?
Moved to %prep.
> > %{__python3} -m pytest
>
> The new proper way of doing this is to use %{python3} over %{__python3}.
Fixed.
> > %{python3_sitelib}/__pycache__/*
> > %{python3_sitelib}/%{name}.py
>
> You can use the new %pycached macro:
>
> %pycached %{python3_sitelib}/%{name}.py
Forgot about it. Fixed.
> > %{python3_sitelib}/%{name}-%{version}-py?.?.egg-info
>
> This will break with Python 3.10.
> Also, please use a trailing slash to ensure this is and remains a directory.
> See also problems with
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> Directory_Replacement/
regex changed, slash added
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860
Miro Hrončok changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|thrnc...@redhat.com
--- Comment #4 from Miro Hrončok ---
For the review: Before you do a review, always assign the bugzilla you
yourself. I've done that now.
For the spec sanity:
> Requires: python3dist(pip)
> Requires: python3dist(setuptools)
> Requires: python3dist(toml)
Why are those needed? Why are the automatic requires not working? There is an
automatic requirement on setuptools, but not on pip or toml. Is the upstream
metadata OK?
> %description
> A lightweight wrapper for pip to support Pipenv and Poetry lock files or \
> converting them to pip-tools compatible output.
The backslash is a possible leftover form when description was defined via a
macro.
> # Remove bundled egg-info
> rm -rf %{name}.egg-info
Is this needed? Why?
> # Remove shebang line from the module
> sed -i '1{\@^#!/usr/bin/env python@d}'
> %{buildroot}/%{python3_sitelib}/%{name}.py
Is it possible to do this in %prep? Or does that affect both the executable in
%{_bindir} and this file?
> %{__python3} -m pytest
The new proper way of doing this is to use %{python3} over %{__python3}.
> %{python3_sitelib}/__pycache__/*
> %{python3_sitelib}/%{name}.py
You can use the new %pycached macro:
%pycached %{python3_sitelib}/%{name}.py
> %{python3_sitelib}/%{name}-%{version}-py?.?.egg-info
This will break with Python 3.10.
Also, please use a trailing slash to ensure this is and remains a directory.
See also problems with
https://docs.fedoraproject.org/en-US/packaging-guidelines/Directory_Replacement/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860 --- Comment #3 from Miro Hrončok --- I have some followup comments for the package. Please don't import yet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860
thrnc...@redhat.com changed:
What|Removed |Added
CC||thrnc...@redhat.com
Flags||fedora-review+
--- Comment #2 from thrnc...@redhat.com ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GPL (v3 or later)". 102 files have
unknown license. Detailed output of licensecheck in
/home/thrnciar/rpmbuild/SPECS/1813860-micropipenv/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]:
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860 --- Comment #1 from Lumír Balhar --- *** Bug 1813263 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
