[Bug 1839888] Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation
https://bugzilla.redhat.com/show_bug.cgi?id=1839888 Fedora Update System changed: What|Removed |Added Resolution|NEXTRELEASE |ERRATA --- Comment #9 from Fedora Update System --- FEDORA-2020-b3b0efb668 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839888] Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation
https://bugzilla.redhat.com/show_bug.cgi?id=1839888 W. Michael Petullo changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-06-04 04:03:35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839888] Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation
https://bugzilla.redhat.com/show_bug.cgi?id=1839888 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- FEDORA-2020-b3b0efb668 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-b3b0efb668` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b3b0efb668 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839888] Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation
https://bugzilla.redhat.com/show_bug.cgi?id=1839888 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #7 from Fedora Update System --- FEDORA-2020-b3b0efb668 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b3b0efb668 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839888] Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation
https://bugzilla.redhat.com/show_bug.cgi?id=1839888 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyvex -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839888] Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation
https://bugzilla.redhat.com/show_bug.cgi?id=1839888 Fabian Affolter changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Fabian Affolter --- Issues were addressed, package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839888] Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation
https://bugzilla.redhat.com/show_bug.cgi?id=1839888 --- Comment #4 from W. Michael Petullo --- Spec URL: https://www.flyn.org/SRPMS/python-pyvex.spec SRPM URL: https://www.flyn.org/SRPMS/python-pyvex-8.20.5.27-1.fc32.src.rpm Description: A Python interface to libVEX and the VEX intermediate representation Fedora Account System Username: mikep - New upstream version - Indicate multiple licenses - Use macro for Source0 - Force build of egg - Remove unstreamed patch - Add GCC 10 patch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839888] Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation
https://bugzilla.redhat.com/show_bug.cgi?id=1839888
--- Comment #3 from Fabian Affolter ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Please check the licenses, it looks that some parts are under the GPLv3+,
https://github.com/angr/pyvex/blob/master/pyvex_c/LICENSE
and LGPL
https://github.com/angr/pyvex/blob/bd35abd4843f1b2b9b2d28bc891ebca3a5856e60/pyvex_c/e4c_lite.h
beside BSD
- All license files should be mentioned in %license
- "Source0:" should use a macro -> "%{pypi_source}"
- The latest release is 8.20.5.27
- Any possible available egg should be deleted in %prep.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path. -> Python Package
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD 2-clause "Simplified" License", "Unknown or generated",
"GNU Lesser General Public License", "GPL (v2)", "*No copyright* GPL
(v2 or later)", "GPL (v2 or later)", "GPL (v2 or later) (with
incorrect FSF address)", "GNU Lesser General Public License (v2.1 or
later)". 50 files have unknown license. Detailed output of
licensecheck in /home/fab/Documents/repos/reviews/1839888-python-
pyvex/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
names).
[!]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[!]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
[Bug 1839888] Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation
https://bugzilla.redhat.com/show_bug.cgi?id=1839888 --- Comment #2 from W. Michael Petullo --- Spec URL: https://www.flyn.org/SRPMS/python-pyvex.spec SRPM URL: https://www.flyn.org/SRPMS/python-pyvex-8.20.1.7-2.fc32.src.rpm Description: A Python interface to libVEX and the VEX intermediate representation Fedora Account System Username: mikep - Update BuildRequires - Fix build with version of make provided in Fedora 33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839888] Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation
https://bugzilla.redhat.com/show_bug.cgi?id=1839888 Fabian Affolter changed: What|Removed |Added Blocks||1839887 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1839887 [Bug 1839887] Review Request: python-cle - A Python interface for analyzing binary formats -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839888] Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation
https://bugzilla.redhat.com/show_bug.cgi?id=1839888
--- Comment #1 from Fabian Affolter ---
The build requirements are needing an adjustment.
[...]
raise DistutilsError(msg)
distutils.errors.DistutilsError: Could not find suitable distribution for
Requirement.parse('cffi>=1.0.3')
error: Bad exit status from /var/tmp/rpm-tmp.mLi3Wv (%build)
Bad exit status from /var/tmp/rpm-tmp.mLi3Wv (%build)
RPM build errors:
Child return code was: 1
EXCEPTION: [Error()]
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line
93, in trace
result = func(*args, **kw)
File "/usr/lib/python3.7/site-packages/mockbuild/util.py", line 776, in
do_with_status
raise exception.Error("Command failed: \n # %s\n%s" % (command, output),
child.returncode)
mockbuild.exception.Error: Command failed:
[...]
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839888] Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation
https://bugzilla.redhat.com/show_bug.cgi?id=1839888 Fabian Affolter changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@fabian-affolter.ch Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839888] Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation
https://bugzilla.redhat.com/show_bug.cgi?id=1839888 W. Michael Petullo changed: What|Removed |Added Blocks||1839889 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1839889 [Bug 1839889] Review Request: python-angr - A multi-architecture binary analysis toolkit -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
