https://bugzilla.redhat.com/show_bug.cgi?id=1858449
--- Comment #1 from Petr Pisar ---
URL and Source addresses are Ok.
TODO: Remove a trailing slash from the URL value.
Source0 archive (SHA-256:
d81e26ff6f8db10261f0087f96dc54367dcb49a9f3de8d53238f834ece19624b) is original.
Ok.
Summary verified from lib/MooX/TypeTiny.pm. Ok.
Description verified from lib/MooX/TypeTiny.pm. Ok.
License verified from Makefile.PL, lib/MooX/TypeTiny.pm, LICENSE, and README.
Ok.
No XS code, noarch BuildArch is Ok.
FIX: Build-require "perl-interpreter" (perl-MooX-TypeTiny.spec:30).
FIX: Build-require "make" (perl-MooX-TypeTiny.spec:31).
FIX: Build-require "coreutils" (perl-MooX-TypeTiny.spec:39).
TODO: Use %{make_build} and %{make_install} instead of "make %{?_smp_mflags}"
and "make pure_install".
TODO: Remove "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null
\;". It's not needed.
FIX: Build-require "perl(strict)" (Makefile.PL:1).
FIX: Build-require "perl(warnings)" (Makefile.PL:2).
TODO: Build-require "perl(:VERSION) >= 5.6" (Makefile.PL:3).
Moo::_Utils is a private module. Ok.
FIX: Build-require "perl(Moo::Role)"
(lib/MooX/TypeTiny/Role/GenerateAccessor.pm:2).
FIX: Build-require "perl(Scalar::Util)"
(lib/MooX/TypeTiny/Role/GenerateAccessor.pm:4).
FIX: Build-require "perl(Sub::Quote)"
(lib/MooX/TypeTiny/Role/GenerateAccessor.pm:3).
FIX: Build-require "perl(Types::Standard)" (t/basic.t:7).
All tests pass. Ok.
$ rpmlint perl-MooX-TypeTiny.spec
../SRPMS/perl-MooX-TypeTiny-0.002003-1.fc33.src.rpm
../RPMS/noarch/perl-MooX-TypeTiny-0.002003-1.fc33.noarch.rpm
sh: /usr/bin/python2: No such file or directory
perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US isa -> is,
visa, Lisa
perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US coercions ->
coercion, coercion's, coercion s
perl-MooX-TypeTiny.noarch: W: spelling-error %description -l en_US isa -> is,
visa, Lisa
perl-MooX-TypeTiny.noarch: W: spelling-error %description -l en_US coercions ->
coercion, coercion's, coercion s
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-MooX-TypeTiny-0.002003-1.fc33.noarch.rpm
drwxr-xr-x2 root root0 Jul 20 15:36
/usr/share/doc/perl-MooX-TypeTiny
-rw-r--r--1 root root 970 Apr 29 16:35
/usr/share/doc/perl-MooX-TypeTiny/Changes
-rw-r--r--1 root root 1186 Apr 29 16:35
/usr/share/doc/perl-MooX-TypeTiny/README
drwxr-xr-x2 root root0 Jul 20 15:36
/usr/share/licenses/perl-MooX-TypeTiny
-rw-r--r--1 root root18235 Apr 29 16:35
/usr/share/licenses/perl-MooX-TypeTiny/LICENSE
-rw-r--r--1 root root 1711 Jul 20 15:36
/usr/share/man/man3/MooX::TypeTiny.3pm.gz
drwxr-xr-x2 root root0 Jul 20 15:36
/usr/share/perl5/vendor_perl/MooX
drwxr-xr-x2 root root0 Jul 20 15:36
/usr/share/perl5/vendor_perl/MooX/TypeTiny
-rw-r--r--1 root root 1856 Apr 29 16:35
/usr/share/perl5/vendor_perl/MooX/TypeTiny.pm
drwxr-xr-x2 root root0 Jul 20 15:36
/usr/share/perl5/vendor_perl/MooX/TypeTiny/Role
-rw-r--r--1 root root 2029 Apr 26 06:40
/usr/share/perl5/vendor_perl/MooX/TypeTiny/Role/GenerateAccessor.pm
File layout and permissions are Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-MooX-TypeTiny-0.002003-1.fc33.noarch.rpm | sort -f | uniq
-c
1 perl(Moo::Role)
1 perl(Scalar::Util)
1 perl(strict)
1 perl(Sub::Quote)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
FIX: Run-require "perl(:MODULE_COMPAT...)".
FIX: Run-require "perl(Moo) >= 2.004)" (lib/MooX/TypeTiny.pm:11).
$ rpm -q --provides -p
../RPMS/noarch/perl-MooX-TypeTiny-0.002003-1.fc33.noarch.rpm | sort -f | uniq
-c
1 perl(MooX::TypeTiny) = 0.002003
1 perl(MooX::TypeTiny::Role::GenerateAccessor)
1 perl-MooX-TypeTiny = 0.002003-1.fc33
Binary provides are Ok.
$ resolvedeps rawhide
../RPMS/noarch/perl-MooX-TypeTiny-0.002003-1.fc33.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in Fedora 33
(https://koji.fedoraproject.org/koji/taskinfo?taskID=47496724). Ok.
Otherwise the package is in line with Fedora and Perl pacackaging guidelines.
Please correct the "FIX" items, consider fixing "TODO" items, and provide a new
spec file.
Resolution: Package NOT approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
