[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 chedi toueiti changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-07-24 12:21:28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 Ken Dreyer changed: What|Removed |Added CC||ktdre...@ktdreyer.com --- Comment #8 from Ken Dreyer --- Koji builders are firewalled from the internet so that builds are secure and deterministic, and the HTTPS requests will always time out. We could probably delete the intersphinx_mapping settings entirely. https://www.sphinx-doc.org/en/master/usage/extensions/intersphinx.html#confval-intersphinx_mapping There are references in docs/conf.py to cached inventory files, but it's not clear to me where those live or how they're updated: https://github.com/ansible-community/sphinx_ansible_theme/issues/22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sphinx_ansible_theme -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 --- Comment #6 from Andy Mender --- Approved! :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 Andy Mender changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 --- Comment #5 from chedi toueiti --- @andy, Could you please confirm the review as I think the last point is really not that detrimental to the package core functionality (it's part of the documentation generation process and I cannot really influence it in any way other that signalling the connectivity issue to the infrastructure team) and thanks again for taking the time to help with this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 --- Comment #4 from chedi toueiti --- The same thing happens when building with koji https://koji.fedoraproject.org/koji/taskinfo?taskID=47396069 and https://koji.fedoraproject.org/koji/taskinfo?taskID=47397719 but not from my machine, it seems there is some network issue between the build server and docs.python.org I didn't also have these issues when using copr https://copr.fedorainfracloud.org/coprs/chedi/python-packages/build/1559500/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503
--- Comment #3 from Andy Mender ---
> Thanks for your feedback, I updated the spec file accordingly and linked the
> fonts to the ones from fontsawesome/fontawesome-web packages
> (this is the way the python-sphinx_rtd_theme did it).
Looks good :)
`rpmbuild` complaints about absolute symlinks, but since
python-sphinx_rtd_theme does that, I think it's okay (can't think of a better
way):
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/FontAwesome.otf
-> /usr/share/fonts/fontawesome/FontAwesome.otf
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.eot
-> /usr/share/fonts/fontawesome/fontawesome-webfont.eot
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.svg
-> /usr/share/fonts/fontawesome/fontawesome-webfont.svg
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.ttf
-> /usr/share/fonts/fontawesome/fontawesome-webfont.ttf
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.woff
-> /usr/share/fonts/fontawesome/fontawesome-webfont.woff
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.woff2
-> /usr/share/fonts/fontawesome/fontawesome-webfont.woff2
Could you try building the package in COPR or Koji to see if everything goes
well? When running a local mock build I see that the build process is trying to
access the Internet:
+ sphinx-build-3 docs html
Running Sphinx v2.2.2
making output directory... done
loading intersphinx inventory from https://docs.python.org/2/objects.inv...
loading intersphinx inventory from ../python2.inv...
loading intersphinx inventory from https://docs.python.org/3/objects.inv...
WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://docs.python.org/2/objects.inv' not fetchable due
to :
HTTPSConnectionPool(host='docs.python.org', port=443): Max retries exceeded
with url: /2/objects.inv (Caused by
NewConnectionError(': Failed to establish a new connection: [Errno -2] Name or
service not known'))
intersphinx inventory '../python2.inv' not fetchable due to : [Errno 2] No such file or directory:
'/builddir/build/BUILD/sphinx_ansible_theme-0.3.1/docs/../python2.inv'
loading intersphinx inventory from ../python3.inv...
WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://docs.python.org/3/objects.inv' not fetchable due
to :
HTTPSConnectionPool(host='docs.python.org', port=443): Max retries exceeded
with url: /3/objects.inv (Caused by
NewConnectionError(': Failed to establish a new connection: [Errno -2] Name or
service not known'))
intersphinx inventory '../python3.inv' not fetchable due to : [Errno 2] No such file or directory:
'/builddir/build/BUILD/sphinx_ansible_theme-0.3.1/docs/../python3.inv'
loading intersphinx inventory from
http://jinja.palletsprojects.com/objects.inv...
loading intersphinx inventory from ../jinja2.inv...
loading intersphinx inventory from
https://docs.ansible.com/ansible/2.9/objects.inv...
WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'http://jinja.palletsprojects.com/objects.inv' not
fetchable due to :
HTTPConnectionPool(host='jinja.palletsprojects.com', port=80): Max retries
exceeded with url: /objects.inv (Caused by
NewConnectionError(': Failed to establish a new connection: [Errno -2] Name or
service not known'))
intersphinx inventory '../jinja2.inv' not fetchable due to : [Errno 2] No such file or directory:
'/builddir/build/BUILD/sphinx_ansible_theme-0.3.1/docs/../jinja2.inv'
It completes "successfully", but if the package ends up being incomplete,
that's also not good.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 --- Comment #2 from chedi toueiti --- @Andy Thanks for your feedback, I updated the spec file accordingly and linked the fonts to the ones from fontsawesome/fontawesome-web packages (this is the way the python-sphinx_rtd_theme did it). updated files: (same link different content) Spec URL: https://chedi.fedorapeople.org/python-sphinx_ansible_theme.spec SRPM URL: https://chedi.fedorapeople.org/python-sphinx_ansible_theme-0.3.1-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503
--- Comment #1 from Andy Mender ---
> %global srcname sphinx_ansible_theme
Is the package not actually called "sphinx-ansible-theme"?
> URL:https://github.com/ansible-community/sphinx_ansible_theme
You can use the %{srcname} macro in the URL block if it matches the name of the
GitHub repo.
> License:MIT
`licensecheck` shows that:
sphinx_ansible_theme/ext/pygments_lexer.py: BSD 2-clause "Simplified" License
You can include that file in a comment above the License block like so:
# Main program: MIT
# ext/pygments_lexer.py: BSD
License: MIT and BSD
> BuildRequires: python3-devel
> BuildRequires: python3-setuptools
> BuildRequires: python-sphinx_rtd_theme
Should be python3-sphinx_rtd_theme, I think.
From the sources I see this package bundles the following font files:
sphinx_ansible_theme/static/fonts/FontAwesome.otf
sphinx_ansible_theme/static/fonts/fontawesome-webfont.eot
sphinx_ansible_theme/static/fonts/fontawesome-webfont.svg
sphinx_ansible_theme/static/fonts/fontawesome-webfont.ttf
sphinx_ansible_theme/static/fonts/fontawesome-webfont.woff
sphinx_ansible_theme/static/fonts/fontawesome-webfont.woff2
Font Awesome seems to have a permissive license
(https://github.com/FortAwesome/Font-Awesome/blob/master/LICENSE.txt), but font
files should not be bundled together with non-font libraries.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
Note: Unversionned Python dependency found.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Python/#_dependencies
- Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
Note: Package contains %{pythonX_site(lib|arch)}/* in %files
See: https://pagure.io/packaging-committee/issue/782
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "BSD 2-clause
"Simplified" License". 51 files have unknown license. Detailed output
of licensecheck in /home/amender/1858503-python-
sphinx_ansible_theme/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[-]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[-]: Package use %makeinstall
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 Andy Mender changed: What|Removed |Added CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
