[Bug 1860772] Review Request: wev - a tool for debugging events on a Wayland window, analagous to the X11 tool xev
https://bugzilla.redhat.com/show_bug.cgi?id=1860772 --- Comment #13 from Fedora Update System --- FEDORA-2020-58d161dddf has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1860772] Review Request: wev - a tool for debugging events on a Wayland window, analagous to the X11 tool xev
https://bugzilla.redhat.com/show_bug.cgi?id=1860772 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-08-10 01:03:52 --- Comment #12 from Fedora Update System --- FEDORA-2020-d8be4cc12a has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1860772] Review Request: wev - a tool for debugging events on a Wayland window, analagous to the X11 tool xev
https://bugzilla.redhat.com/show_bug.cgi?id=1860772 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- FEDORA-2020-58d161dddf has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-58d161dddf \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-58d161dddf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. --- Comment #11 from Fedora Update System --- FEDORA-2020-d8be4cc12a has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-d8be4cc12a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d8be4cc12a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1860772] Review Request: wev - a tool for debugging events on a Wayland window, analagous to the X11 tool xev
https://bugzilla.redhat.com/show_bug.cgi?id=1860772 --- Comment #9 from Fedora Update System --- FEDORA-2020-58d161dddf has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-58d161dddf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1860772] Review Request: wev - a tool for debugging events on a Wayland window, analagous to the X11 tool xev
https://bugzilla.redhat.com/show_bug.cgi?id=1860772 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #8 from Fedora Update System --- FEDORA-2020-d8be4cc12a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d8be4cc12a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1860772] Review Request: wev - a tool for debugging events on a Wayland window, analagous to the X11 tool xev
https://bugzilla.redhat.com/show_bug.cgi?id=1860772 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/wev -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1860772] Review Request: wev - a tool for debugging events on a Wayland window, analagous to the X11 tool xev
https://bugzilla.redhat.com/show_bug.cgi?id=1860772
Artur Iwicki changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|fed...@svgames.pl
Flags||fedora-review+
--- Comment #6 from Artur Iwicki ---
Looks good to me. Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[Bug 1860772] Review Request: wev - a tool for debugging events on a Wayland window, analagous to the X11 tool xev
https://bugzilla.redhat.com/show_bug.cgi?id=1860772 --- Comment #5 from Bob Hepple --- Oh, there was a problem with that one. Here's another: Spec URL: https://download.copr.fedorainfracloud.org/results/wef/wev/fedora-31-x86_64/01587856-wev/wev.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/wef/wev/fedora-31-x86_64/01587856-wev/wev-1.0.1-0.20200730git0be512f.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1860772] Review Request: wev - a tool for debugging events on a Wayland window, analagous to the X11 tool xev
https://bugzilla.redhat.com/show_bug.cgi?id=1860772 --- Comment #4 from Bob Hepple --- Thanks Artur, Spec URL: https://download.copr.fedorainfracloud.org/results/wef/wev/fedora-31-x86_64/01587165-wev/wev.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/wef/wev/fedora-31-x86_64/01587165-wev/wev-1.0.1-0.20200729git0be512f.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1860772] Review Request: wev - a tool for debugging events on a Wayland window, analagous to the X11 tool xev
https://bugzilla.redhat.com/show_bug.cgi?id=1860772
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
--- Comment #3 from Artur Iwicki ---
>%description
>a tool for debugging events on a Wayland window, analagous to the X11 tool xev.
Start this with A Capital Letter, please.
>%build
>make
Use %make_build here. Also, you'll probably need to invoke the %set_build_flags
macro before building so that Fedora's CFLAGS are honored.
>%install
>make install PREFIX=%{buildroot}/%{_prefix}
Use %make_install here.
>%doc README.md
>%{_mandir}/man1/%{name}.1.*
The wildcard for man pages should be able to match non-compressed pages, too.
(i.e. change "1.*" to simply "1*").
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1860772] Review Request: wev - a tool for debugging events on a Wayland window, analagous to the X11 tool xev
https://bugzilla.redhat.com/show_bug.cgi?id=1860772 --- Comment #2 from Bob Hepple --- Hi Aleksei, Thanks for the link... that source0 line works fine!! Dunno how many combinations I tried but I couldn't get it to work. I also changed the Summary/Description to specify 'sway'. Spec URL: https://download.copr.fedorainfracloud.org/results/wef/wev/fedora-31-x86_64/01581351-wev/wev.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/wef/wev/fedora-31-x86_64/01581351-wev/wev-1.0.1-0.20200728git0be512f.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1860772] Review Request: wev - a tool for debugging events on a Wayland window, analagous to the X11 tool xev
https://bugzilla.redhat.com/show_bug.cgi?id=1860772
Aleksei Bavshin changed:
What|Removed |Added
CC||alebast...@gmail.com
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Aleksei Bavshin ---
> # SCM has no api to get a tarball for a given commit, so this was downloaded
> and tar'd manually:
> Source0: %{name}-%{commit}.tar.gz
Source0: %{url}/archive/%{commit}.tar.gz#/%{name}-%{commit}.tar.gz
I tried to package wev before, but didn't bother to submit because it doesn't
support Gnome/KDE/Weston. It's somewhere near the bottom of my backlog to relax
protocol requirements to support most common wayland compositors and send patch
to Drew.
Anyways,
https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01326598-wev/wev.spec
should be compliant to guidelines so feel free to reuse anything.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
