[Bug 1862628] Review Request: ocaml-time-now - Get the current time in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1862628 Jerry James changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||ocaml-time-now-0.14.0-1.fc3 ||4 Resolution|--- |NEXTRELEASE Last Closed||2020-08-19 21:44:10 --- Comment #5 from Jerry James --- Built in F33 and Rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862628] Review Request: ocaml-time-now - Get the current time in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1862628 Bug 1862628 depends on bug 1862627, which changed state. Bug 1862627 Summary: Review Request: ocaml-ppx-base - Base set of OCaml ppx rewriters https://bugzilla.redhat.com/show_bug.cgi?id=1862627 What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862628] Review Request: ocaml-time-now - Get the current time in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1862628 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-time-now -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862628] Review Request: ocaml-time-now - Get the current time in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1862628 --- Comment #3 from Jerry James --- Once again, thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862628] Review Request: ocaml-time-now - Get the current time in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1862628
Jared Smith changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #2 from Jared Smith ---
Package is APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
Note: No gcc, gcc-c++ or clang found in BuildRequires
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 9 files have unknown
license. Detailed output of licensecheck in
/home/jsmith/Documents/Fedora/Reviews/1862628-ocaml-time-
now/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Ocaml:
[?]: This should never happen
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]:
[Bug 1862628] Review Request: ocaml-time-now - Get the current time in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1862628 Jared Smith changed: What|Removed |Added Status|NEW |ASSIGNED CC||jsmith.fed...@gmail.com Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862628] Review Request: ocaml-time-now - Get the current time in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1862628 Bug 1862628 depends on bug 1862621, which changed state. Bug 1862621 Summary: Review Request: ocaml-jst-config - Compile-time configuration for Jane Street libraries https://bugzilla.redhat.com/show_bug.cgi?id=1862621 What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862628] Review Request: ocaml-time-now - Get the current time in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1862628 --- Comment #1 from Jerry James --- The 'and' has been replaced with 'with' in the BuildRequires, and the build is now verbose. New URLs: Spec URL: https://jjames.fedorapeople.org/ocaml-time-now/ocaml-time-now.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-time-now/ocaml-time-now-0.14.0-1.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862628] Review Request: ocaml-time-now - Get the current time in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1862628 Bug 1862628 depends on bug 1862617, which changed state. Bug 1862617 Summary: Review Request: ocaml-jane-street-headers - Jane Street header files https://bugzilla.redhat.com/show_bug.cgi?id=1862617 What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862628] Review Request: ocaml-time-now - Get the current time in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1862628 Jerry James changed: What|Removed |Added Blocks||1865105 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1865105 [Bug 1865105] ocaml-ppx-inline-test: FTBFS in Fedora rawhide/f33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862628] Review Request: ocaml-time-now - Get the current time in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1862628 Jerry James changed: What|Removed |Added Blocks||1858691 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1858691 [Bug 1858691] F33FailsToInstall: ocaml-ppx-inline-test, ocaml-ppx-inline-test-devel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862628] Review Request: ocaml-time-now - Get the current time in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1862628 Jerry James changed: What|Removed |Added CC||dan.cermak@cgc-instruments. ||com, rjo...@redhat.com Depends On||1862617, 1862621, 1862627 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1862617 [Bug 1862617] Review Request: ocaml-jane-street-headers - Jane Street header files https://bugzilla.redhat.com/show_bug.cgi?id=1862621 [Bug 1862621] Review Request: ocaml-jst-config - Compile-time configuration for Jane Street libraries https://bugzilla.redhat.com/show_bug.cgi?id=1862627 [Bug 1862627] Review Request: ocaml-ppx-base - Base set of OCaml ppx rewriters -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
