[Bug 1867355] Review Request: ansible-collection-ansible-posix - Ansible Collection targeting POSIX and POSIX-ish platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1867355 Andy Mender changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-09-06 08:16:02 --- Comment #7 from Andy Mender --- Closing this, since the package is already in Rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1867355] Review Request: ansible-collection-ansible-posix - Ansible Collection targeting POSIX and POSIX-ish platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1867355 --- Comment #6 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ansible-collection-ansible-posix -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1867355] Review Request: ansible-collection-ansible-posix - Ansible Collection targeting POSIX and POSIX-ish platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1867355 Andy Mender changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Andy Mender --- Looks good, package approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1867355] Review Request: ansible-collection-ansible-posix - Ansible Collection targeting POSIX and POSIX-ish platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1867355 --- Comment #4 from Igor Raits --- Hi Andy, Sorry for long delay. I've fixed mentioned issues. Thanks for review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1867355] Review Request: ansible-collection-ansible-posix - Ansible Collection targeting POSIX and POSIX-ish platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1867355 --- Comment #3 from Igor Raits --- New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ansible-posix.spec New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ansible-posix-1.1.0-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1867355] Review Request: ansible-collection-ansible-posix - Ansible Collection targeting POSIX and POSIX-ish platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1867355
--- Comment #2 from Andy Mender ---
> License:GPLv3+ and Python
A minor thing, but it's a good idea to indicate in a comment above this line
which is the main license and which files are under a different license.
licensecheck found only 1 file under the Python license:
ansible.posix-1.1.0/plugins/module_utils/mount.py: Python Software Foundation
License version 2
> %prep
> %autosetup -n ansible.posix-%{version}
> sed -i -e '1{\@^#!.*@d}' plugins/modules/*.py
> rm -vr tests/{integration,utils} .github
> find -type f -name '.gitignore' -print -delete
From rpmlint - I see 1 file escaped the Python shebang clean-up:
ansible-collection-ansible-posix.noarch: E: non-executable-script
/usr/share/ansible/collections/ansible_collections/ansible/posix/hacking/cgroup_perf_recap_graph.py
644 /usr/bin/env python
Full review matrix:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file 39_remove_license.yml is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
Review: this is not a license file. Ignore warning.
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
Review: it's a noarch package.
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GPL (v3 or later)", "Python Software
Foundation License version 2", "*No copyright* GPL (v3 or later)". 103
files have unknown license. Detailed output of licensecheck in
/home/amender/rpmbuild/SPECS/ansible-collection-ansible-posix/ansible-
collection-ansible-posix/licensecheck.txt
[!]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
Review: see earlier comment.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
Review: it's a noarch package.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does
[Bug 1867355] Review Request: ansible-collection-ansible-posix - Ansible Collection targeting POSIX and POSIX-ish platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1867355 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Blocks||1867360 ||(ansible-collection-communi ||ty-general) Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Flags||fedora-review? Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1867360 [Bug 1867360] Review Request: ansible-collection-community-general - Modules and plugins supported by Ansible community -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1867355] Review Request: ansible-collection-ansible-posix - Ansible Collection targeting POSIX and POSIX-ish platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1867355 Igor Raits changed: What|Removed |Added Summary|Review Request: |Review Request: |ansible-collection-ansible- |ansible-collection-ansible- |posix - Ansible Network |posix - Ansible Collection |Collection for Common Code |targeting POSIX and ||POSIX-ish platforms Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
