[Bug 1869128] Review Request: ilopona - toki pona dictionary
https://bugzilla.redhat.com/show_bug.cgi?id=1869128 Neal Gompa changed: What|Removed |Added Flags||needinfo?(uhh...@gmail.com) --- Comment #5 from Neal Gompa --- Carson here is the author of the application being reviewed here. He probably can change the license of the assets to CC-BY-SA (no NC). Would you please consider changing the license? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1869128] Review Request: ilopona - toki pona dictionary
https://bugzilla.redhat.com/show_bug.cgi?id=1869128 --- Comment #4 from Bob Hepple --- So we're off to RPMFusion then, Carson. Not to worry, your existing FAS credentials are good to go, the process is very similar to Fedora. Here are some notes: https://rpmfusion.org/Contributors Once approved and the git repo is setup, getting a new package prepared is similar to fedora but there is no bodhi: eg rfpkg clone free/ilopona rfpkg import ~/rpmbuild/SRPMS/ilopona-1.0.0-2.fc32.src.rpm rfpkg ci -c rfpkg push rfpkg build and branches: rfpkg switch-branch f31 git merge master rfpkg push rfpkg build ... then close bugzilla ... just send me the bugzilla link when you're ready and I'll review it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1869128] Review Request: ilopona - toki pona dictionary
https://bugzilla.redhat.com/show_bug.cgi?id=1869128 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com --- Comment #3 from Neal Gompa --- CC BY-NC-SA is not permitted in Fedora: https://fedoraproject.org/wiki/Licensing:Main#Bad_Licenses_3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1869128] Review Request: ilopona - toki pona dictionary
https://bugzilla.redhat.com/show_bug.cgi?id=1869128 --- Comment #2 from Bob Hepple --- I would suggest 'Education' as an additional category in .desktop BTW - it works fine on Fedora-31. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1869128] Review Request: ilopona - toki pona dictionary
https://bugzilla.redhat.com/show_bug.cgi?id=1869128
--- Comment #1 from Bob Hepple ---
*** The online help->License indicates "The writing in the background of the
word definitions is licensed under CC BY-NC-SA 4.0." I think this should be
mentioned in License: and %license
*** Please remove '.' from the end of the Summary: line
*** Please use desktop-file-install:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
eg something like:
BuildRequires: desktop-file-utils
...
desktop-file-install \
--dir %{buildroot}%{_datadir}/applications \
--remove-category Application \
%{name}.desktop
... --add-category/--remove-category as appropriate for ilopona - see 'man
desktop-file-install'
*** Please validate appdata.xml file
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData: The AppData
files MUST correctly validate using appstream-util validate-relax
eg. something like this:
BuildRequires: libappstream-glib
...
%check (or %install)
appstream-util validate-relax --nonet %{_metainfodir}/*.appdata.xml
... note the use of %{_metainfodir} (which can also be used in %files)
*** Minor bugaboos: optional:
$ rpmlint /home/bhepple/rpmbuild/RPMS/x86_64/ilopona-1.0.0-1.fc31.x86_64.rpm
ilopona.x86_64: W: description-shorter-than-summary
ilopona.x86_64: W: no-documentation
ilopona.x86_64: W: no-manual-page-for-binary com.github.Appadeia.ilopona
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1869128] Review Request: ilopona - toki pona dictionary
https://bugzilla.redhat.com/show_bug.cgi?id=1869128 Bob Hepple changed: What|Removed |Added Assignee|nob...@fedoraproject.org|bob.hep...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1869128] Review Request: ilopona - toki pona dictionary
https://bugzilla.redhat.com/show_bug.cgi?id=1869128 Bob Hepple changed: What|Removed |Added CC||bob.hep...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
