[Bug 1874286] Review Request: perl-Acme-Alien-DontPanic2 - Test module for Alien::Base + Alien::Build
https://bugzilla.redhat.com/show_bug.cgi?id=1874286 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #7 from Fedora Update System --- FEDORA-2020-66b75466bb has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1874286] Review Request: perl-Acme-Alien-DontPanic2 - Test module for Alien::Base + Alien::Build
https://bugzilla.redhat.com/show_bug.cgi?id=1874286
--- Comment #6 from Petr Pisar ---
(In reply to Petr Pisar from comment #1)
> If you build-require some Alien::Build plugins, please buil-require all of
> them:
> FIX: Build-require 'perl(Alien::Build::Plugin::PkgConfig)' (alienfile:3).
> FIX: Build-require 'perl(Alien::Build::Plugin::Download)' (alienfile:12).
> FIX: Build-require 'perl(Alien::Build::Plugin::Extract)' (alienfile:16).
>
Those modules do not exist. There are perl(Alien::Build::Plugin::*::Negotiate)
modules instead. First Alien::Build->apply_plugin() attempts to load the
Negotiate modules, and then it tries the original name:
if($name !~ /::/ && !$found)
{
foreach my $inc (@INC)
{
# TODO: allow negotiators to work with @INC hooks
next if ref $inc;
my $file = Path::Tiny->new("$inc/Alien/Build/Plugin/$name/Negotiate.pm");
if(-r $file)
{
$class = "Alien::Build::Plugin::${name}::Negotiate";
$pm= "Alien/Build/Plugin/$name/Negotiate.pm";
$found = 1;
last;
}
}
}
unless($found)
{
$class = "Alien::Build::Plugin::$name";
$pm= "Alien/Build/Plugin/$name.pm";
$pm=~ s{::}{/}g;
}
Perhaps perl-Alien-Module package could provide perl-Alien-Module(PkgConfig)
and then the alienfile users could require it. Or provide an artificial
perl(Alien::Build::Plugin::PkgConfig). perl-Alien-Module is becoming pretty big
with many dependencies, like cmake and libffi. Splitting it into many
plugin-specific subpackages could make the dependency tree smaller.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1874286] Review Request: perl-Acme-Alien-DontPanic2 - Test module for Alien::Base + Alien::Build
https://bugzilla.redhat.com/show_bug.cgi?id=1874286 --- Comment #5 from Fedora Update System --- FEDORA-2020-66b75466bb has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-66b75466bb` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-66b75466bb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1874286] Review Request: perl-Acme-Alien-DontPanic2 - Test module for Alien::Base + Alien::Build
https://bugzilla.redhat.com/show_bug.cgi?id=1874286 --- Comment #4 from Fedora Update System --- FEDORA-2020-66b75466bb has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-66b75466bb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1874286] Review Request: perl-Acme-Alien-DontPanic2 - Test module for Alien::Base + Alien::Build
https://bugzilla.redhat.com/show_bug.cgi?id=1874286 Jitka Plesnikova changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Acme-Alien-DontPanic2- ||2.290.1-1.fc34 Resolution|--- |RAWHIDE Last Closed||2020-09-02 06:14:08 --- Comment #3 from Jitka Plesnikova --- Thank you for the review and the repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1874286] Review Request: perl-Acme-Alien-DontPanic2 - Test module for Alien::Base + Alien::Build
https://bugzilla.redhat.com/show_bug.cgi?id=1874286 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Acme-Alien-DontPanic2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1874286] Review Request: perl-Acme-Alien-DontPanic2 - Test module for Alien::Base + Alien::Build
https://bugzilla.redhat.com/show_bug.cgi?id=1874286 Petr Pisar changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar --- The URL and Source0 addresses are usable. Ok. TODO: Remove a trailing slash from the URL value. Source0 archive (SHA-256: eb15ac418262a05d824c23c365a3c61911ff16f1fd51964d13847317c6e2681c) is original. Ok. Summary verified from lib/Acme/Alien/DontPanic2.pm. Ok. FIX: The description talks about Alien::Build. Not about Acme::Alien::DontPanic2. Please use the second paragraph from the POD like this: This module is a toy module to test the efficacy of the Alien::Base system. License verified from: Build.PL, README, LICENSE, and lib/Acme/Alien/DontPanic2.pm. Ok. FIX: Build-require 'coreutils' (perl-Acme-Alien-DontPanic2.spec:61). FIX: Build-require 'base' (lib/Acme/Alien/DontPanic2.pm:5). FIX: Do not build-require 'perl(Sort::Versions)'. It's not used anywhere. If you build-require some Alien::Build plugins, please buil-require all of them: FIX: Build-require 'perl(Alien::Build::Plugin::PkgConfig)' (alienfile:3). FIX: Build-require 'perl(Alien::Build::Plugin::Download)' (alienfile:12). FIX: Build-require 'perl(Alien::Build::Plugin::Extract)' (alienfile:16). All tests pass. Ok. $ rpmlint perl-Acme-Alien-DontPanic2.spec ../SRPMS/perl-Acme-Alien-DontPanic2-2.290.1-1.fc34.src.rpm ../RPMS/x86_64/perl-Acme-Alien-DontPanic2-2.290.1-1.fc34.x86_64.rpm sh: /usr/bin/python2: No such file or directory 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Acme-Alien-DontPanic2-2.290.1-1.fc34.x86_64.rpm drwxr-xr-x2 root root0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/Acme drwxr-xr-x2 root root0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/Acme/Alien drwxr-xr-x2 root root0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/Acme/Alien/DontPanic2 -rw-r--r--1 root root 1337 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/Acme/Alien/DontPanic2.pm drwxr-xr-x2 root root0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/Acme/Alien/DontPanic2/Install -rw-r--r--1 root root 169 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/Acme/Alien/DontPanic2/Install/Files.pm drwxr-xr-x2 root root0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/Acme drwxr-xr-x2 root root0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/Acme/Alien drwxr-xr-x2 root root0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/Acme/Alien/DontPanic2 -rw-r--r--1 root root 65 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/Acme/Alien/DontPanic2/DontPanic2.txt drwxr-xr-x2 root root0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/share drwxr-xr-x2 root root0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/share/dist drwxr-xr-x2 root root0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/share/dist/Acme-Alien-DontPanic2 drwxr-xr-x2 root root0 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/share/dist/Acme-Alien-DontPanic2/_alien -rw-r--r--1 root root 664 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/share/dist/Acme-Alien-DontPanic2/_alien/alien.json -rw-r--r--1 root root 879 Sep 1 16:05 /usr/lib64/perl5/vendor_perl/auto/share/dist/Acme-Alien-DontPanic2/_alien/alienfile drwxr-xr-x2 root root0 Sep 1 16:05 /usr/share/doc/perl-Acme-Alien-DontPanic2 -rw-r--r--1 root root 1563 Aug 28 18:37 /usr/share/doc/perl-Acme-Alien-DontPanic2/Changes -rw-r--r--1 root root 1053 Aug 28 18:37 /usr/share/doc/perl-Acme-Alien-DontPanic2/README drwxr-xr-x2 root root0 Sep 1 16:05 /usr/share/licenses/perl-Acme-Alien-DontPanic2 -rw-r--r--1 root root18352 Aug 28 18:37 /usr/share/licenses/perl-Acme-Alien-DontPanic2/LICENSE -rw-r--r--1 root root 2358 Sep 1 16:05 /usr/share/man/man3/Acme::Alien::DontPanic2.3pm.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Acme-Alien-DontPanic2-2.290.1-1.fc34.x86_64.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.32.0) 1 perl(Acme::Alien::DontPanic2) 1 perl(Alien::Base) >= 0.038 1 perl(base) 1 perl(strict) 1 perl(warnings) 1 pkgconfig(dontpanic) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1
[Bug 1874286] Review Request: perl-Acme-Alien-DontPanic2 - Test module for Alien::Base + Alien::Build
https://bugzilla.redhat.com/show_bug.cgi?id=1874286 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|ppi...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1874286] Review Request: perl-Acme-Alien-DontPanic2 - Test module for Alien::Base + Alien::Build
https://bugzilla.redhat.com/show_bug.cgi?id=1874286 Bug 1874286 depends on bug 1874274, which changed state. Bug 1874274 Summary: Review Request: perl-Alien-Build-MB - Alien::Build installer class for Module::Build https://bugzilla.redhat.com/show_bug.cgi?id=1874274 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1874286] Review Request: perl-Acme-Alien-DontPanic2 - Test module for Alien::Base + Alien::Build
https://bugzilla.redhat.com/show_bug.cgi?id=1874286 Jitka Plesnikova changed: What|Removed |Added Blocks||1873584 Depends On||1874274 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1873584 [Bug 1873584] perl-Alien-Base-ModuleBuild-1.15 is available https://bugzilla.redhat.com/show_bug.cgi?id=1874274 [Bug 1874274] Review Request: perl-Alien-Build-MB - Alien::Build installer class for Module::Build -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
