[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1877702 --- Comment #15 from Fedora Update System --- FEDORA-2020-d2c3726a7f has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1877702 --- Comment #14 from Fedora Update System --- FEDORA-2020-d2c3726a7f has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-d2c3726a7f` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d2c3726a7f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1877702 --- Comment #13 from Fedora Update System --- FEDORA-2020-e7c0f115ea has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1877702 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-09-12 16:34:28 --- Comment #12 from Fedora Update System --- FEDORA-2020-4079ec870b has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1877702 --- Comment #11 from Fedora Update System --- FEDORA-2020-bb678382b2 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-bb678382b2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-bb678382b2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1877702 --- Comment #10 from Fedora Update System --- FEDORA-2020-e7c0f115ea has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-e7c0f115ea \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e7c0f115ea See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1877702 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- FEDORA-2020-4079ec870b has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-4079ec870b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4079ec870b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1877702 --- Comment #8 from Fedora Update System --- FEDORA-2020-e7c0f115ea has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e7c0f115ea -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1877702 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2020-bb678382b2 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-bb678382b2 --- Comment #7 from Fedora Update System --- FEDORA-2020-4079ec870b has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-4079ec870b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1877702 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #5 from Robert-André Mauchin --- Looks great! Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1877702 --- Comment #4 from Mikel Olasagasti Uranga --- Thanks Robert-André for the review! Updated spec: https://mikel.olasagasti.info/tmp/fedora/revelation.spec Updated srpm: https://mikel.olasagasti.info/tmp/fedora/revelation-0.5.2-3.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1877702
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #3 from Robert-André Mauchin ---
- You need to justify that, or better find why debug patkage doesn't work
%global debug_package %{nil}
It seems the whole package is Python code, so shouldn't you add:
BuildArch: noarch
therefore %global debug_package %{nil} wouldn't be needed.
There is no binary code, no so files, no binary then you need to install into
python3_sitelib. The pyc files will go correctly into the pycache directory.
So something like
https://github.com/mikelolasagasti/revelation/commit/7d41a140de2f11d95d0a20cfe2cf8958063006cd
should be reverted.
===
From ffc556cff61ac20cd027d3653571d1cb9c3c5bb4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Robert-Andr=C3=A9=20Mauchin?=
Date: Fri, 11 Sep 2020 05:26:45 +0200
Subject: [PATCH] Install python files to pythondir instead of pyexecdir
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Signed-off-by: Robert-André Mauchin
---
src/Makefile.am | 2 +-
src/bundle/Makefile.am | 2 +-
src/lib/Makefile.am | 2 +-
src/lib/datahandler/Makefile.am | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index f136034..b4e3f56 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -13,6 +13,6 @@ CLEANFILES= revelation
revelation: revelation.py
sed \
- -e "s|\@pyexecdir\@|$(pyexecdir)|" \
+ -e "s|\@pythondir\@|$(pythondir)|" \
< $< > $@
chmod +x $@
diff --git a/src/bundle/Makefile.am b/src/bundle/Makefile.am
index 8b74ecf..33ae1fc 100644
--- a/src/bundle/Makefile.am
+++ b/src/bundle/Makefile.am
@@ -5,7 +5,7 @@
# $Id$
#
-bundledir = $(pyexecdir)/revelation/bundle
+bundledir = $(pythondir)/revelation/bundle
bundle_PYTHON = \
__init__.py \
AfSplitter.py \
diff --git a/src/lib/Makefile.am b/src/lib/Makefile.am
index 987fd46..f58996d 100644
--- a/src/lib/Makefile.am
+++ b/src/lib/Makefile.am
@@ -7,7 +7,7 @@
SUBDIRS= datahandler
-librevelationdir = $(pyexecdir)/revelation
+librevelationdir = $(pythondir)/revelation
librevelation_PYTHON = \
__init__.py \
data.py \
diff --git a/src/lib/datahandler/Makefile.am b/src/lib/datahandler/Makefile.am
index 8aeeed8..c4bfefc 100644
--- a/src/lib/datahandler/Makefile.am
+++ b/src/lib/datahandler/Makefile.am
@@ -5,7 +5,7 @@
# $Id$
#
-datahandlerdir = $(pyexecdir)/revelation/datahandler
+datahandlerdir = $(pythondir)/revelation/datahandler
datahandler_PYTHON = \
__init__.py \
base.py \
--
2.28.0
# Install python files to pythondir instead of pyexecdir
Patch0: 0001-Install-python-files-to-pythondir-instead-of-pyexecd.patch
[…]
BuildArch: noarch
[…]
BuildRequires: gettext-devel (instead of BuildRequires: gettext)
[…]
%build
autoreconf -fiv
[…]
%{python3_sitelib}/%{name}/
- %{_datadir}/metainfo → %{_metainfodir}
- Requires: hicolor-icon-theme to own the icons directory
- Remove shebang:
revelation.x86_64: E: non-executable-script
/usr/lib64/python3.9/site-packages/revelation/PBKDF2.py 644 /usr/bin/python3
revelation.x86_64: E: non-executable-script
/usr/lib64/python3.9/site-packages/revelation/bundle/PBKDFv2.py 644
/usr/bin/env python3
- Don't repeat the name of the package in the summary
revelation.src: W: name-repeated-in-summary C Revelation.
- This file is MIT, add it to the license field and add a comment explaining
the license breakdown.
Expat License
-
revelation-0.5.2/src/lib/PBKDF2.py
- Use %global not %define:
%global gettext_package revelation
%global glib2_version 2.52.0
%global gtk3_version 3.14
https://koji.fedoraproject.org/koji/taskinfo?taskID=51184586
I'm taking a break this weekend, with likely a shitty Internet, so I might not
be able to approve this package until Monday.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License, Version
2", "FSF All Permissive License",
[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1877702 --- Comment #2 from Mikel Olasagasti Uranga --- Thanks for the review Arthur! Updated spec: https://mikel.olasagasti.info/tmp/fedora/revelation.spec Updated srpm: https://mikel.olasagasti.info/tmp/fedora/revelation-0.5.2-2.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877702] Review Request: revelation - Password manager for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1877702
Artur Frenszek-Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Artur Frenszek-Iwicki ---
>Summary:Revelation is a password manager for the GNOME desktop.
No period at the end, please.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections
>License:GPL-2.0
Use the "GPLv2" short identifier.
https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses
>%install
>rm -rf $RPM_BUILD_ROOT
Don't do this.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections
>%files
>%{_datadir}/metainfo/*.appdata.xml
>%{_datadir}/applications/*.desktop
You should add a BuildRequires: for "desktop-file-utils" and
"libappstream-glib" and then validate the desktop entry and AppStream file,
either at end of %install or in %check:
$ appstream-util validate-relax --nonet $PATH_TO_FILE
$ desktop-file-validate $PATH_TO_FILE
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
