[Bug 1900181] Review Request: python-datrie - Efficiently stored Trie Data Structure for Python (uses libdatrie)
https://bugzilla.redhat.com/show_bug.cgi?id=1900181 --- Comment #9 from Fedora Update System --- FEDORA-2020-7d2e071a35 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900181] Review Request: python-datrie - Efficiently stored Trie Data Structure for Python (uses libdatrie)
https://bugzilla.redhat.com/show_bug.cgi?id=1900181 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-12-03 01:41:38 --- Comment #8 from Fedora Update System --- FEDORA-2020-f828007430 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900181] Review Request: python-datrie - Efficiently stored Trie Data Structure for Python (uses libdatrie)
https://bugzilla.redhat.com/show_bug.cgi?id=1900181 --- Comment #7 from Fedora Update System --- FEDORA-2020-7d2e071a35 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-7d2e071a35 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d2e071a35 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900181] Review Request: python-datrie - Efficiently stored Trie Data Structure for Python (uses libdatrie)
https://bugzilla.redhat.com/show_bug.cgi?id=1900181 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- FEDORA-2020-f828007430 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f828007430 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f828007430 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900181] Review Request: python-datrie - Efficiently stored Trie Data Structure for Python (uses libdatrie)
https://bugzilla.redhat.com/show_bug.cgi?id=1900181 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-7d2e071a35 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d2e071a35 --- Comment #5 from Fedora Update System --- FEDORA-2020-f828007430 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f828007430 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900181] Review Request: python-datrie - Efficiently stored Trie Data Structure for Python (uses libdatrie)
https://bugzilla.redhat.com/show_bug.cgi?id=1900181 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-7d2e071a35 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d2e071a35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900181] Review Request: python-datrie - Efficiently stored Trie Data Structure for Python (uses libdatrie)
https://bugzilla.redhat.com/show_bug.cgi?id=1900181 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-datrie -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900181] Review Request: python-datrie - Efficiently stored Trie Data Structure for Python (uses libdatrie)
https://bugzilla.redhat.com/show_bug.cgi?id=1900181 --- Comment #2 from Aniket Pradhan --- > Some of the lines are a little too long and rpmlint complains: > python3-datrie.x86_64: E: description-line-too-long C trie variable is a > dict-like object that can have unicode keys of certain ranges and Python > objects as values. > python3-datrie.x86_64: E: description-line-too-long C In addition to > implementing the mapping interface, tries facilitate finding the items for a > given prefix, and vice > python3-datrie.x86_64: E: description-line-too-long C versa, finding the > items whose keys are prefixes of a given string. As a common special case, > finding the Sure. I'll limit it to 80 characters. > > I had to add in a small patch since the string decoding inside the module > > is by default for little-endian machines. Please refer to this [0] ticket > > for more info. > > > # Patch to correctly decode on big/little endian systems > > Patch0: > > 0001-BUG-Decode-string-based-on-byteorder-of-system.patch > > If there is an open ticket somewhere, could you add it in a comment above > the Patch0 line as well? Will add that too ^.^ > Otherwise looks good. Approved! Full review below: Thanks for your review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900181] Review Request: python-datrie - Efficiently stored Trie Data Structure for Python (uses libdatrie)
https://bugzilla.redhat.com/show_bug.cgi?id=1900181
Andy Mender changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #1 from Andy Mender ---
> %global _description %{expand:
> The library implements the Trie data structure. The trie variable is a
> dict-like object that can have Unicode keys of certain ranges and Python
> objects as values.
>
> In addition to implementing the mapping interface, the library tries to
> facilitate finding the items for a given prefix, and vice versa, finding the
> items whose keys are prefixes of a given string. As a common special case,
> finding the longest-prefix item is also supported.}
Some of the lines are a little too long and rpmlint complains:
python3-datrie.x86_64: E: description-line-too-long C trie variable is a
dict-like object that can have unicode keys of certain ranges and Python
objects as values.
python3-datrie.x86_64: E: description-line-too-long C In addition to
implementing the mapping interface, tries facilitate finding the items for a
given prefix, and vice
python3-datrie.x86_64: E: description-line-too-long C versa, finding the items
whose keys are prefixes of a given string. As a common special case, finding
the
> I had to add in a small patch since the string decoding inside the module is
> by default for little-endian machines. Please refer to this [0] ticket for
> more info.
> # Patch to correctly decode on big/little endian systems
> Patch0:
> 0001-BUG-Decode-string-based-on-byteorder-of-system.patch
If there is an open ticket somewhere, could you add it in a comment above the
Patch0 line as well?
Otherwise looks good. Approved! Full review below:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Review: Internal to the package. No problem.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* GNU Lesser General
Public License", "GNU Lesser General Public License (v2.1 or later)".
19 files have unknown license. Detailed output of licensecheck in
/data/rpmbuild/SPECS/python-datrie/python-datrie/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing
[Bug 1900181] Review Request: python-datrie - Efficiently stored Trie Data Structure for Python (uses libdatrie)
https://bugzilla.redhat.com/show_bug.cgi?id=1900181 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900181] Review Request: python-datrie - Efficiently stored Trie Data Structure for Python (uses libdatrie)
https://bugzilla.redhat.com/show_bug.cgi?id=1900181 Aniket Pradhan changed: What|Removed |Added CC||package-review@lists.fedora ||project.org Component|fedora-review |Package Review Blocks||1276941 (fedora-neuro) Assignee|socho...@redhat.com |nob...@fedoraproject.org Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
