[Bug 1956580] Review Request: alchemyquest - Reflection game
https://bugzilla.redhat.com/show_bug.cgi?id=1956580 Xavier Bachelot changed: What|Removed |Added Blocks||1987765 --- Comment #12 from Xavier Bachelot --- Could you please build for F35 too so I can retire openalchemist which is FTBS on F35 ? Also you may add me as co-maintainer if you wish. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1987765 [Bug 1987765] openalchemist: FTBFS in Fedora rawhide/f35 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1956580 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1956580] Review Request: alchemyquest - Reflection game
https://bugzilla.redhat.com/show_bug.cgi?id=1956580 Dennis Payne changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2021-09-11 20:41:29 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1956580] Review Request: alchemyquest - Reflection game
https://bugzilla.redhat.com/show_bug.cgi?id=1956580 --- Comment #11 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/alchemyquest -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1956580] Review Request: alchemyquest - Reflection game
https://bugzilla.redhat.com/show_bug.cgi?id=1956580
Xavier Bachelot changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #10 from Xavier Bachelot ---
Again, sorry for the very late answer.
The only remaining nitpick from rpmlint is about a missing man page. Maybe you
can add one upstream ?
There's probably not much to document but the --openalchemist command line
option.
$ rpmlint alchemyquest
alchemyquest.x86_64: W: no-manual-page-for-binary alchemyquest
alchemyquest.x86_64: W: no-manual-page-for-binary openalchemist
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Package is APPROVED.
There was an unrelated issue building with Rawhide, so I've used F35 instead.
Let me know once this is build so I can retire openalchemist in F35 and
Rawhide.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License, Version
2", "GNU General Public License". 957 files have unknown license.
Detailed output of licensecheck in
/tmp/1956580-alchemyquest/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in
[Bug 1956580] Review Request: alchemyquest - Reflection game
https://bugzilla.redhat.com/show_bug.cgi?id=1956580 --- Comment #9 from Dennis Payne --- Spec URL: https://gitlab.com/dulsi/alchemyquest/-/raw/master/alchemyquest.spec SRPM URL: http://identicalsoftware.com/alchemyquest/alchemyquest-0.5.2-3.fc34.src.rpm I've left it as a single file. I tried building on rawhide and it worked fine for me. (Well I had to boot with a F34 kernel because rawhide wasn't booting.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1956580] Review Request: alchemyquest - Reflection game
https://bugzilla.redhat.com/show_bug.cgi?id=1956580
--- Comment #8 from Xavier Bachelot ---
Sorry for the late answer...
- The Obsoletes/Provides are still not correct.
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages
Should be:
Obsoletes : openalchemist < 0.4-34
Provides: openalchemist = 0.4-34
- Add a comment on top of the openalchemist/alchemyquest symlink
Something like:
# Running alchemyquest through an openalchemist symlink will launch the game
# in openalchemist mode w/o needing a command line option.
- Source0: line could be shortened to:
Source0:%{url}/%{name}-%{version}.tgz
- Add a comment on top of License: to explain which part belongs to which
license.
- The build succeeded on F34, but failed on Rawhide, you should probably take a
look.
- fedora-review is also complaining about the size of the data and suggests a
NoArch sub-package for that.
I feel this is overkill for less than 10 MB, do as you see fit.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1956580] Review Request: alchemyquest - Reflection game
https://bugzilla.redhat.com/show_bug.cgi?id=1956580 --- Comment #7 from Dennis Payne --- Spec URL: https://gitlab.com/dulsi/alchemyquest/-/raw/master/alchemyquest.spec SRPM URL: http://identicalsoftware.com/alchemyquest/alchemyquest-0.5.2-2.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1956580] Review Request: alchemyquest - Reflection game
https://bugzilla.redhat.com/show_bug.cgi?id=1956580 --- Comment #6 from Xavier Bachelot --- - Obsoletes/Provides need to be versioned https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages - Add a comment over the openalchemist symlink creation for clarity - Split long desktop-file-install lines - The appdata files need to be validated https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage - Spurious wildcard in the appdata line for alchemyquest in %files - Nitpick, add a second blank line between the %install and %files sections -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1956580] Review Request: alchemyquest - Reflection game
https://bugzilla.redhat.com/show_bug.cgi?id=1956580 --- Comment #5 from Dennis Payne --- Spec URL: https://gitlab.com/dulsi/alchemyquest/-/raw/master/alchemyquest.spec SRPM URL: http://identicalsoftware.com/alchemyquest/alchemyquest-0.5.2-1.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1956580] Review Request: alchemyquest - Reflection game
https://bugzilla.redhat.com/show_bug.cgi?id=1956580 --- Comment #4 from Xavier Bachelot --- I'm not very familiar with appdata, but I think it should work with either one file for alchemyquest and another for openlchemist or only one for alchemyquest. In the later case, it might be possible to have a subsection for openalchemist. The upstream doc for appdata is here, shall you want to dig deeper: https://www.freedesktop.org/software/appstream/docs/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1956580] Review Request: alchemyquest - Reflection game
https://bugzilla.redhat.com/show_bug.cgi?id=1956580 --- Comment #3 from Dennis Payne --- Minor question: Can you have two appdata files in a single rpm? Would it should the both in Gnome Software? If you installed one, it would install both? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1956580] Review Request: alchemyquest - Reflection game
https://bugzilla.redhat.com/show_bug.cgi?id=1956580
Xavier Bachelot changed:
What|Removed |Added
CC||xav...@bachelot.org
Assignee|nob...@fedoraproject.org|xav...@bachelot.org
--- Comment #2 from Xavier Bachelot ---
Hi Dennis,
Quick review, based in part on what I've seen when trying to adapt the
openalchemist spec, like you did.
Excuse the rough list below, rather short on time to make it into a nicer shape
now.
Issues:
- File conflicts with openalchemist, it would be cleaner to use
%{datadir}/alchemyquest rather than %{datadir/openalchemist}, which needs to be
changed upstream.
- A lot of s/openalchemist/alchemyquest/ needs to be done in the spec.
- I think providing 2 .desktop files, icons, etc.., one for alchemyquest and
one for openalchemist, would help transitioning from openalchemist to
alchemyquest.
- If you add the /usr/bin/openalchemist symlink, missing Obsoletes/Provides for
openalchemist.
Minor nits:
- Indent on the BR: make (which comes from the openalchemist spec, I know ;-))
- Spurious wildcard in %files for appdata and desktop file (from openalchemist
too)
- Sort BR:
Regards,
Xavier
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1956580] Review Request: alchemyquest - Reflection game
https://bugzilla.redhat.com/show_bug.cgi?id=1956580 Dennis Payne changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Dennis Payne --- I'm planning on making a new release of Alchemy Quest before the game is added to Fedora. It needs icons for Alchemy Quest and a desktop file. I'll move the appdata.xml files into the project as well. Just looking for some additional packaging feedback before this is done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
