[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114 --- Comment #11 from Robert-André Mauchin --- Sorry I must have missed it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1981114 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114 Fabio Valentini changed: What|Removed |Added Resolution|--- |RAWHIDE Status|POST|CLOSED Last Closed||2021-09-08 09:05:48 --- Comment #10 from Fabio Valentini --- Looks like Robert-André imported the version from Comment#1 without addressing any issues. I pushed a follow-up commit and builds to update the package to the latest version (3.1.0 -> 3.2.0) and fix the remaining issues ... So this is now in rawhide, f35, and f34, and I have dropped the buildroot overrides for the faulty 3.1.0 version and made ones for 3.2.0. Robert-André, if you're reading this, please add @rust-sig to this package (and your other Rust packages where you forgot to do this, for example, rust-cpufeatures). I already added it to anitya / release-monitoring and to koschei. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114 Stuart D Gathman changed: What|Removed |Added Blocks||1983745 ||(rust-ed25519-dalek) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1983745 [Bug 1983745] Review Request: rust-ed25519-dalek - Fast and efficient ed25519 EdDSA key generations, signing, and verification -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114 Stuart D Gathman changed: What|Removed |Added Flags||needinfo?(zebo...@gmail.com ||) --- Comment #9 from Stuart D Gathman --- Several packages waiting on this. Eagerly looking for files to be imported. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114
--- Comment #8 from Stuart D Gathman ---
I did a scratch build with all %{rust_arches}.
https://koji.fedoraproject.org/koji/taskinfo?taskID=73652213
It all but armv7hl have finished and unit tests run with no errors as I write.
I think there might be a misunderstanding about what cpufeatures means.
Apparently, the library can use CPU features to accelerate operations - but
only on the supported CPUs. The other arches work, but are slower. I believe
now that you should use %{rust_arches}.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114 Fabio Valentini changed: What|Removed |Added CC||decatho...@gmail.com --- Comment #7 from Fabio Valentini --- (In reply to Jens Petersen from comment #3) > One please tweak: revisiting the cpufeatures review, > I think should package can and should be enabled for all rust_arches? Hi Jens, what do you mean here? cpufeatures is an aarch64 and x86_64 specific dependency, but it is also only a dependency on those architectures ... It should always be scoped to those two targets and not be a dependency otherwise, like here, in sha2: https://github.com/RustCrypto/hashes/blob/master/sha2/Cargo.toml#L24 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-curve25519-dalek -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114 Stuart D Gathman changed: What|Removed |Added CC||stu...@gathman.org --- Comment #5 from Stuart D Gathman --- I missed that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114 --- Comment #4 from Robert-André Mauchin --- Thanks for the review(! In reply to Jens Petersen from comment #3) > One please tweak: revisiting the cpufeatures review, > I think should package can and should be enabled for all rust_arches? The readme specifies that it is only working for aarch64 and x86_64: https://crates.io/crates/cpufeatures -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114 --- Comment #3 from Jens Petersen --- One please tweak: revisiting the cpufeatures review, I think should package can and should be enabled for all rust_arches? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114
Jens Petersen changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
Status|NEW |POST
--- Comment #2 from Jens Petersen ---
I assume:
%if %{__cargo_skip_build}
BuildArch: noarchspe
%endif^^^
is a typo.
LICENSE and src headers in
https://github.com/dalek-cryptography/curve25519-dalek/tree/3.1.0
looks correct as BSD.
No surprising divergences from vanilla rust2rpm spec file.
Koji scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=73028583
does seems to build on all archs.
Looks like dalek.rs 's webcert might have expired.
Package is APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114 Jens Petersen changed: What|Removed |Added Flags||fedora-review? Doc Type|--- |If docs needed, set a value Assignee|nob...@fedoraproject.org|peter...@redhat.com -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114 --- Comment #1 from Robert-André Mauchin --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-curve25519-dalek.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-curve25519-dalek-3.1.0-1.fc35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
